From unknown Fri Aug 15 19:33:08 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14477: [PATCH] tests: numfmt: use the printf program, not the shell builtin Resent-From: Stefano Lattarini Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-coreutils@gnu.org Resent-Date: Sun, 26 May 2013 22:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14477 X-GNU-PR-Package: coreutils X-GNU-PR-Keywords: patch To: 14477@debbugs.gnu.org Cc: Stefano Lattarini X-Debbugs-Original-To: bug-coreutils@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136960606725172 (code B ref -1); Sun, 26 May 2013 22:08:02 +0000 Received: (at submit) by debbugs.gnu.org; 26 May 2013 22:07:47 +0000 Received: from localhost ([127.0.0.1]:35801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ugj6Q-0006Xx-OB for submit@debbugs.gnu.org; Sun, 26 May 2013 18:07:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46705) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ugj6O-0006Xk-43 for submit@debbugs.gnu.org; Sun, 26 May 2013 18:07:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ugj56-00011T-HY for submit@debbugs.gnu.org; Sun, 26 May 2013 18:06:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugj56-00011P-EM for submit@debbugs.gnu.org; Sun, 26 May 2013 18:06:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugj51-0002bl-5f for bug-coreutils@gnu.org; Sun, 26 May 2013 18:06:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ugj4u-00010c-Ac for bug-coreutils@gnu.org; Sun, 26 May 2013 18:06:19 -0400 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:59120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugj4u-00010Y-4h for bug-coreutils@gnu.org; Sun, 26 May 2013 18:06:12 -0400 Received: by mail-ea0-f176.google.com with SMTP id k11so3549706eaj.21 for ; Sun, 26 May 2013 15:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=LSrtl04t79bCKwt1qXhXUX8+pL06WBSqClH7VacEsdU=; b=UFr6B7wtm1y3X7j/+BfPdNPVSNLywmQqm1FiuEmDVhWv8XS//l/MdcVi8WfdgxSpdn NJh19jiykR+9DVNlP2DCC2nwuTFLbvRx/2SwBK0Fv/mfmLjAiqWtSdoHz3C0Yx76t/4A VPr/zmU05N3Or++UFESzq00PeoBaoYDImMp2U9eLgqW4rBdtY8ew9F7W4k2DbWkLDwjb wYKTkzqvDirkWSqLjVjZTdDQx7mIU40agotkEN0OTuLW0/ekXg1Ky87J8p1GekW7ivij Zxe61jh9hZYnrYdO5Tw1+Z2D0AcBH78G9iOFRcWsmtKYMvCMlIjJN/yp1tcAmH6zGeB7 +n4w== X-Received: by 10.14.215.137 with SMTP id e9mr6771669eep.44.1369605971321; Sun, 26 May 2013 15:06:11 -0700 (PDT) Received: from localhost.localdomain (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id w43sm8474967eel.0.2013.05.26.15.06.09 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 26 May 2013 15:06:10 -0700 (PDT) From: Stefano Lattarini Date: Mon, 27 May 2013 00:06:00 +0200 Message-Id: <2b1e42e98ce93bcbd22b6dce1b8a48fe111c9b55.1369605943.git.stefano.lattarini@gmail.com> X-Mailer: git-send-email 1.8.3.rc3.8.g5e49f30 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.7 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) * tests/misc/numfmt.pl: Here. This avoids a spurious failure when /bin/sh is dash (as can happen on Debian systems). --- tests/misc/numfmt.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/misc/numfmt.pl b/tests/misc/numfmt.pl index 61917fb..553f68b 100644 --- a/tests/misc/numfmt.pl +++ b/tests/misc/numfmt.pl @@ -887,7 +887,7 @@ if ($locale ne 'C') { # Reset locale to 'C' if LOCALE_FR_UTF8 doesn't output as expected # as determined by the separate printf program. - open(LOC_NUM, "LC_ALL=$locale printf \"%'d\" 1234|") + open(LOC_NUM, "env LC_ALL=$locale printf \"%'d\" 1234|") or die "Can't fork command: $!"; my $loc_num = ; close(LOC_NUM) || die "Failed to read grouped number from printf"; -- 1.8.3.rc3.8.g5e49f30 From unknown Fri Aug 15 19:33:08 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefano Lattarini Subject: bug#14477: closed (Re: bug#14477: [PATCH] tests: numfmt: use the printf program, not the shell builtin) Message-ID: References: <51A29856.5010709@draigBrady.com> <2b1e42e98ce93bcbd22b6dce1b8a48fe111c9b55.1369605943.git.stefano.lattarini@gmail.com> X-Gnu-PR-Message: they-closed 14477 X-Gnu-PR-Package: coreutils X-Gnu-PR-Keywords: patch Reply-To: 14477@debbugs.gnu.org Date: Sun, 26 May 2013 23:21:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1369610462-796-1" This is a multi-part message in MIME format... ------------=_1369610462-796-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #14477: [PATCH] tests: numfmt: use the printf program, not the shell builtin which was filed against the coreutils package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 14477@debbugs.gnu.org. --=20 14477: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D14477 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1369610462-796-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 14477-done) by debbugs.gnu.org; 26 May 2013 23:20:05 +0000 Received: from localhost ([127.0.0.1]:35834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UgkEP-0000BX-FX for submit@debbugs.gnu.org; Sun, 26 May 2013 19:20:05 -0400 Received: from mail2.vodafone.ie ([213.233.128.44]:24539) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UgkEM-0000Au-Tq for 14477-done@debbugs.gnu.org; Sun, 26 May 2013 19:20:04 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtADAF6XolFtTsJq/2dsb2JhbAANTYM4gnS/CwMBgRqDFwEBAQQyAUYQCw0LCRYPCQMCAQIBRQYNAQcBAbMXkVKNWWVfB4NUA5hkhRiMV4E4gWc Received: from unknown (HELO [192.168.1.79]) ([109.78.194.106]) by mail2.vodafone.ie with ESMTP; 27 May 2013 00:18:47 +0100 Message-ID: <51A29856.5010709@draigBrady.com> Date: Mon, 27 May 2013 00:18:46 +0100 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Stefano Lattarini Subject: Re: bug#14477: [PATCH] tests: numfmt: use the printf program, not the shell builtin References: <2b1e42e98ce93bcbd22b6dce1b8a48fe111c9b55.1369605943.git.stefano.lattarini@gmail.com> In-Reply-To: <2b1e42e98ce93bcbd22b6dce1b8a48fe111c9b55.1369605943.git.stefano.lattarini@gmail.com> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 14477-done Cc: 14477-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 05/26/2013 11:06 PM, Stefano Lattarini wrote: > * tests/misc/numfmt.pl: Here. This avoids a spurious failure when > /bin/sh is dash (as can happen on Debian systems). > --- > tests/misc/numfmt.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/misc/numfmt.pl b/tests/misc/numfmt.pl > index 61917fb..553f68b 100644 > --- a/tests/misc/numfmt.pl > +++ b/tests/misc/numfmt.pl > @@ -887,7 +887,7 @@ if ($locale ne 'C') > { > # Reset locale to 'C' if LOCALE_FR_UTF8 doesn't output as expected > # as determined by the separate printf program. > - open(LOC_NUM, "LC_ALL=$locale printf \"%'d\" 1234|") > + open(LOC_NUM, "env LC_ALL=$locale printf \"%'d\" 1234|") > or die "Can't fork command: $!"; > my $loc_num = ; > close(LOC_NUM) || die "Failed to read grouped number from printf"; > Applied. thanks, Pádraig. ------------=_1369610462-796-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 26 May 2013 22:07:47 +0000 Received: from localhost ([127.0.0.1]:35801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ugj6Q-0006Xx-OB for submit@debbugs.gnu.org; Sun, 26 May 2013 18:07:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46705) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ugj6O-0006Xk-43 for submit@debbugs.gnu.org; Sun, 26 May 2013 18:07:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ugj56-00011T-HY for submit@debbugs.gnu.org; Sun, 26 May 2013 18:06:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47595) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugj56-00011P-EM for submit@debbugs.gnu.org; Sun, 26 May 2013 18:06:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugj51-0002bl-5f for bug-coreutils@gnu.org; Sun, 26 May 2013 18:06:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ugj4u-00010c-Ac for bug-coreutils@gnu.org; Sun, 26 May 2013 18:06:19 -0400 Received: from mail-ea0-x230.google.com ([2a00:1450:4013:c01::230]:59120) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ugj4u-00010Y-4h for bug-coreutils@gnu.org; Sun, 26 May 2013 18:06:12 -0400 Received: by mail-ea0-f176.google.com with SMTP id k11so3549706eaj.21 for ; Sun, 26 May 2013 15:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=LSrtl04t79bCKwt1qXhXUX8+pL06WBSqClH7VacEsdU=; b=UFr6B7wtm1y3X7j/+BfPdNPVSNLywmQqm1FiuEmDVhWv8XS//l/MdcVi8WfdgxSpdn NJh19jiykR+9DVNlP2DCC2nwuTFLbvRx/2SwBK0Fv/mfmLjAiqWtSdoHz3C0Yx76t/4A VPr/zmU05N3Or++UFESzq00PeoBaoYDImMp2U9eLgqW4rBdtY8ew9F7W4k2DbWkLDwjb wYKTkzqvDirkWSqLjVjZTdDQx7mIU40agotkEN0OTuLW0/ekXg1Ky87J8p1GekW7ivij Zxe61jh9hZYnrYdO5Tw1+Z2D0AcBH78G9iOFRcWsmtKYMvCMlIjJN/yp1tcAmH6zGeB7 +n4w== X-Received: by 10.14.215.137 with SMTP id e9mr6771669eep.44.1369605971321; Sun, 26 May 2013 15:06:11 -0700 (PDT) Received: from localhost.localdomain (host93-95-dynamic.6-79-r.retail.telecomitalia.it. [79.6.95.93]) by mx.google.com with ESMTPSA id w43sm8474967eel.0.2013.05.26.15.06.09 for (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 26 May 2013 15:06:10 -0700 (PDT) From: Stefano Lattarini To: bug-coreutils@gnu.org Subject: [PATCH] tests: numfmt: use the printf program, not the shell builtin Date: Mon, 27 May 2013 00:06:00 +0200 Message-Id: <2b1e42e98ce93bcbd22b6dce1b8a48fe111c9b55.1369605943.git.stefano.lattarini@gmail.com> X-Mailer: git-send-email 1.8.3.rc3.8.g5e49f30 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.7 (----) X-Debbugs-Envelope-To: submit Cc: Stefano Lattarini X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) * tests/misc/numfmt.pl: Here. This avoids a spurious failure when /bin/sh is dash (as can happen on Debian systems). --- tests/misc/numfmt.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/misc/numfmt.pl b/tests/misc/numfmt.pl index 61917fb..553f68b 100644 --- a/tests/misc/numfmt.pl +++ b/tests/misc/numfmt.pl @@ -887,7 +887,7 @@ if ($locale ne 'C') { # Reset locale to 'C' if LOCALE_FR_UTF8 doesn't output as expected # as determined by the separate printf program. - open(LOC_NUM, "LC_ALL=$locale printf \"%'d\" 1234|") + open(LOC_NUM, "env LC_ALL=$locale printf \"%'d\" 1234|") or die "Can't fork command: $!"; my $loc_num = ; close(LOC_NUM) || die "Failed to read grouped number from printf"; -- 1.8.3.rc3.8.g5e49f30 ------------=_1369610462-796-1--