From debbugs-submit-bounces@debbugs.gnu.org Thu May 16 17:21:44 2013 Received: (at submit) by debbugs.gnu.org; 16 May 2013 21:21:44 +0000 Received: from localhost ([127.0.0.1]:47889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud5cO-0006VM-19 for submit@debbugs.gnu.org; Thu, 16 May 2013 17:21:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51888) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud5cM-0006VA-9a for submit@debbugs.gnu.org; Thu, 16 May 2013 17:21:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ud5c0-0003uU-5O for submit@debbugs.gnu.org; Thu, 16 May 2013 17:21:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-104.8 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD,TVD_SPACE_RATIO,UNPARSEABLE_RELAY,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:51738) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud5c0-0003uQ-2N for submit@debbugs.gnu.org; Thu, 16 May 2013 17:21:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud5bv-0005kh-A5 for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 17:21:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ud5bq-0003tV-N4 for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 17:21:15 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:37836) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud5bq-0003tP-E4 for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 17:21:10 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r4GLL7OO011065 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 16 May 2013 21:21:07 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4GLL7O0029501 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Thu, 16 May 2013 21:21:08 GMT Received: from abhmt106.oracle.com (abhmt106.oracle.com [141.146.116.58]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4GLL7qd028461 for ; Thu, 16 May 2013 21:21:07 GMT Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 16 May 2013 14:21:07 -0700 From: "Drew Adams" To: Subject: 24.3.50; emacs_backtrace.txt Date: Thu, 16 May 2013 14:21:05 -0700 Message-ID: <8C813F37B4B14362BEDAE9C4BCC38589@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac5Se0aLQR7w85DgTs60Fhw6wc3/LQ== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) Backtrace: 0x01159525 0x01159597 0x01001459 0x01021A5E 0x0101675C 0x010D82B4 0x010D938E 0x010D8F02 0x010116DA 0x010118DF 0x0101120C 0x01011326 0x01011365 0x01006765 0x010E4AC8 0x0101596C 0x01014E87 0x010E5146 0x01015511 0x01014E87 0x010E5146 0x0101596C 0x01014E87 0x010E5146 0x0101596C 0x01014E87 0x01013C70 0x010141D4 0x010E8FBA 0x01014B45 0x010E5146 0x01015511 0x01014E87 0x01014229 0x01024826 0x01010C39 0x01023814 0x01010696 0x010237CE 0x01022D88 0x010230B5 0x010029C4 0x010010F9 0x7C81776B In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2013-05-14 on ODIEONE Bzr revision: 112586 juri@jurta.org-20130514233814-nnkh1ymiqgoq2fk6 Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib' From debbugs-submit-bounces@debbugs.gnu.org Fri May 17 06:00:07 2013 Received: (at 14412) by debbugs.gnu.org; 17 May 2013 10:00:07 +0000 Received: from localhost ([127.0.0.1]:48435 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UdHSJ-00079f-0C for submit@debbugs.gnu.org; Fri, 17 May 2013 06:00:07 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:34721) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UdHSF-00078H-8R for 14412@debbugs.gnu.org; Fri, 17 May 2013 06:00:04 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MMX00000T2WG200@a-mtaout22.012.net.il> for 14412@debbugs.gnu.org; Fri, 17 May 2013 12:59:41 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MMX000OVT3H65B0@a-mtaout22.012.net.il>; Fri, 17 May 2013 12:59:41 +0300 (IDT) Date: Fri, 17 May 2013 12:59:25 +0300 From: Eli Zaretskii Subject: Re: bug#14412: 24.3.50; emacs_backtrace.txt In-reply-to: <8C813F37B4B14362BEDAE9C4BCC38589@us.oracle.com> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83fvxmrkoy.fsf@gnu.org> References: <8C813F37B4B14362BEDAE9C4BCC38589@us.oracle.com> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 14412 Cc: 14412@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: "Drew Adams" > Date: Thu, 16 May 2013 14:21:05 -0700 > > Backtrace: > 0x01159525 > 0x01159597 > 0x01001459 > 0x01021A5E > 0x0101675C > 0x010D82B4 > 0x010D938E > 0x010D8F02 > 0x010116DA > 0x010118DF > 0x0101120C > 0x01011326 > 0x01011365 > 0x01006765 > 0x010E4AC8 > 0x0101596C > 0x01014E87 > 0x010E5146 > 0x01015511 > 0x01014E87 > 0x010E5146 > 0x0101596C > 0x01014E87 > 0x010E5146 > 0x0101596C > 0x01014E87 > 0x01013C70 > 0x010141D4 > 0x010E8FBA > 0x01014B45 > 0x010E5146 > 0x01015511 > 0x01014E87 > 0x01014229 > 0x01024826 > 0x01010C39 > 0x01023814 > 0x01010696 > 0x010237CE > 0x01022D88 > 0x010230B5 > 0x010029C4 > 0x010010F9 > 0x7C81776B w32_backtrace at C:\Devel\emacs\repo\build\src/w32fns.c:7740 emacs_abort at C:\Devel\emacs\repo\build\src/w32fns.c:7772 terminate_due_to_signal at C:\Devel\emacs\repo\build\src/emacs.c:343 die at C:\Devel\emacs\repo\build\src/alloc.c:6522 unbind_to at C:\Devel\emacs\repo\build\src/eval.c:3124 Fprinc at C:\Devel\emacs\repo\build\src/print.c:658 print_error_message at C:\Devel\emacs\repo\build\src/print.c:901 Ferror_message_string at C:\Devel\emacs\repo\build\src/print.c:826 skip_debugger at C:\Devel\emacs\repo\build\src/eval.c:1566 maybe_call_debugger at C:\Devel\emacs\repo\build\src/eval.c:1607 Fsignal at C:\Devel\emacs\repo\build\src/eval.c:1431 xsignal at C:\Devel\emacs\repo\build\src/eval.c:1466 xsignal1 at C:\Devel\emacs\repo\build\src/eval.c:1481 Fsymbol_value at C:\Devel\emacs\repo\build\src/data.c:1061 exec_byte_code at C:\Devel\emacs\repo\build\src/bytecode.c:717 funcall_lambda at C:\Devel\emacs\repo\build\src/eval.c:2906 Ffuncall at C:\Devel\emacs\repo\build\src/eval.c:2723 exec_byte_code at C:\Devel\emacs\repo\build\src/bytecode.c:900 funcall_lambda at C:\Devel\emacs\repo\build\src/eval.c:2840 Ffuncall at C:\Devel\emacs\repo\build\src/eval.c:2723 exec_byte_code at C:\Devel\emacs\repo\build\src/bytecode.c:900 funcall_lambda at C:\Devel\emacs\repo\build\src/eval.c:2906 Ffuncall at C:\Devel\emacs\repo\build\src/eval.c:2723 exec_byte_code at C:\Devel\emacs\repo\build\src/bytecode.c:900 funcall_lambda at C:\Devel\emacs\repo\build\src/eval.c:2906 Ffuncall at C:\Devel\emacs\repo\build\src/eval.c:2723 Fapply at C:\Devel\emacs\repo\build\src/eval.c:2208 apply1 at C:\Devel\emacs\repo\build\src/eval.c:2442 Fcall_interactively at C:\Devel\emacs\repo\build\src/callint.c:381 Ffuncall at C:\Devel\emacs\repo\build\src/eval.c:2681 exec_byte_code at C:\Devel\emacs\repo\build\src/bytecode.c:900 funcall_lambda at C:\Devel\emacs\repo\build\src/eval.c:2840 Ffuncall at C:\Devel\emacs\repo\build\src/eval.c:2723 call1 at C:\Devel\emacs\repo\build\src/eval.c:2468 command_loop_1 at C:\Devel\emacs\repo\build\src/keyboard.c:1578 internal_condition_case at C:\Devel\emacs\repo\build\src/eval.c:1193 command_loop_2 at C:\Devel\emacs\repo\build\src/keyboard.c:1167 internal_catch at C:\Devel\emacs\repo\build\src/eval.c:964 command_loop at C:\Devel\emacs\repo\build\src/keyboard.c:1146 recursive_edit_1 at C:\Devel\emacs\repo\build\src/keyboard.c:779 Frecursive_edit at C:\Devel\emacs\repo\build\src/keyboard.c:843 main at C:\Devel\emacs\repo\build\src/emacs.c:1531 ?? at crt1.c:0 It aborts here: /* If variable has a trivial value (no forwarding), we can just set it. No need to check for constant symbols here, since that was already done by specbind. */ >>> else if (XSYMBOL (this_binding.symbol)->redirect == SYMBOL_PLAINVAL) SET_SYMBOL_VAL (XSYMBOL (this_binding.symbol), this_binding.old_value); Should we explicitly test for SYMBOLP before calling XSYMBOL? From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 25 19:48:14 2015 Received: (at 14412) by debbugs.gnu.org; 26 Dec 2015 00:48:14 +0000 Received: from localhost ([127.0.0.1]:36237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCd1p-0005rk-SI for submit@debbugs.gnu.org; Fri, 25 Dec 2015 19:48:14 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:49056) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCd1p-0005rd-3c for 14412@debbugs.gnu.org; Fri, 25 Dec 2015 19:48:13 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aCd1T-0007gC-J8; Sat, 26 Dec 2015 01:47:51 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#14412: 24.3.50; emacs_backtrace.txt References: <8C813F37B4B14362BEDAE9C4BCC38589@us.oracle.com> <83fvxmrkoy.fsf@gnu.org> Date: Sat, 26 Dec 2015 01:47:50 +0100 In-Reply-To: <83fvxmrkoy.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 17 May 2013 12:59:25 +0300") Message-ID: <87lh8ikpc9.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aCd1T-0007gC-J8 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451695671.96252@HFyq9Uvs6SBm6bT2Vh9Zdw X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14412 Cc: 14412@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > It aborts here: > > /* If variable has a trivial value (no forwarding), we can > just set it. No need to check for constant symbols here, > since that was already done by specbind. */ > >>> else if (XSYMBOL (this_binding.symbol)->redirect == SYMBOL_PLAINVAL) > SET_SYMBOL_VAL (XSYMBOL (this_binding.symbol), > this_binding.old_value); > > Should we explicitly test for SYMBOLP before calling XSYMBOL? Was this resolved, by any chance? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 05:06:50 2015 Received: (at 14412) by debbugs.gnu.org; 26 Dec 2015 10:06:50 +0000 Received: from localhost ([127.0.0.1]:36783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aClkN-0002Tx-13 for submit@debbugs.gnu.org; Sat, 26 Dec 2015 05:06:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:43614) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aClkL-0002Tk-6n for 14412@debbugs.gnu.org; Sat, 26 Dec 2015 05:06:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aClkB-0001qe-Bi for 14412@debbugs.gnu.org; Sat, 26 Dec 2015 05:06:39 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46512) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aClkB-0001qa-8N; Sat, 26 Dec 2015 05:06:35 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1117 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aClkA-00031K-Hh; Sat, 26 Dec 2015 05:06:34 -0500 Date: Sat, 26 Dec 2015 12:07:19 +0200 Message-Id: <831ta9jzfs.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: <87lh8ikpc9.fsf@gnus.org> (message from Lars Ingebrigtsen on Sat, 26 Dec 2015 01:47:50 +0100) Subject: Re: bug#14412: 24.3.50; emacs_backtrace.txt References: <8C813F37B4B14362BEDAE9C4BCC38589@us.oracle.com> <83fvxmrkoy.fsf@gnu.org> <87lh8ikpc9.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14412 Cc: 14412@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Lars Ingebrigtsen > Cc: Drew Adams , 14412@debbugs.gnu.org > Date: Sat, 26 Dec 2015 01:47:50 +0100 > > Eli Zaretskii writes: > > > It aborts here: > > > > /* If variable has a trivial value (no forwarding), we can > > just set it. No need to check for constant symbols here, > > since that was already done by specbind. */ > > >>> else if (XSYMBOL (this_binding.symbol)->redirect == SYMBOL_PLAINVAL) > > SET_SYMBOL_VAL (XSYMBOL (this_binding.symbol), > > this_binding.old_value); > > > > Should we explicitly test for SYMBOLP before calling XSYMBOL? > > Was this resolved, by any chance? Not that I could see, but adding the test is trivial, so I will do it soon. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 05:44:02 2015 Received: (at 14412-done) by debbugs.gnu.org; 26 Dec 2015 10:44:02 +0000 Received: from localhost ([127.0.0.1]:36804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCmKM-0004zU-Lp for submit@debbugs.gnu.org; Sat, 26 Dec 2015 05:44:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50144) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCmKH-0004zC-I8 for 14412-done@debbugs.gnu.org; Sat, 26 Dec 2015 05:43:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aCmK7-0001iG-L7 for 14412-done@debbugs.gnu.org; Sat, 26 Dec 2015 05:43:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aCmK7-0001iC-Hg; Sat, 26 Dec 2015 05:43:43 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1165 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aCmK6-0002tZ-Tm; Sat, 26 Dec 2015 05:43:43 -0500 Date: Sat, 26 Dec 2015 12:44:28 +0200 Message-Id: <83si2pij5f.fsf@gnu.org> From: Eli Zaretskii To: larsi@gnus.org In-reply-to: <831ta9jzfs.fsf@gnu.org> (message from Eli Zaretskii on Sat, 26 Dec 2015 12:07:19 +0200) Subject: Re: bug#14412: 24.3.50; emacs_backtrace.txt References: <8C813F37B4B14362BEDAE9C4BCC38589@us.oracle.com> <83fvxmrkoy.fsf@gnu.org> <87lh8ikpc9.fsf@gnus.org> <831ta9jzfs.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 14412-done Cc: 14412-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Date: Sat, 26 Dec 2015 12:07:19 +0200 > From: Eli Zaretskii > Cc: 14412@debbugs.gnu.org > > > From: Lars Ingebrigtsen > > Cc: Drew Adams , 14412@debbugs.gnu.org > > Date: Sat, 26 Dec 2015 01:47:50 +0100 > > > > Eli Zaretskii writes: > > > > > It aborts here: > > > > > > /* If variable has a trivial value (no forwarding), we can > > > just set it. No need to check for constant symbols here, > > > since that was already done by specbind. */ > > > >>> else if (XSYMBOL (this_binding.symbol)->redirect == SYMBOL_PLAINVAL) > > > SET_SYMBOL_VAL (XSYMBOL (this_binding.symbol), > > > this_binding.old_value); > > > > > > Should we explicitly test for SYMBOLP before calling XSYMBOL? > > > > Was this resolved, by any chance? > > Not that I could see, but adding the test is trivial, so I will do it > soon. Done. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 26 12:43:34 2015 Received: (at 14412) by debbugs.gnu.org; 26 Dec 2015 17:43:34 +0000 Received: from localhost ([127.0.0.1]:41943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCssQ-0003bD-K8 for submit@debbugs.gnu.org; Sat, 26 Dec 2015 12:43:34 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58605) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aCssO-0003ax-9Z for 14412@debbugs.gnu.org; Sat, 26 Dec 2015 12:43:32 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A5A04160CC0; Sat, 26 Dec 2015 09:43:26 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id UYKC4IDikFgB; Sat, 26 Dec 2015 09:43:25 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C61E7160D77; Sat, 26 Dec 2015 09:43:25 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0PsLRNnOG6DZ; Sat, 26 Dec 2015 09:43:25 -0800 (PST) Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9A826160CC0; Sat, 26 Dec 2015 09:43:25 -0800 (PST) To: Eli Zaretskii From: Paul Eggert Subject: Re: bug#14412: 24.3.50; emacs_backtrace.txt Organization: UCLA Computer Science Department Message-ID: <567ED1BD.2040702@cs.ucla.edu> Date: Sat, 26 Dec 2015 09:43:25 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010008080608010802070008" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14412 Cc: Lars Ingebrigtsen , 14412@debbugs.gnu.org, Drew Adams X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------010008080608010802070008 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Eli, thanks for fixing that. There's parallel code in backtrace_eval_unrewind that presumably should be fixed in a similar way. Also, it's clearer to keep the FALLTHROUGH!! comment at the actual fallthrough point. I installed the attached additional patch to try to address these issues. --------------010008080608010802070008 Content-Type: text/x-diff; name="0001-Propagate-Bug-14412-fix-to-backtrace_eval_unrewind.patch" Content-Disposition: attachment; filename*0="0001-Propagate-Bug-14412-fix-to-backtrace_eval_unrewind.patc"; filename*1="h" Content-Transfer-Encoding: quoted-printable >From 60764d06b76ce39c2c902c302c29954945ed0e9c Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 26 Dec 2015 09:30:22 -0800 Subject: [PATCH] Propagate Bug#14412 fix to backtrace_eval_unrewind MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit * src/eval.c (unbind_to): Redo so that the FALLTHROUGH!! comment becomes accurate again. This shouldn=E2=80=99t affect behavior. (backtrace_eval_unrewind): Apply the recent unbind_to fix here, too. --- src/eval.c | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/eval.c b/src/eval.c index 571681c..bd0cf68 100644 --- a/src/eval.c +++ b/src/eval.c @@ -3196,15 +3196,12 @@ unbind_to (ptrdiff_t count, Lisp_Object value) { /* If variable has a trivial value (no forwarding), we can just set it. No need to check for constant symbols here, since that was already done by specbind. */ - Lisp_Object symbol =3D specpdl_symbol (specpdl_ptr); - if (SYMBOLP (symbol)) + Lisp_Object sym =3D specpdl_symbol (specpdl_ptr); + if (SYMBOLP (sym) && XSYMBOL (sym)->redirect =3D=3D SYMBOL_PLAINVAL= ) { - struct Lisp_Symbol *sym =3D XSYMBOL (symbol); - if (sym->redirect =3D=3D SYMBOL_PLAINVAL) - { - SET_SYMBOL_VAL (sym, specpdl_old_value (specpdl_ptr)); - break; - } + SET_SYMBOL_VAL (XSYMBOL (sym), + specpdl_old_value (specpdl_ptr)); + break; } else { /* FALLTHROUGH!! @@ -3412,12 +3409,12 @@ backtrace_eval_unrewind (int distance) { /* If variable has a trivial value (no forwarding), we can just set it. No need to check for constant symbols here, since that was already done by specbind. */ - struct Lisp_Symbol *sym =3D XSYMBOL (specpdl_symbol (tmp)); - if (sym->redirect =3D=3D SYMBOL_PLAINVAL) + Lisp_Object sym =3D specpdl_symbol (tmp); + if (SYMBOLP (sym) && XSYMBOL (sym)->redirect =3D=3D SYMBOL_PLAINVAL= ) { Lisp_Object old_value =3D specpdl_old_value (tmp); - set_specpdl_old_value (tmp, SYMBOL_VAL (sym)); - SET_SYMBOL_VAL (sym, old_value); + set_specpdl_old_value (tmp, SYMBOL_VAL (XSYMBOL (sym))); + SET_SYMBOL_VAL (XSYMBOL (sym), old_value); break; } else --=20 2.5.0 --------------010008080608010802070008-- From unknown Fri Aug 15 04:05:08 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 24 Jan 2016 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator