From unknown Mon Aug 18 06:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14411: 24.3.50; compile.el: Better file search for parallel builds Resent-From: David Engster Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2013 19:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 14411@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13687314174965 (code B ref -1); Thu, 16 May 2013 19:11:02 +0000 Received: (at submit) by debbugs.gnu.org; 16 May 2013 19:10:17 +0000 Received: from localhost ([127.0.0.1]:47760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud3ZB-0001I2-1K for submit@debbugs.gnu.org; Thu, 16 May 2013 15:10:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47506) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud3Z7-0001Hn-S6 for submit@debbugs.gnu.org; Thu, 16 May 2013 15:10:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ud3Yp-0003bS-MN for submit@debbugs.gnu.org; Thu, 16 May 2013 15:09:56 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-99.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD, T_DKIM_INVALID,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:54780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud3Yp-0003bO-Ip for submit@debbugs.gnu.org; Thu, 16 May 2013 15:09:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud3Yo-0000bL-Bf for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 15:09:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ud3Yl-0003au-Nb for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 15:09:54 -0400 Received: from randomsample.de ([83.169.19.17]:37956) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ud3Yl-0003ZK-A6 for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 15:09:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=Fo+9cz1cEWB1hgS8tOnfz0bRUHlSN6PdmFEV3IesbnM=; b=RDY7qCWvK6Gm7dXgZO70NeahwFArMWI8BbnjsyDxHmKX6I517Aje9VbrqlyiSpc8wP1HLOPUHlnTlmVPVo5nIRCJwTqvHEqrUmRHXanw9mcJAw/5x8olc0SNydiVGVxi; Received: from dslc-082-083-047-061.pools.arcor-ip.net ([82.83.47.61] helo=spaten) by randomsample.de with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Ud3Yd-00036t-Gp for bug-gnu-emacs@gnu.org; Thu, 16 May 2013 21:09:43 +0200 From: David Engster Date: Thu, 16 May 2013 21:09:38 +0200 Message-ID: <87d2sqzqq5.fsf@engster.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain When doing parallel builds using GNU Make, jumping to the location of a warning/error from the compilation buffer often does not work. This is because GNU Make enters different directories at the same time, and the resulting output is intermixed. The attached patch fixes this by looking at all directories which were entered up to the point of the warning/error, instead of just taking the directly preceding one. I'm aware that this is not a perfect solution, since those directories might contain files with identical names, in which case Emacs might show the wrong one, but IMO it's still an improvement over the current situation. This feature can also be disabled through a new variable. -David --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=compile-parallel-patch.diff === modified file 'lisp/progmodes/compile.el' --- lisp/progmodes/compile.el 2013-04-24 13:50:22 +0000 +++ lisp/progmodes/compile.el 2013-05-16 18:49:35 +0000 @@ -611,6 +611,18 @@ (string :tag "Directory"))) :group 'compilation) +(defcustom compilation-search-all-directories t + "Whether further upward directories should be used when searching a file. +When doing a parallel build, several files from different +directories can be compiled at the same time. This makes it +difficult to determine the base directory for a relative file +name in a compiler error or warning. If this variable is +non-nil, instead of just relying on the previous directory change +in the compilation buffer, all other directories further upwards +will be used as well." + :type 'boolean + :group 'compilation) + ;;;###autoload (defcustom compile-command (purecopy "make -k ") "Last shell command used to do a compilation; default for next compilation. @@ -2616,6 +2628,25 @@ (find-file-noselect name)) fmts (cdr fmts))) (setq dirs (cdr dirs))) + ;; If we haven't found it, this might be a parallel build. + ;; Search the directories further up the buffer. + (when (and (null buffer) + compilation-search-all-directories) + (with-current-buffer (marker-buffer marker) + (save-excursion + (goto-char (marker-position marker)) + (goto-char (compilation--previous-directory (point))) + (setq dirs (cdr (or (get-text-property (1- (point)) 'compilation-directory) + (get-text-property (point) 'compilation-directory)))))) + (while (and dirs (null buffer)) + (setq thisdir (car dirs) + fmts formats) + (while (and fmts (null buffer)) + (setq name (expand-file-name (format (car fmts) filename) thisdir) + buffer (and (file-exists-p name) + (find-file-noselect name)) + fmts (cdr fmts))) + (setq dirs (cdr dirs)))) (while (null buffer) ;Repeat until the user selects an existing file. ;; The file doesn't exist. Ask the user where to find it. (save-excursion ;This save-excursion is probably not right. --=-=-=-- From unknown Mon Aug 18 06:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14411: 24.3.50; compile.el: Better file search for parallel builds Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 May 2013 19:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: David Engster Cc: 14411@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 14411-submit@debbugs.gnu.org id=B14411.13687320406168 (code B ref 14411); Thu, 16 May 2013 19:21:02 +0000 Received: (at 14411) by debbugs.gnu.org; 16 May 2013 19:20:40 +0000 Received: from localhost ([127.0.0.1]:47775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud3jE-0001bR-B0 for submit@debbugs.gnu.org; Thu, 16 May 2013 15:20:40 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:37969) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ud3jB-0001bC-Pm for 14411@debbugs.gnu.org; Thu, 16 May 2013 15:20:39 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MMW00E00O9JY500@a-mtaout22.012.net.il> for 14411@debbugs.gnu.org; Thu, 16 May 2013 22:19:49 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MMW00EITOD0K1A0@a-mtaout22.012.net.il>; Thu, 16 May 2013 22:19:49 +0300 (IDT) Date: Thu, 16 May 2013 22:19:48 +0300 From: Eli Zaretskii In-reply-to: <87d2sqzqq5.fsf@engster.org> X-012-Sender: halo1@inter.net.il Message-id: <83r4h6spez.fsf@gnu.org> References: <87d2sqzqq5.fsf@engster.org> X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: David Engster > Date: Thu, 16 May 2013 21:09:38 +0200 > > When doing parallel builds using GNU Make, jumping to the location of a > warning/error from the compilation buffer often does not work. This is > because GNU Make enters different directories at the same time, and the > resulting output is intermixed. The attached patch fixes this by looking > at all directories which were entered up to the point of the > warning/error, instead of just taking the directly preceding one. I'm > aware that this is not a perfect solution, since those directories might > contain files with identical names, in which case Emacs might show the > wrong one, but IMO it's still an improvement over the current > situation. This feature can also be disabled through a new variable. [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4496] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > From: David Engster > Date: Thu, 16 May 2013 21:09:38 +0200 > > When doing parallel builds using GNU Make, jumping to the location of a > warning/error from the compilation buffer often does not work. This is > because GNU Make enters different directories at the same time, and the > resulting output is intermixed. The attached patch fixes this by looking > at all directories which were entered up to the point of the > warning/error, instead of just taking the directly preceding one. I'm > aware that this is not a perfect solution, since those directories might > contain files with identical names, in which case Emacs might show the > wrong one, but IMO it's still an improvement over the current > situation. This feature can also be disabled through a new variable. I think this problem should be fixed in GNU Make. And, lo and behold, the next release of GNU Make will have a switch that will prevent the directories from being mixed. Perhaps it would be better to teach compile.el to detect support for that switch (-O or --output-sync) and use it if available when -j is also used, than to kludge around the current behavior. From unknown Mon Aug 18 06:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14411: 24.3.50; compile.el: Better file search for parallel builds Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 14:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 14411@debbugs.gnu.org, David Engster Received: via spool by 14411-submit@debbugs.gnu.org id=B14411.160043976221428 (code B ref 14411); Fri, 18 Sep 2020 14:37:01 +0000 Received: (at 14411) by debbugs.gnu.org; 18 Sep 2020 14:36:02 +0000 Received: from localhost ([127.0.0.1]:43933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJHUY-0005ZO-Bh for submit@debbugs.gnu.org; Fri, 18 Sep 2020 10:36:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:55290) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJHUW-0005Yw-Iv for 14411@debbugs.gnu.org; Fri, 18 Sep 2020 10:36:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=0lR92qUwMD5FsF3sviO22wS1sbT79mcJ5wHKY2ARJH0=; b=n+yo4b8IE/XUgLFYQDYbF5ypkb iQ9wovSw2kvslnO0XI+1ajlv45bAzzNVsgwhf/ZjGN1IAQrOB/IYmZwomRAE3SlBiuUtKxQpDgNme G0cQI+KSp/twImiXndk66vsH2nBDcZq3ORt7QgS6u1W3z2KtmNzGYigIkN+2ygryxues=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJHUN-0006qs-Nx; Fri, 18 Sep 2020 16:35:54 +0200 From: Lars Ingebrigtsen References: <87d2sqzqq5.fsf@engster.org> <83r4h6spez.fsf@gnu.org> X-Now-Playing: Saito Koji's _433-1_: "433_076" Date: Fri, 18 Sep 2020 16:35:50 +0200 In-Reply-To: <83r4h6spez.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 16 May 2013 22:19:48 +0300") Message-ID: <87h7rvf8zd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I think this problem should be fixed in GNU Make. And, lo and behold, > the next release of GNU Make will have a switch that will prevent the > directories from being mixed. Perhaps it would be bett [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I think this problem should be fixed in GNU Make. And, lo and behold, > the next release of GNU Make will have a switch that will prevent the > directories from being mixed. Perhaps it would be better to teach > compile.el to detect support for that switch (-O or --output-sync) and > use it if available when -j is also used, than to kludge around the > current behavior. Well, we could just say that it's up to people to type -Oj instead of just -j... On the other hand, David's patch seems to fix this stuff automatically, so my preference would be to just drop the defcustom and do the search, anyway -- it's only done if we can't find the file name otherwise, so it should only help, and never (?) hurt? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 06:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14411: 24.3.50; compile.el: Better file search for parallel builds Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 15:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Lars Ingebrigtsen Cc: 14411@debbugs.gnu.org, deng@randomsample.de Received: via spool by 14411-submit@debbugs.gnu.org id=B14411.160044336111699 (code B ref 14411); Fri, 18 Sep 2020 15:36:02 +0000 Received: (at 14411) by debbugs.gnu.org; 18 Sep 2020 15:36:01 +0000 Received: from localhost ([127.0.0.1]:44192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJIQb-00032d-F0 for submit@debbugs.gnu.org; Fri, 18 Sep 2020 11:36:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJIQa-00032O-1B for 14411@debbugs.gnu.org; Fri, 18 Sep 2020 11:36:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49627) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kJIQR-0005Z9-Lb; Fri, 18 Sep 2020 11:35:53 -0400 Received: from [176.228.60.248] (port=4050 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kJIQP-0004ug-Qe; Fri, 18 Sep 2020 11:35:50 -0400 Date: Fri, 18 Sep 2020 18:36:04 +0300 Message-Id: <83ft7f3xnf.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87h7rvf8zd.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 18 Sep 2020 16:35:50 +0200) References: <87d2sqzqq5.fsf@engster.org> <83r4h6spez.fsf@gnu.org> <87h7rvf8zd.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: David Engster , 14411@debbugs.gnu.org > Date: Fri, 18 Sep 2020 16:35:50 +0200 > > On the other hand, David's patch seems to fix this stuff automatically, > so my preference would be to just drop the defcustom and do the search, > anyway -- it's only done if we can't find the file name otherwise, so it > should only help, and never (?) hurt? I don't mind installing the feature. But can we just make sure it is still effective, with modern Make and our current Makefiles? From unknown Mon Aug 18 06:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14411: 24.3.50; compile.el: Better file search for parallel builds Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Sep 2020 15:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 14411@debbugs.gnu.org, deng@randomsample.de Received: via spool by 14411-submit@debbugs.gnu.org id=B14411.160044357512036 (code B ref 14411); Fri, 18 Sep 2020 15:40:01 +0000 Received: (at 14411) by debbugs.gnu.org; 18 Sep 2020 15:39:35 +0000 Received: from localhost ([127.0.0.1]:44196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJIU2-000383-Ua for submit@debbugs.gnu.org; Fri, 18 Sep 2020 11:39:35 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kJIU2-00037r-12 for 14411@debbugs.gnu.org; Fri, 18 Sep 2020 11:39:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Q+BfNa9zGHYLII1lmFpPl8/d6IpWf6D7Uy6zK/7cxck=; b=cY6r6TS5EBkQzjcJUJ9/54KyWw f/BQcZJR829eG89RSfg/4Fpcygo9ZqhmDsLMEKbjCSX5SxRJFR7AtcYGuC0+K6uJwX3k9Bey4tQat nI/PdFWc29lcJ2jiymliVYKYmuYeqEJ/sHNrPsWemF3yzUZfhhLwD3nmRDBh7FGOmrC0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kJITt-0007Px-0x; Fri, 18 Sep 2020 17:39:27 +0200 From: Lars Ingebrigtsen References: <87d2sqzqq5.fsf@engster.org> <83r4h6spez.fsf@gnu.org> <87h7rvf8zd.fsf@gnus.org> <83ft7f3xnf.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAQAAAAB/ecQqAAAABGdBTUEAALGPC/xhBQAAAAJi S0dEAAHdihOkAAAACXBIWXMAAA7DAAAOwwHHb6hkAAAAB3RJTUUH5AkQCyMGR5f7bwAAABBJREFU GNNj+A8GDKMUdSgAT1Qe8M8TmhgAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMDktMTZUMTE6MzU6 MDUrMDA6MDBrguOZAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTA5LTE2VDExOjM1OjA1KzAwOjAw Gt9bJQAAAABJRU5ErkJggg== X-Now-Playing: Saito Koji's _433-1_: "433_090" Date: Fri, 18 Sep 2020 17:39:24 +0200 In-Reply-To: <83ft7f3xnf.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 18 Sep 2020 18:36:04 +0300") Message-ID: <875z8bdrgz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> On the other hand, David's patch seems to fix this stuff automatically, >> so my preference would be to just drop the defcustom and do the search, >> anyway -- it's only done if we can't find the f [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> On the other hand, David's patch seems to fix this stuff automatically, >> so my preference would be to just drop the defcustom and do the search, >> anyway -- it's only done if we can't find the file name otherwise, so it >> should only help, and never (?) hurt? > > I don't mind installing the feature. But can we just make sure it is > still effective, with modern Make and our current Makefiles? Well, this isn't just an issue with Emacs' Makefiles, but any project that's building under `M-x compile'. But, true, I have no idea whether modern Make has this issue at all. The presence of the -O switch seems to imply that it's still an issue. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 06:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14411: 24.3.50; compile.el: Better file search for parallel builds Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Oct 2020 14:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 14411@debbugs.gnu.org, deng@randomsample.de Received: via spool by 14411-submit@debbugs.gnu.org id=B14411.16027733927502 (code B ref 14411); Thu, 15 Oct 2020 14:50:02 +0000 Received: (at 14411) by debbugs.gnu.org; 15 Oct 2020 14:49:52 +0000 Received: from localhost ([127.0.0.1]:56177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT4Zk-0001ww-AF for submit@debbugs.gnu.org; Thu, 15 Oct 2020 10:49:52 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT4Zi-0001wg-6L for 14411@debbugs.gnu.org; Thu, 15 Oct 2020 10:49:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OEWBHYkRbHSY+5wa5QorYmoJ6gazKXKfaSdJpYS+8z0=; b=CkAxftezZimKYZD5Tcu2rWuFAn ENgplTUxxn9BV11B72FliHRxYTGDI/EVMnem2fQA4FlNMMBENEBx90GF86EAsCfT5Y4aH32aCQW3N tSGD5/Imn/37jVy+qzPd542SYStrdrlevSw7grK0o7C0ZjwuQ98HFo7jW/PxJuJPAd3E=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kT4ZY-0005P8-JV; Thu, 15 Oct 2020 16:49:43 +0200 From: Lars Ingebrigtsen References: <87d2sqzqq5.fsf@engster.org> <83r4h6spez.fsf@gnu.org> <87h7rvf8zd.fsf@gnus.org> <83ft7f3xnf.fsf@gnu.org> <875z8bdrgz.fsf@gnus.org> X-Now-Playing: Juana Molina's _WED 21_: "El oso de la guarda" Date: Thu, 15 Oct 2020 16:49:39 +0200 In-Reply-To: <875z8bdrgz.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 18 Sep 2020 17:39:24 +0200") Message-ID: <87d01jwnlo.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: >> I don't mind installing the feature. But can we just make sure it is >> still effective, with modern Make and our current Makefiles? > > Well, this isn't just an issue with Emacs' Makefiles, but an [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: >> I don't mind installing the feature. But can we just make sure it is >> still effective, with modern Make and our current Makefiles? > > Well, this isn't just an issue with Emacs' Makefiles, but any project > that's building under `M-x compile'. I went ahead and installed the change in Emacs 28 -- it shouldn't break anything (I hope; I've tried a couple of test cases by rearranging the output in the *compilation* buffer and seeing that it doesn't), and it should help make this work automatically for those who see this problem. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 15 10:49:57 2020 Received: (at control) by debbugs.gnu.org; 15 Oct 2020 14:49:58 +0000 Received: from localhost ([127.0.0.1]:56180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT4Zp-0001xC-JT for submit@debbugs.gnu.org; Thu, 15 Oct 2020 10:49:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:43998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kT4Zn-0001wn-J4 for control@debbugs.gnu.org; Thu, 15 Oct 2020 10:49:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=/+I4kIIJuYLkP3esFbEGt6F84wddu4fcrvGjkHGQL50=; b=WBDA1Zjumf8KEavIj3DfNy4SRa J2B/Is6B5y7bAdMUIczqFMU2N2NNy69KleECO7BGw27CUrLAvnVFWCATWnBBCUEwM1nkAWsWoNApC XAVWvWBAe1N7lF7qEJP0UTKovRyMKGS9KvRTeLySoCQ4c704hkbsCtLkTM0qJKoJxXMg=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kT4Zf-0005PF-S1 for control@debbugs.gnu.org; Thu, 15 Oct 2020 16:49:50 +0200 Date: Thu, 15 Oct 2020 16:49:46 +0200 Message-Id: <87blh3wnlh.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #14411 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 14411 fixed close 14411 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 14411 fixed close 14411 28.1 quit