GNU bug report logs - #14392
24.3.50; VHDL mode rebinds DEL and M-DEL

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14392 in the body.
You can then email your comments to 14392 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; VHDL mode rebinds DEL and M-DEL
Date: Sun, 12 May 2013 09:27:01 -0700

[Message part 1 (text/plain, inline)]

I'm using a very recent build of emacs from source:

  GNU Emacs 24.3.50.1 (x86_64-pc-linux-gnu, X toolkit, Xaw scroll bars)
 of 2013-04-27 on dex, modified by Debian
 (emacs-snapshot package, version 2:20130427-1)
Windowing system distributor `The X.Org Foundation', version 11.0.11204000
System Description:	Debian GNU/Linux 7.0 (wheezy)

VHDL mode sets up many of its own key bindings. Two of these bindings
aren't really VHDL specific, but rather represent user preferences:

    (define-key vhdl-mode-map [delete]	     'delete-char)
    (define-key vhdl-mode-map [(meta delete)] 'kill-word))

These redefine the behaviour of DEL and M-DEL in VHDL mode in a way
that's not specific to VHDL. The new behavior of M-DEL is different from
the emacs default, which is to kill backward, not forward. There's no
reason to have this in VHDL mode, and it acts only to surprise users
with non-convention behavior.

The attached patch removes these bindings.

[0001-vhdl-mode-removed-key-bindings-not-specific-to-VHDL.patch (text/x-diff, attachment)]

Message #8 received at 14392 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 14392 <at> debbugs.gnu.org
Subject: Re: bug#14392: 24.3.50; VHDL mode rebinds DEL and M-DEL
Date: Sun, 12 May 2013 19:51:18 +0300

> From: Dima Kogan <dima <at> secretsauce.net>
> Date: Sun, 12 May 2013 09:27:01 -0700
> 
>     (define-key vhdl-mode-map [delete]	     'delete-char)
>     (define-key vhdl-mode-map [(meta delete)] 'kill-word))
> 
> These redefine the behaviour of DEL and M-DEL in VHDL mode in a way
> that's not specific to VHDL. The new behavior of M-DEL is different from
> the emacs default, which is to kill backward, not forward.

The above bindings bind 'delete', not DEL, which is a different key.

Message #11 received at 14392 <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: 14392 <at> debbugs.gnu.org
Subject: Re: bug#14392: 24.3.50; VHDL mode rebinds DEL and M-DEL
Date: Sun, 12 May 2013 15:17:52 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Dima Kogan <dima <at> secretsauce.net>
>> Date: Sun, 12 May 2013 09:27:01 -0700
>> 
>>     (define-key vhdl-mode-map [delete]	     'delete-char)
>>     (define-key vhdl-mode-map [(meta delete)] 'kill-word))
>> 
>> These redefine the behaviour of DEL and M-DEL in VHDL mode in a way
>> that's not specific to VHDL. The new behavior of M-DEL is different from
>> the emacs default, which is to kill backward, not forward.
>
> The above bindings bind 'delete', not DEL, which is a different key.

Thanks for looking, Eli. You're right, they are different. For some
yet-unknown reason I was seeing those lines break my M-backspace
binding. Restarting with 'emacs -Q' made it work, even with those lines
enabled.

Regardless, I do think the patch is appropriate. Suppose a user has
customized those particular keys in their .emacs to have some particular
global binding. Why would it be desirable to override those
customizations for VHDL?

Message #14 received at 14392 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: Reto Zimmermann <reto <at> gnu.org>, 14392 <at> debbugs.gnu.org
Subject: Re: bug#14392: 24.3.50; VHDL mode rebinds DEL and M-DEL
Date: Fri, 17 May 2013 20:26:40 -0400

Dima Kogan wrote:

> VHDL mode sets up many of its own key bindings. Two of these bindings
> aren't really VHDL specific, but rather represent user preferences:
>
>     (define-key vhdl-mode-map [delete]	     'delete-char)
>     (define-key vhdl-mode-map [(meta delete)] 'kill-word))

Thanks; removed.

BTW, there is no need for vhdl-template-map-init, vhdl-model-map-init,
vhdl-mode-map-init, ... to exist. The variable can simply be initialized
in the defvar in the normal way.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.