From unknown Tue Jun 24 10:30:01 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14390 <14390@debbugs.gnu.org> To: bug#14390 <14390@debbugs.gnu.org> Subject: Status: 24.3.50; (wrong-type-argument stringp t) from `read-regexp' Reply-To: bug#14390 <14390@debbugs.gnu.org> Date: Tue, 24 Jun 2025 17:30:01 +0000 retitle 14390 24.3.50; (wrong-type-argument stringp t) from `read-regexp' reassign 14390 emacs submitter 14390 "Drew Adams" severity 14390 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 17:54:48 2013 Received: (at submit) by debbugs.gnu.org; 11 May 2013 21:54:48 +0000 Received: from localhost ([127.0.0.1]:36913 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbHkd-0005GP-CA for submit@debbugs.gnu.org; Sat, 11 May 2013 17:54:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60248) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbHkZ-0005GC-Ly for submit@debbugs.gnu.org; Sat, 11 May 2013 17:54:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbHkG-0004pJ-Qi for submit@debbugs.gnu.org; Sat, 11 May 2013 17:54:25 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.9 required=5.0 tests=BAYES_50, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbHkG-0004pF-NQ for submit@debbugs.gnu.org; Sat, 11 May 2013 17:54:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbHkF-0000gh-MK for bug-gnu-emacs@gnu.org; Sat, 11 May 2013 17:54:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UbHkD-0004or-Vq for bug-gnu-emacs@gnu.org; Sat, 11 May 2013 17:54:23 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UbHkD-0004om-OO for bug-gnu-emacs@gnu.org; Sat, 11 May 2013 17:54:21 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r4BLsIax030144 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 11 May 2013 21:54:19 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4BLsIe8009952 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Sat, 11 May 2013 21:54:19 GMT Received: from abhmt105.oracle.com (abhmt105.oracle.com [141.146.116.57]) by userz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4BLsHct016781 for ; Sat, 11 May 2013 21:54:18 GMT Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 11 May 2013 14:54:17 -0700 From: "Drew Adams" To: Subject: 24.3.50; (wrong-type-argument stringp t) from `read-regexp' Date: Sat, 11 May 2013 14:54:12 -0700 Message-ID: <5C8F1D9AC91F44D8B2802A79E962581C@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 thread-index: Ac5OkhLDqVoVVCSJQ4Cuwfi9b6ecsg== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.2 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) The backtrace is not from emacs -Q, but I think the same problem is there. `read-regexp' binds SUGGESTIONS to this: (append suggestions (list (find-tag-default-as-regexp) ; <======= SHOULD return a string (car regexp-search-ring) (regexp-quote (or (car search-ring) "")) (car (symbol-value query-replace-from-history-variable)))) The problem is (find-tag-default-as-regexp), which will return `t' when TAG is nil. `t' is not a valid suggestion: SUGGESTIONS must be a list of strings. Debugger entered--Lisp error: (wrong-type-argument stringp t) * icicle-ORIG-read-from-minibuffer("Flush lines containing match for regexp: " t nil nil regexp-history (t "^\\*.*" "keep-lines-read-args" "bookmarkp-bmenu-show-only-varlists") t) * read-from-minibuffer("Flush lines containing match for regexp: " nil nil nil regexp-history (t "^\\*.*" "keep-lines-read-args" "bookmarkp-bmenu-show-only-varlists") t) * read-regexp("Flush lines containing match for regexp") * (list (read-regexp prompt) nil nil t) * (lambda (prompt) "Read arguments for `keep-lines' and friends.\nPrompt for a regexp with PROMPT.\nValue is a list, (REGEXP)." (list (read-regexp prompt) nil nil t))("Flush lines containing match for regexp") * apply((lambda (prompt) "Read arguments for `keep-lines' and friends.\nPrompt for a regexp with PROMPT.\nValue is a list, (REGEXP)." (list (read-regexp prompt) nil nil t)) "Flush lines containing match for regexp") * keep-lines-read-args("Flush lines containing match for regexp") (progn (barf-if-buffer-read-only) (keep-lines-read-args "Flush lines containing match for regexp")) call-interactively(flush-lines record-it) icicle-execute-extended-command-1("flush-lines") ... funcall(...) icicle-execute-extended-command() call-interactively(icicle-execute-extended-command nil nil) command-execute(icicle-execute-extended-command) In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2013-05-10 on ODIEONE Bzr revision: 112542 rgm@gnu.org-20130510102119-fklj7xlajezey0tr Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib' From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 19:22:28 2013 Received: (at 14390) by debbugs.gnu.org; 11 May 2013 23:22:28 +0000 Received: from localhost ([127.0.0.1]:36953 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbJ7U-0000jX-95 for submit@debbugs.gnu.org; Sat, 11 May 2013 19:22:28 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:49322 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbJ7R-0000jP-NN for 14390@debbugs.gnu.org; Sat, 11 May 2013 19:22:26 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id E9832258B9E93C; Sat, 11 May 2013 16:22:05 -0700 (PDT) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#14390: 24.3.50; (wrong-type-argument stringp t) from `read-regexp' Organization: JURTA References: <5C8F1D9AC91F44D8B2802A79E962581C@us.oracle.com> Date: Sun, 12 May 2013 02:17:05 +0300 In-Reply-To: <5C8F1D9AC91F44D8B2802A79E962581C@us.oracle.com> (Drew Adams's message of "Sat, 11 May 2013 14:54:12 -0700") Message-ID: <874ne9qf7y.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 14390 Cc: 14390@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > The problem is (find-tag-default-as-regexp), which will return `t' when > TAG is nil. `t' is not a valid suggestion: SUGGESTIONS must be a list > of strings. An empty string return value for the case when TAG is nil was lost when copying this code from `read-regexp' to `find-tag-default-as-regexp' in revno:111971. It could be restored back with: === modified file 'lisp/subr.el' --- lisp/subr.el 2013-04-27 23:07:46 +0000 +++ lisp/subr.el 2013-05-11 23:16:36 +0000 @@ -2715,7 +2715,7 @@ (defun find-tag-default-as-regexp () (get major-mode 'find-tag-default-function) 'find-tag-default)) (tag (funcall tagf))) - (cond ((not tag)) + (cond ((not tag) "") ((eq tagf 'find-tag-default) (format "\\_<%s\\_>" (regexp-quote tag))) (t (regexp-quote tag))))) BTW, the same commit revno:111971 introduced the function `hi-lock-read-regexp-defaults'. I think this is a good thing, and I propose to improve it by adding `read-regexp-defaults-or-tag' and `read-regexp-defaults-or-history' as we were discussing a month ago. From debbugs-submit-bounces@debbugs.gnu.org Tue May 14 19:43:13 2013 Received: (at 14390-done) by debbugs.gnu.org; 14 May 2013 23:43:13 +0000 Received: from localhost ([127.0.0.1]:44806 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcOsC-00010b-Ja for submit@debbugs.gnu.org; Tue, 14 May 2013 19:43:13 -0400 Received: from ps18281.dreamhost.com ([69.163.218.105]:47756 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UcOsA-00010K-PM for 14390-done@debbugs.gnu.org; Tue, 14 May 2013 19:43:11 -0400 Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id ECC03258B9E91C; Tue, 14 May 2013 16:43:06 -0700 (PDT) From: Juri Linkov To: "Drew Adams" Subject: Re: bug#14390: 24.3.50; (wrong-type-argument stringp t) from `read-regexp' Organization: JURTA References: <5C8F1D9AC91F44D8B2802A79E962581C@us.oracle.com> <874ne9qf7y.fsf@mail.jurta.org> Date: Wed, 15 May 2013 02:40:50 +0300 In-Reply-To: <874ne9qf7y.fsf@mail.jurta.org> (Juri Linkov's message of "Sun, 12 May 2013 02:17:05 +0300") Message-ID: <87k3n1yvst.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14390-done Cc: 14390-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > === modified file 'lisp/subr.el' > --- lisp/subr.el 2013-04-27 23:07:46 +0000 > +++ lisp/subr.el 2013-05-11 23:16:36 +0000 > @@ -2715,7 +2715,7 @@ (defun find-tag-default-as-regexp () > (get major-mode 'find-tag-default-function) > 'find-tag-default)) > (tag (funcall tagf))) > - (cond ((not tag)) > + (cond ((not tag) "") After looking more at this, I think it should return nil because its accompanying function `find-tag-default' returns nil, not an empty string, if there is no default tag at point. This is fixed now. > BTW, the same commit revno:111971 introduced the function > `hi-lock-read-regexp-defaults'. I think this is a good thing, > and I propose to improve it by adding `read-regexp-defaults-tag' > and `read-regexp-defaults-history' as we were discussing a month ago. I'll create a separate request for this. From unknown Tue Jun 24 10:30:01 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 12 Jun 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator