Subject: Re: bug#14390: 24.3.50; (wrong-type-argument stringp t) from `read-regexp'

From: Juri Linkov <[email-masked]>
Date: Wed, 15 May 2013 02:40:50 +0300

> === modified file 'lisp/subr.el'
> --- lisp/subr.el	2013-04-27 23:07:46 +0000
> +++ lisp/subr.el	2013-05-11 23:16:36 +0000
> @@ -2715,7 +2715,7 @@ (defun find-tag-default-as-regexp ()
>  		   (get major-mode 'find-tag-default-function)
>  		   'find-tag-default))
>  	 (tag (funcall tagf)))
> -    (cond ((not tag))
> +    (cond ((not tag) "")

After looking more at this, I think it should return nil
because its accompanying function `find-tag-default' returns nil,
not an empty string, if there is no default tag at point.

This is fixed now.

> BTW, the same commit revno:111971 introduced the function
> `hi-lock-read-regexp-defaults'.  I think this is a good thing,
> and I propose to improve it by adding `read-regexp-defaults-tag'
> and `read-regexp-defaults-history' as we were discussing a month ago.

I'll create a separate request for this.