From debbugs-submit-bounces@debbugs.gnu.org Thu May 09 16:32:34 2013 Received: (at submit) by debbugs.gnu.org; 9 May 2013 20:32:34 +0000 Received: from localhost ([127.0.0.1]:35049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaXVy-0001LR-0X for submit@debbugs.gnu.org; Thu, 09 May 2013 16:32:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41002) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaXVu-0001LH-U0 for submit@debbugs.gnu.org; Thu, 09 May 2013 16:32:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaXVk-0001uA-JS for submit@debbugs.gnu.org; Thu, 09 May 2013 16:32:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.1 required=5.0 tests=BAYES_50,RCVD_IN_DNSWL_LOW autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42796) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaXMQ-00073J-DZ for submit@debbugs.gnu.org; Thu, 09 May 2013 16:22:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48891) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaXMH-0001sx-0r for bug-gnu-emacs@gnu.org; Thu, 09 May 2013 16:22:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaXMC-0006yF-PB for bug-gnu-emacs@gnu.org; Thu, 09 May 2013 16:22:32 -0400 Received: from wp093.webpack.hosteurope.de ([80.237.132.100]:50026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaXMC-0006xa-IZ for bug-gnu-emacs@gnu.org; Thu, 09 May 2013 16:22:28 -0400 Received: from f049179120.adsl.alicedsl.de ([78.49.179.120] helo=nirvana); authenticated by wp093.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) id 1UaXM9-0006r1-Pm; Thu, 09 May 2013 22:22:25 +0200 Received: from ew by nirvana with local (Exim 4.72) (envelope-from ) id 1UaXM4-00013T-Hf for bug-gnu-emacs@gnu.org; Thu, 09 May 2013 22:22:20 +0200 From: Eduard Wiebe To: bug-gnu-emacs@gnu.org Subject: 24.3.50; patch: run a hook after `bookmark-write' Date: Thu, 09 May 2013 22:22:20 +0200 Message-ID: <87fvxv6gzn.fsf@pusto.de> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-bounce-key: webpack.hosteurope.de;ew@pusto.de;1368130948;e487c399; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain Hello, i want always to export my bookmarks when bookmark file is saved. Consider this simple patch. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=bookmark.after.save.hook.patch diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 482cdf9..ee561db 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -1311,6 +1311,9 @@ Don't use this in Lisp programs; use `bookmark-save' instead." (bookmark-save t)) +(defvar bookmark-after-save-hook nil + "Hook run after bookmark file was saved.") + ;;;###autoload (defun bookmark-save (&optional parg file) "Save currently defined bookmarks. @@ -1380,5 +1383,6 @@ for a file, defaulting to the file defined by variable (write-region (point-min) (point-max) file) (file-error (message "Can't write %s" file))) (kill-buffer (current-buffer)) + (run-hooks 'bookmark-after-save-hook) (bookmark-maybe-message "Saving bookmarks to file %s...done" file))))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 17:09:50 2013 Received: (at 14377) by debbugs.gnu.org; 10 May 2013 21:09:50 +0000 Received: from localhost ([127.0.0.1]:35965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UauZa-0000Wv-Ht for submit@debbugs.gnu.org; Fri, 10 May 2013 17:09:50 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:34097) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UauZY-0000Wl-Ee for 14377@debbugs.gnu.org; Fri, 10 May 2013 17:09:49 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r4AL9YVQ016280; Fri, 10 May 2013 17:09:35 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id B7F0CB4161; Fri, 10 May 2013 17:09:34 -0400 (EDT) From: Stefan Monnier To: Eduard Wiebe Subject: Re: bug#14377: 24.3.50; patch: run a hook after `bookmark-write' Message-ID: References: <87fvxv6gzn.fsf@pusto.de> Date: Fri, 10 May 2013 17:09:34 -0400 In-Reply-To: <87fvxv6gzn.fsf@pusto.de> (Eduard Wiebe's message of "Thu, 09 May 2013 22:22:20 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4575=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4575> : streams <958184> : uri <1416883> X-Spam-Score: -3.5 (---) X-Debbugs-Envelope-To: 14377 Cc: 14377@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) > I want always to export my bookmarks when bookmark file is saved. > Consider this simple patch. You could use (defadvice bookmark-write-file (after export activate) (do what I want)) Of course, we could also install something like your patch, but the hook functions will probably need access to the file name (which might turn into a lexically scoped var any time). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 15:30:52 2013 Received: (at 14377) by debbugs.gnu.org; 11 May 2013 19:30:52 +0000 Received: from localhost ([127.0.0.1]:36829 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbFVM-0007jU-4e for submit@debbugs.gnu.org; Sat, 11 May 2013 15:30:52 -0400 Received: from wp093.webpack.hosteurope.de ([80.237.132.100]:42256) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbFVJ-0007jE-Ta for 14377@debbugs.gnu.org; Sat, 11 May 2013 15:30:51 -0400 Received: from f049015211.adsl.alicedsl.de ([78.49.15.211] helo=nirvana); authenticated by wp093.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) id 1UbFV1-0003l8-17; Sat, 11 May 2013 21:30:31 +0200 Received: from ew by nirvana with local (Exim 4.72) (envelope-from ) id 1UbFUv-0000kd-Mw; Sat, 11 May 2013 21:30:25 +0200 From: Eduard Wiebe To: Stefan Monnier Subject: Re: bug#14377: 24.3.50; patch: run a hook after `bookmark-write' References: <87fvxv6gzn.fsf@pusto.de> Date: Sat, 11 May 2013 21:30:24 +0200 Message-ID: <8761yp2u27.fsf@pusto.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-bounce-key: webpack.hosteurope.de;ew@pusto.de;1368300632;fa45c249; X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14377 Cc: Eduard Wiebe , 14377@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Stefan Monnier writes: >> I want always to export my bookmarks when bookmark file is saved. >> Consider this simple patch. > > You could use > > (defadvice bookmark-write-file (after export activate) > (do what I want)) Sure. > Of course, we could also install something like your patch, but the hook > functions will probably need access to the file name (which might turn into > a lexically scoped var any time). Ahh.., that was not clear to me. Thanks for the hint. Please close this report. -- Eduard Wiebe From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 21:36:37 2013 Received: (at control) by debbugs.gnu.org; 12 May 2013 01:36:37 +0000 Received: from localhost ([127.0.0.1]:36987 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbLDI-0000L1-Qr for submit@debbugs.gnu.org; Sat, 11 May 2013 21:36:37 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:34168) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbLDH-0000Kt-3D for control@debbugs.gnu.org; Sat, 11 May 2013 21:36:35 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UbLCy-0004eb-Ak for control@debbugs.gnu.org; Sat, 11 May 2013 21:36:16 -0400 Date: Sat, 11 May 2013 21:36:16 -0400 Message-Id: Subject: control message for bug 14377 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.5 (------) close 14377 From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 21:42:52 2013 Received: (at 14377) by debbugs.gnu.org; 12 May 2013 01:42:52 +0000 Received: from localhost ([127.0.0.1]:36992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbLJL-0000im-TX for submit@debbugs.gnu.org; Sat, 11 May 2013 21:42:52 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:34234) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbLJK-0000iZ-24 for 14377@debbugs.gnu.org; Sat, 11 May 2013 21:42:51 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UbLJ0-0005fn-8Z; Sat, 11 May 2013 21:42:30 -0400 From: Glenn Morris To: 14377@debbugs.gnu.org Subject: Re: bug#14377: 24.3.50; patch: run a hook after `bookmark-write' References: <87fvxv6gzn.fsf@pusto.de> <8761yp2u27.fsf@pusto.de> X-Spook: Bruxelles NATO USDOJ UNSCOM CipherTAC-2000 weapons of X-Ran: xTUP@.aH*Vf[6'~*X>H!O0E$D-^>(n"~Vg,gulPjJ!`|bne?- (Eduard Wiebe's message of "Sat, 11 May 2013 21:30:24 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.5 (------) X-Debbugs-Envelope-To: 14377 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -8.4 (--------) >> Of course, we could also install something like your patch, but the hook >> functions will probably need access to the file name (which might turn into >> a lexically scoped var any time). Aren't matters of extensibility like this one reason why http://www.gnu.org/software/emacs/emacs-paper.html#SEC15 favours dynamic binding? From debbugs-submit-bounces@debbugs.gnu.org Sun May 12 14:02:18 2013 Received: (at 14377) by debbugs.gnu.org; 12 May 2013 18:02:18 +0000 Received: from localhost ([127.0.0.1]:37724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UbabB-0003ry-B7 for submit@debbugs.gnu.org; Sun, 12 May 2013 14:02:17 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:46731) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ubab8-0003rn-2q for 14377@debbugs.gnu.org; Sun, 12 May 2013 14:02:15 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r4CI1liO003247 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 12 May 2013 18:01:49 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4CI1kEZ004545 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sun, 12 May 2013 18:01:47 GMT Received: from abhmt116.oracle.com (abhmt116.oracle.com [141.146.116.68]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r4CI1kX6016361; Sun, 12 May 2013 18:01:46 GMT Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 12 May 2013 11:01:45 -0700 From: "Drew Adams" To: "'Glenn Morris'" , <14377@debbugs.gnu.org> References: <87fvxv6gzn.fsf@pusto.de> <8761yp2u27.fsf@pusto.de> Subject: RE: bug#14377: 24.3.50; patch: run a hook after `bookmark-write' Date: Sun, 12 May 2013 11:01:37 -0700 Message-ID: <7D9C75296A034D36A2C5824FD728A65C@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: thread-index: Ac5OsgJLEbCv2+ntTzmQu3oJtbOAEgAguDcQ X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 14377 Cc: 'Eduard Wiebe' X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) > >> Of course, we could also install something like your > >> patch, but the hook functions will probably need access > >> to the file name (which might turn into a lexically > >> scoped var any time). > > Aren't matters of extensibility like this one reason why > http://www.gnu.org/software/emacs/emacs-paper.html#SEC15 > favours dynamic binding? ;-) FWIW, Bookmark+ has such a hook: `bmkp-write-bookmark-file-hook'. (And it passes the file name to the hook functions.) From unknown Sun Jun 22 11:37:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Jun 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator