From debbugs-submit-bounces@debbugs.gnu.org Sun May 05 11:18:45 2013 Received: (at submit) by debbugs.gnu.org; 5 May 2013 15:18:45 +0000 Received: from localhost ([127.0.0.1]:58958 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UZ0i4-0001VC-6l for submit@debbugs.gnu.org; Sun, 05 May 2013 11:18:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49330) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UZ0i0-0001Uy-Jc for submit@debbugs.gnu.org; Sun, 05 May 2013 11:18:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZ0hA-0004C6-3w for submit@debbugs.gnu.org; Sun, 05 May 2013 11:17:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-100.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:33854) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZ0hA-0004C2-1i for submit@debbugs.gnu.org; Sun, 05 May 2013 11:17:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZ0h9-000527-4w for bug-gnu-emacs@gnu.org; Sun, 05 May 2013 11:17:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZ0h5-0004AE-TI for bug-gnu-emacs@gnu.org; Sun, 05 May 2013 11:17:47 -0400 Received: from mail-pd0-f180.google.com ([209.85.192.180]:41370) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZ0h5-00049q-MK for bug-gnu-emacs@gnu.org; Sun, 05 May 2013 11:17:43 -0400 Received: by mail-pd0-f180.google.com with SMTP id t10so1618816pdi.11 for ; Sun, 05 May 2013 08:17:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=mGpx2X8CW3pq5aPiJDO7oM8rT3mbrvzML4yFUd2f+QI=; b=W9Gkc2eOXA8rBpq9D0JPxRTRw5/vXbugtVNPrhOh+zbX9Z/tWHJdrlRx/TTUwvHmgH aBC8NrGzdSa++c/oyeL0aY3hg7eXqchLJg4ovIhv3yATt1k9QzlYyAaEuUbTG2CDMZXz 3bGcsxjvJx3ovL73+Mpr6W/PRaqKQ1XnRbwxaSA/00EE4exdaSqCbYUWC42tLVNIMdGQ uBsoFOmu5VpqgdRplJnGJerYi9PJ7aKZkXt5NMjiEpX+2p1FSXoGcOQICqkHcDeCsI1A u/o0v9Qx8omqmpupnm+X5nKDKnA6ZiavicSWk+wiuxJzTJQlRc6R1SnK1MaKzzHKc7J1 aRcQ== X-Received: by 10.68.189.67 with SMTP id gg3mr22159000pbc.141.1367767062982; Sun, 05 May 2013 08:17:42 -0700 (PDT) Received: from Zeuss-MacBook.local (li511-224.members.linode.com. [66.175.216.224]) by mx.google.com with ESMTPSA id iy2sm20007138pbb.31.2013.05.05.08.17.41 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 05 May 2013 08:17:42 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.3; octave mode comment indentation X-Debbugs-CC: Stefan Monnier Date: Sun, 05 May 2013 23:17:36 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hello Stefan, Some user from the Octave community has noticed the following change: x = 12; # abc abc abc abc abc abc abc abc abc # abc abc abc If you TAB in the second comment line, that line will be moved to column 0. I tested the example in emacs 22.1 and the second comment is supposed to be aligned to a certain column (similar to ; and ;; in lisp-mode). Will you be able to bend smie to do this? Thanks. Leo From debbugs-submit-bounces@debbugs.gnu.org Thu May 09 21:30:05 2013 Received: (at 14350) by debbugs.gnu.org; 10 May 2013 01:30:05 +0000 Received: from localhost ([127.0.0.1]:35168 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uac9s-0004vn-JI for submit@debbugs.gnu.org; Thu, 09 May 2013 21:30:04 -0400 Received: from mail-pb0-f54.google.com ([209.85.160.54]:53492) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uac9r-0004vf-Fj for 14350@debbugs.gnu.org; Thu, 09 May 2013 21:30:04 -0400 Received: by mail-pb0-f54.google.com with SMTP id rr4so2387673pbb.13 for <14350@debbugs.gnu.org>; Thu, 09 May 2013 18:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=RAoM5LHgYcQHKQ4EXqOgTt9C5EHgtoTL94AKUgRWK18=; b=NhOcNA7Etuslhmw98kJjzpfrutNfRC5iLoqlRx6S4FcNXAZb31bi0Nnkw8cz7+jKWc GQsDOXN0nWl4TYi1n7UxaQDpAx48EPPanAAhgwmaQkqOkFCle+PKcKXgtheoHFgXeCrk 9OY8MW616D/wFSJ8jYHWLKjH8+G2DzwHjebKYaAFjlWqO6nLIvP7GJB9E8MR/rpekyy2 OeknrYYNPNvditBN8T8uhFdpGT7XkdC/hugmulgT+NlKk964zolSZ4++EtC1FB7qqYG2 tVIlQjrIFWM2Q5u3qgelBAG59hvRdeT45Zy+6L4Fdj/WXKjVky44pzEPL9i/eylh1GDc 74BA== X-Received: by 10.68.52.39 with SMTP id q7mr15111278pbo.92.1368149395156; Thu, 09 May 2013 18:29:55 -0700 (PDT) Received: from Zeuss-MacBook.local (li511-224.members.linode.com. [66.175.216.224]) by mx.google.com with ESMTPSA id gi2sm496996pbb.2.2013.05.09.18.29.51 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 09 May 2013 18:29:54 -0700 (PDT) From: Leo Liu To: 14350@debbugs.gnu.org Subject: Re: bug#14350: 24.3; octave mode comment indentation References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= Date: Fri, 10 May 2013 09:29:47 +0800 In-Reply-To: (Leo Liu's message of "Sun, 05 May 2013 23:17:36 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14350 Cc: Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2013-05-05 23:17 +0800, Leo Liu wrote: > x = 12; # abc abc abc abc abc abc abc abc abc > # abc abc abc matlab.el also does the comment alignment well. Stefan, do you think this is possible to do with smie? Leo From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 15:58:04 2013 Received: (at 14350) by debbugs.gnu.org; 10 May 2013 19:58:04 +0000 Received: from localhost ([127.0.0.1]:35906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UatS7-00060z-7v for submit@debbugs.gnu.org; Fri, 10 May 2013 15:58:04 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:60107) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UatS4-00060U-7D for 14350@debbugs.gnu.org; Fri, 10 May 2013 15:58:01 -0400 Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r4AJvleT021843; Fri, 10 May 2013 15:57:47 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 9B04CB4161; Fri, 10 May 2013 15:57:47 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#14350: 24.3; octave mode comment indentation Message-ID: References: Date: Fri, 10 May 2013 15:57:47 -0400 In-Reply-To: (Leo Liu's message of "Fri, 10 May 2013 09:29:47 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4575=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4575> : streams <958156> : uri <1416835> X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: 14350 Cc: 14350@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) >> x = 12; # abc abc abc abc abc abc abc abc abc >> # abc abc abc > matlab.el also does the comment alignment well. Stefan, do you think > this is possible to do with smie? Of course. In the very worst case you can change (buffer-locally) smie-indent-functions to add any ad-hoc rule. But maybe this can be fixed globally in smie-indent-comment. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 22:05:23 2013 Received: (at 14350) by debbugs.gnu.org; 11 May 2013 02:05:24 +0000 Received: from localhost ([127.0.0.1]:36050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UazBb-00062o-Ou for submit@debbugs.gnu.org; Fri, 10 May 2013 22:05:23 -0400 Received: from mail-pb0-f47.google.com ([209.85.160.47]:55871) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UazBY-00062U-Tn for 14350@debbugs.gnu.org; Fri, 10 May 2013 22:05:22 -0400 Received: by mail-pb0-f47.google.com with SMTP id uo1so3160978pbc.34 for <14350@debbugs.gnu.org>; Fri, 10 May 2013 19:05:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=S+RztYcdf4aNwUzRCWcp067DKsOGQbMd1fVDafOPjMs=; b=JUG7v1kLXKvwX1HTmeO8BuU/sJHH1LZ3jg+cpIZiWjm2buVvNF1k0mulitgyblaoNu OXSwzygAyqyivu5KVeE9ct42FUNhLKYufiMBR4fPsfUIo+pp1GuaZUTa6m8zviK4UvEf ZQX4BLDAVKAq0GsIPaBBwuJZrk2SOhn4Y88kYS4sZod8a6kYcpdNFtlx/B5fkrqIe6gF u8NFvN9+WlEk3tcjph2EcYImik+k5Cnk00gGQuYCqcjkM2CP7SVTOquBbZZ45g6Hbqex KDyulN4k/rnVoLLTTQYDWA3Wi5+kuWcSpqddG0SnjLjQRgVwFKsE4NeSssShRexbNLga bxpg== X-Received: by 10.68.209.193 with SMTP id mo1mr19371806pbc.191.1368237906987; Fri, 10 May 2013 19:05:06 -0700 (PDT) Received: from Zeuss-MacBook.local (li511-224.members.linode.com. [66.175.216.224]) by mx.google.com with ESMTPSA id cc15sm4986995pac.1.2013.05.10.19.05.03 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 10 May 2013 19:05:06 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#14350: 24.3; octave mode comment indentation References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Sat, 11 May 2013 10:04:59 +0800 In-Reply-To: (Stefan Monnier's message of "Fri, 10 May 2013 15:57:47 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14350 Cc: 14350@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2013-05-11 03:57 +0800, Stefan Monnier wrote: > Of course. In the very worst case you can change (buffer-locally) > smie-indent-functions to add any ad-hoc rule. > But maybe this can be fixed globally in smie-indent-comment. Thanks for the comment (did I just use a pun?). Unfortunately I have little knowledge of smie so I have to rely on others to get this to behave. Thanks in advance. Leo From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 23:35:33 2013 Received: (at 14350) by debbugs.gnu.org; 11 May 2013 03:35:33 +0000 Received: from localhost ([127.0.0.1]:36081 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ub0ap-0004l4-UF for submit@debbugs.gnu.org; Fri, 10 May 2013 23:35:32 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:12459) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ub0an-0004kd-HM for 14350@debbugs.gnu.org; Fri, 10 May 2013 23:35:29 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFG4rwb8/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IPAS-Result: Av4EABK/CFG4rwb8/2dsb2JhbABEvw4Xc4IeAQEEAVYjEAsOJhIUGA0kiB4GwS2RCgOkeoFegxM X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="11783589" Received: from 184-175-6-252.dsl.teksavvy.com (HELO pastel.home) ([184.175.6.252]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 May 2013 23:35:10 -0400 Received: by pastel.home (Postfix, from userid 20848) id 995EA67A3A; Fri, 10 May 2013 23:35:14 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#14350: 24.3; octave mode comment indentation Message-ID: References: Date: Fri, 10 May 2013 23:35:14 -0400 In-Reply-To: (Leo Liu's message of "Sat, 11 May 2013 10:04:59 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14350 Cc: 14350@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) >> Of course. In the very worst case you can change (buffer-locally) >> smie-indent-functions to add any ad-hoc rule. >> But maybe this can be fixed globally in smie-indent-comment. > Thanks for the comment (did I just use a pun?). > Unfortunately I have little knowledge of smie so I have to rely on > others to get this to behave. Thanks in advance. No, no, you don't. smie-indent-functions is just a hook that runs functions that come up with some indentation choice. It basically sits between line-indent-function and smie proper. You can add your own function which will not itself need to use anything from smie. Look at its docstring. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat May 11 01:14:51 2013 Received: (at 14350) by debbugs.gnu.org; 11 May 2013 05:14:51 +0000 Received: from localhost ([127.0.0.1]:36117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ub28x-000360-GA for submit@debbugs.gnu.org; Sat, 11 May 2013 01:14:51 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:48815) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ub28u-00035j-Mf for 14350@debbugs.gnu.org; Sat, 11 May 2013 01:14:49 -0400 Received: by mail-pd0-f173.google.com with SMTP id v10so3217059pde.18 for <14350@debbugs.gnu.org>; Fri, 10 May 2013 22:14:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=X53Xb7VQo/pRGhRuNJaZaIp7xI0kBC1AMilBWHRKQog=; b=K3UK6JH5fM1Nez0t8MmhXlp2iKF7iCevoc7848QZjJD3fdRQ/DR6OZllUkUFr8vrAV wCNEk91nTwANOAClE261h/xqnce2E9KKSxINqvlICE7m6V2UFNYBgcJPO7n8olWoKAdm 5W3ZdRAaCb7iA1m6rvdLT2T0ZDo4hx7F9pSemlkeqYI1YcovHl09z9uMki1Yv3GTEb4M jyDdN89X7ZvmVf06pZX5jhAZ0jzslUy4pByXfjDtGfzS3qb2AxQPvd8T5Dh+KyFJDbLa Sy1aaHshdnBUDWjrBz2MZ7AcT2jGwPLysB9Ndb7mOXrtrb4ynrpTpZwsjqnePBmM20dE 2PUw== X-Received: by 10.68.129.100 with SMTP id nv4mr19304886pbb.178.1368249274214; Fri, 10 May 2013 22:14:34 -0700 (PDT) Received: from Zeuss-MacBook.local (li511-224.members.linode.com. [66.175.216.224]) by mx.google.com with ESMTPSA id 10sm5129671pbr.45.2013.05.10.22.14.31 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 10 May 2013 22:14:33 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#14350: 24.3; octave mode comment indentation References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= Date: Sat, 11 May 2013 13:14:24 +0800 In-Reply-To: (Stefan Monnier's message of "Fri, 10 May 2013 23:35:14 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 14350 Cc: 14350@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 2013-05-11 11:35 +0800, Stefan Monnier wrote: > No, no, you don't. smie-indent-functions is just a hook that runs > functions that come up with some indentation choice. It basically sits > between line-indent-function and smie proper. You can add your own > function which will not itself need to use anything from smie. > Look at its docstring. I intend to fix the bug with this patch. Comments? diff --git a/lisp/progmodes/octave.el b/lisp/progmodes/octave.el index 780bb2f5..5d8186f5 100644 --- a/lisp/progmodes/octave.el +++ b/lisp/progmodes/octave.el @@ -414,6 +414,13 @@ (defun octave-smie-rules (kind token) ;; (if (smie-parent-p "switch") 4) 0)))) +(defun octave-indent-comment () + "A function for `smie-indent-functions'." + (save-excursion + (back-to-indentation) + (when (and (looking-at-p "\\s<") (not (looking-at-p "\\s<\\s<"))) + (comment-choose-indent)))) + (defvar octave-font-lock-keywords (list @@ -488,6 +495,7 @@ (define-derived-mode octave-mode prog-mode "Octave" :forward-token #'octave-smie-forward-token :backward-token #'octave-smie-backward-token) (setq-local smie-indent-basic 'octave-block-offset) + (add-hook 'smie-indent-functions #'octave-indent-comment nil t) (setq-local smie-blink-matching-triggers (cons ?\; smie-blink-matching-triggers)) From debbugs-submit-bounces@debbugs.gnu.org Mon May 13 07:16:06 2013 Received: (at 14350-done) by debbugs.gnu.org; 13 May 2013 11:16:06 +0000 Received: from localhost ([127.0.0.1]:38254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ubqjd-00039o-Fr for submit@debbugs.gnu.org; Mon, 13 May 2013 07:16:06 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:48577) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ubqjb-00039Y-0m for 14350-done@debbugs.gnu.org; Mon, 13 May 2013 07:16:04 -0400 Received: by mail-pd0-f172.google.com with SMTP id 6so4332048pdd.3 for <14350-done@debbugs.gnu.org>; Mon, 13 May 2013 04:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=CIMznDFkaRhbkBs7b3WlzyozusX3QJv7I6Eowbglq34=; b=MmWYBdew5kJPjdIZ9oPhKjekm12K7ZXhRRXh50tQDDKKhMMwURO/DEx6ZEj07/d1+P oZ6yXgwzmFkS5YGEj/1P4UsXruihmM8wLdvPk1o3lPGTezXd0qZzx7fNvX2uLTIaauMm 6aLrLxR7Yn9oYanBYFj75ML6GjmYY0uVMGe0AnCpWafRwU2bz7DKNL531VVfOMAdccra 5+drwbkC0JrLp2lNT2zDAPEotysQHaOI68buOF8AdOEDANa2bUYJazQgg0377b+rpNX+ rYLPhGTBaK9AXbhcsqoas7BdSoj7T95Tr1bGt1jfSHbqhEMgeH/moh73+Yj9igwgcO1p IS+w== X-Received: by 10.68.135.231 with SMTP id pv7mr28407294pbb.108.1368443735305; Mon, 13 May 2013 04:15:35 -0700 (PDT) Received: from Zeuss-MacBook.local (li511-224.members.linode.com. [66.175.216.224]) by mx.google.com with ESMTPSA id fp2sm13665946pbb.36.2013.05.13.04.15.33 for <14350-done@debbugs.gnu.org> (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 13 May 2013 04:15:34 -0700 (PDT) From: Leo Liu To: 14350-done@debbugs.gnu.org Subject: Re: bug#14350: 24.3; octave mode comment indentation References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUzRVhbQj4eZqO6SjnT eWpxnMetm5b6/PmidmqrAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1F B9cBBwMLBfKABCMAAAFoSURBVCjPtZI9a8MwEIaFoc7aYDdelQMna0Em3tsSr0XUeE2Q6a22a+v+ fk8fSSBkbDUI6dHpfe9OEvRgiD+ApqKPJgJeB6iUUXWESjUe/ig38AJrhqqvaU2nTIXbNvOQ40fe qdry4kyGoVWsfCQalXpHnJGM01wjWdYbMlXNFdsZDO69m9aqNqxEJqTEgbM5OF7wlEfIoll1Ked4 LbM5X2EdILLokEdmI8z7g5cKED0cuTC930TYhy7ZDekkXVGw/L60TguJePPxcJF48lpsSUWEA/Ju jGFNgJOXc4Hz7TmAdBeu5Ve4AEjOi2/2jfd3cAJZ+IbNrvdjgBZY01b+HTuG3cLws6BJZqVOj/pp T0OqVwx3rFq+QmJwx3loK5JSLEhDIt62+mtC2C+SrAUxEbV6C6v2BRbd6pILBKFpepKZJHgGgrKF sptSUUoczpwg2pQ7ZH1tgs0ou/917mzz6Cs2//C978cv5l07L02orIEAAAAASUVORK5CYII= Date: Mon, 13 May 2013 19:15:29 +0800 In-Reply-To: (Leo Liu's message of "Sat, 11 May 2013 13:14:24 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 14350-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Fixed in trunk. From unknown Fri Sep 12 22:55:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Jun 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator