GNU bug report logs - #14345
24.3; shr-insert-document crashes gtk-emacs

Previous Next

Package: emacs;

Reported by: David Bremner <david <at> tethera.net>

Date: Sat, 4 May 2013 02:54:04 UTC

Severity: important

Tags: confirmed

Found in version 24.3

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Glenn Morris <rgm <at> gnu.org>
To: David Bremner <david <at> tethera.net>
Cc: 14345 <at> debbugs.gnu.org
Subject: bug#14345: 24.3; shr-insert-document crashes gtk-emacs
Date: Tue, 07 May 2013 21:38:28 -0400

Glenn Morris wrote:

> Whoops.

I meant to say:

*** src/image.c	2013-04-07 04:41:19 +0000
--- src/image.c	2013-05-08 01:35:41 +0000
***************
*** 7273,7292 ****
    /* Clear the part of the screen image not covered by the image.
       Full animated GIF support requires more here (see the gif89 spec,
       disposal methods).  Let's simply assume that the part not covered
!      by a sub-image is in the frame's background color.  */
!   for (y = 0; y < img->corners[TOP_CORNER]; ++y)
      for (x = 0; x < width; ++x)
        XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
  
!   for (y = img->corners[BOT_CORNER]; y < height; ++y)
      for (x = 0; x < width; ++x)
        XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
  
!   for (y = img->corners[TOP_CORNER]; y < img->corners[BOT_CORNER]; ++y)
      {
!       for (x = 0; x < img->corners[LEFT_CORNER]; ++x)
  	XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
!       for (x = img->corners[RIGHT_CORNER]; x < width; ++x)
  	XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
      }
  
--- 7273,7297 ----
    /* Clear the part of the screen image not covered by the image.
       Full animated GIF support requires more here (see the gif89 spec,
       disposal methods).  Let's simply assume that the part not covered
!      by a sub-image is in the frame's background color.
! 
!      Note that the corner position can be outside the screen, so take
!      care not to go beyond the screen boundary (bug#14345).
!   */
!   for (y = 0; y < min (height, img->corners[TOP_CORNER]); ++y)
      for (x = 0; x < width; ++x)
        XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
  
!   for (y = max (0, img->corners[BOT_CORNER]); y < height; ++y)
      for (x = 0; x < width; ++x)
        XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
  
!   for (y = max (0, img->corners[TOP_CORNER]);
!        y < min (height, img->corners[BOT_CORNER]); ++y)
      {
!       for (x = 0; x < min (width, img->corners[LEFT_CORNER]); ++x)
  	XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
!       for (x = max (0, img->corners[RIGHT_CORNER]); x < width; ++x)
  	XPutPixel (ximg, x, y, FRAME_BACKGROUND_PIXEL (f));
      }
This bug report was last modified 12 years and 98 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.