GNU bug report logs - #14317
24.3.50; nadvice.el: named advices not upgradable

Previous Next

Package: emacs;

Reported by: michael_heerdegen <at> web.de

Date: Mon, 29 Apr 2013 23:43:02 UTC

Severity: normal

Found in version 24.3.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 14317 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: 14317 <at> debbugs.gnu.org
Subject: Re: bug#14317: 24.3.50; nadvice.el: named advices not upgradable
Date: Fri, 03 May 2013 03:20:42 +0200

Michael Heerdegen <michael_heerdegen <at> web.de> writes:

> but as a user, I would suspect something like
>
> (defun advice--add-function (where ref function props)
>   (when (advice--member-p function (cdr (assq 'name props))
>                           (gv-deref ref))
>     (advice--remove-function .........))
>   (setf (gv-deref ref)
>         (advice--make where function (gv-deref ref) props)))
>
> i.e., replacing the old code, instead of doing nothing.

We should probably distinguish between named functions and
named advice.  I mean, it's probably stupid to remove and add
back an fboundp symbol - but you get the idea...


Regards,

Michael.
This bug report was last modified 12 years and 19 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.