GNU bug report logs - #14317
24.3.50; nadvice.el: named advices not upgradable

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#14317: closed (24.3.50; nadvice.el: named advices not upgradable)
Date: Mon, 06 May 2013 15:29:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 06 May 2013 11:27:37 -0400
with message-id <jwv1u9kgmcm.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#14317: 24.3.50; nadvice.el: named advices not upgradable
has caused the debbugs.gnu.org bug report #14317,
regarding 24.3.50; nadvice.el: named advices not upgradable
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
14317: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14317
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; nadvice.el: named advices not upgradable
Date: Tue, 30 Apr 2013 01:42:14 +0200

Hi Stefan,

if you have some code adding advices that can be identified (i.e.,
adding named advices or fbound symbols, not anonymous functions),
and you change this code defining the advice and re-evaluate, the change
doesn't take effect (in contrast to the behavior of advice.el).

We currently use this:

--8<---------------cut here---------------start------------->8---
(defun advice--add-function (where ref function props)
  (unless (advice--member-p function (cdr (assq 'name props))
                            (gv-deref ref))
    (setf (gv-deref ref)
          (advice--make where function (gv-deref ref) props))))
--8<---------------cut here---------------end--------------->8---

but as a user, I would suspect something like

--8<---------------cut here---------------start------------->8---
(defun advice--add-function (where ref function props)
  (when (advice--member-p function (cdr (assq 'name props))
                          (gv-deref ref))
    (advice--remove-function .........))
  (setf (gv-deref ref)
        (advice--make where function (gv-deref ref) props)))
--8<---------------cut here---------------end--------------->8---

i.e., replacing the old code, instead of doing nothing.

Is the current behavior intended?  If not, can we change it?


Regards,

Michael.

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: 14317-done <at> debbugs.gnu.org
Subject: Re: bug#14317: 24.3.50; nadvice.el: named advices not upgradable
Date: Mon, 06 May 2013 11:27:37 -0400

> Is the current behavior intended?  If not, can we change it?

Changed, thanks,


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.