GNU bug report logs - #14305
23.4; doc string of `frame-visible-p'

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Mon, 29 Apr 2013 15:20:01 UTC

Severity: minor

Found in version 23.4

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 14305 <at> debbugs.gnu.org
Subject: bug#14305: 23.4; doc string of `frame-visible-p'
Date: Sat, 08 Feb 2014 03:03:19 -0800
"Drew Adams" <drew.adams <at> oracle.com> writes:

> This makes it sound like "iconified" is something different from
> "minimized":
>
>   Return the symbol `icon' if FRAME is iconified or "minimized".
>
> To imply that minimized means the same thing as iconified, you need a
> comma after "iconified" (or put "'minimized'" in parens):
>
>   Return the symbol `icon' if FRAME is iconified, or minimized.
>
>   Return the symbol `icon' if FRAME is iconified (minimized).

Well, are they the same thing?  

> The second is clearer, not requiring readers to notice the comma and
> recognize how it changes parsing of the sentence.
>
> And you can remove the quotes around "visible", "minimized", and
> "taskbar".

Even if a frame is obscured by other frames (and is therefore not
visible), I think this function will still say that it is "visible".  So
I think the sneer quotes are correct here.  Closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/




This bug report was last modified 11 years and 108 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.