GNU bug report logs - #14285
24.3; New octave feature: octave-update-function-file-comment

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Sat, 27 Apr 2013 08:16:01 UTC

Severity: wishlist

Found in version 24.3

Done: Leo Liu <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: John Eaton <jwe <at> octave.org>, Jordi Gutiérrez Hermoso <jordigh <at> octave.org>, 14285 <at> debbugs.gnu.org
Subject: bug#14285: 24.3; New octave feature: octave-update-function-file-comment
Date: Sat, 27 Apr 2013 09:19:30 -0400

[ FWIW, I use neither Octave nor Matlab and so I never use octave-mode.
  I just chose it as a kind of test for SMIE.  So I don't have any
  opinion on the feature you suggest.  ]

> -  "Normal hook that is run before a buffer is saved to its file."
> +  "Normal hook that is run before a buffer is saved to its file.
> +Any error from the hook prevents saving the buffer."

Maybe rather than fix the doc, we should fix the code and wrap the
run-hook with a with-demote-errors?

> +      (cl-destructuring-bind (&optional start _end name-start name-end)
> +          (octave-function-file-p)

I recommend you try

 (pcase-let ((`(,start ,_end ,name-start ,name-end) (octave-function-file-p)))

instead.


        Stefan
This bug report was last modified 12 years and 22 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.