From unknown Sat Aug 09 22:11:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14245: nobase_foo_DATA vs nobase_dist_foo_DATA Resent-From: Daiki Ueno Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-automake@gnu.org Resent-Date: Tue, 23 Apr 2013 06:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14245 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 14245@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.136669893515447 (code B ref -1); Tue, 23 Apr 2013 06:36:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Apr 2013 06:35:35 +0000 Received: from localhost ([127.0.0.1]:38152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UUWpC-000415-Of for submit@debbugs.gnu.org; Tue, 23 Apr 2013 02:35:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45847) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UUWp8-00040s-W3 for submit@debbugs.gnu.org; Tue, 23 Apr 2013 02:35:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUWkG-0003wJ-0Z for submit@debbugs.gnu.org; Tue, 23 Apr 2013 02:30:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:40438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUWkF-0003wF-Tn for submit@debbugs.gnu.org; Tue, 23 Apr 2013 02:30:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57172) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUWkC-0000xY-Ss for bug-automake@gnu.org; Tue, 23 Apr 2013 02:30:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUWk9-0003vf-Qh for bug-automake@gnu.org; Tue, 23 Apr 2013 02:30:24 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:41781) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUWk9-0003vb-ND for bug-automake@gnu.org; Tue, 23 Apr 2013 02:30:21 -0400 Received: from [2001:e41:db5e:fb14::1] (port=51028 helo=localhost.localdomain) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1UUWk8-0002RP-RN for bug-automake@gnu.org; Tue, 23 Apr 2013 02:30:21 -0400 Message-ID: From: Daiki Ueno Date: Tue, 23 Apr 2013 15:30:17 +0900 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) --=-=-= Content-Type: text/plain Hi, With Automake master and 1.12.2, if Makefile.am has: nobase_foo_DATA = sub/nodist.dat nobase_dist_foo_DATA = sub/dist.dat sub/dist.dat is not packed in the distribution. I doubt this is a bug, but the opposite use of dist_ and nobase_: dist_bar_DATA = sub/base.dat nobase_dist_bar_DATA = sub/nobase.dat works just fine. I'm attaching a test case. Regards, -- Daiki Ueno --=-=-= Content-Type: text/plain Content-Disposition: inline; filename=nobase-dist.sh #! /bin/sh # Copyright (C) 2001-2013 Free Software Foundation, Inc. # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation; either version 2, or (at your option) # any later version. # # This program is distributed in the hope that it will be useful, # but WITHOUT ANY WARRANTY; without even the implied warranty of # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the # GNU General Public License for more details. # # You should have received a copy of the GNU General Public License # along with this program. If not, see . # Make sure nobase_* works. required=cc . test-init.sh cat >> configure.ac <<'EOF' AC_OUTPUT EOF cat > Makefile.am << 'EOF' foodir = $(prefix)/foo bardir = $(prefix)/bar nobase_foo_DATA = sub/nodist.dat nobase_dist_foo_DATA = sub/dist.dat dist_bar_DATA = sub/base.dat nobase_dist_bar_DATA = sub/nobase.dat EOF mkdir sub : > sub/nodist.dat : > sub/dist.dat : > sub/nobase.dat : > sub/base.dat rm -f install-sh $ACLOCAL $AUTOCONF $AUTOMAKE -a --copy ./configure --prefix "$(pwd)/inst" $MAKE $MAKE install test -f inst/foo/sub/nodist.dat test -f inst/foo/sub/dist.dat test -f inst/bar/sub/nobase.dat test -f inst/bar/base.dat $MAKE distcheck : --=-=-=-- From unknown Sat Aug 09 22:11:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14245: nobase_foo_DATA vs nobase_dist_foo_DATA References: In-Reply-To: Resent-From: Mike Frysinger Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 19 Jan 2022 08:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14245 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Daiki Ueno Cc: 14245@debbugs.gnu.org Received: via spool by 14245-submit@debbugs.gnu.org id=B14245.164258103211530 (code B ref 14245); Wed, 19 Jan 2022 08:31:02 +0000 Received: (at 14245) by debbugs.gnu.org; 19 Jan 2022 08:30:32 +0000 Received: from localhost ([127.0.0.1]:52268 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA6MR-0002zu-RQ for submit@debbugs.gnu.org; Wed, 19 Jan 2022 03:30:32 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:56722 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA6MO-0002zb-KH for 14245@debbugs.gnu.org; Wed, 19 Jan 2022 03:30:30 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 753FC3431C3; Wed, 19 Jan 2022 08:30:22 +0000 (UTC) From: Mike Frysinger Message-Id: <20220119083022.753FC3431C3@smtp.gentoo.org> Date: Wed, 19 Jan 2022 08:30:22 +0000 (UTC) X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) close 14245 ! thankyou On Tue, 23 Apr 2013 15:30:17 +0900, Daiki Ueno wrote: > With Automake master and 1.12.2, if Makefile.am has: > > nobase_foo_DATA = sub/nodist.dat > nobase_dist_foo_DATA = sub/dist.dat > > sub/dist.dat is not packed in the distribution. I doubt this is a bug, > but the opposite use of dist_ and nobase_: > > dist_bar_DATA = sub/base.dat > nobase_dist_bar_DATA = sub/nobase.dat > > works just fine. > > I'm attaching a test case. thanks for the test case. it's slightly incomplete and fails because distcheck can't find sub/nodist.dat to install (which makes sense as it wasn't included in the tarball). but that was trivial to resolve with your test case, and i'm guessing it was failing sooner for you. which is my long winded way of saying i can't reproduce the bug with automake 1.16. i'm going to mark this done on the assumption something/someone fixed the bug. but i'll update your test and include it to make sure we keep working. specifically, looking at the tarball produced by `make dist`, i see: nobase-dist-1.0/sub/ nobase-dist-1.0/sub/nobase.dat nobase-dist-1.0/sub/base.dat nobase-dist-1.0/sub/dist.dat -mike From unknown Sat Aug 09 22:11:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14245: [PATCH] tests: add coverage for nobase_ and dist_ prefixes References: In-Reply-To: Resent-From: Mike Frysinger Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Wed, 19 Jan 2022 08:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14245 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 14245@debbugs.gnu.org Received: via spool by 14245-submit@debbugs.gnu.org id=B14245.164258124411911 (code B ref 14245); Wed, 19 Jan 2022 08:35:02 +0000 Received: (at 14245) by debbugs.gnu.org; 19 Jan 2022 08:34:04 +0000 Received: from localhost ([127.0.0.1]:52276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA6Pq-00035z-RE for submit@debbugs.gnu.org; Wed, 19 Jan 2022 03:34:04 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:57320 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nA6Pl-00035L-QD for 14245@debbugs.gnu.org; Wed, 19 Jan 2022 03:34:02 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 307F4343119; Wed, 19 Jan 2022 08:33:52 +0000 (UTC) From: Mike Frysinger Date: Wed, 19 Jan 2022 03:33:50 -0500 Message-Id: <20220119083350.12981-1-vapier@gentoo.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) >From automake bug https://bugs.gnu.org/14245. We have tests that check nobase_ and nodist_ interaction, but not nobase_ and dist_. We had a report against automake 1.12 that this combo did not work. It seems to work now, but lets include a test to make sure we don't regress. Based on Daiki Ueno's example, but fixed up to pass against master. * t/nobase-dist.sh: New test. --- t/nobase-dist.sh | 67 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 67 insertions(+) create mode 100644 t/nobase-dist.sh diff --git a/t/nobase-dist.sh b/t/nobase-dist.sh new file mode 100644 index 000000000000..b2ead50ee9da --- /dev/null +++ b/t/nobase-dist.sh @@ -0,0 +1,67 @@ +#! /bin/sh +# Copyright (C) 2011-2022 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2, or (at your option) +# any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Interaction of 'nobase_' and 'dist_' prefixes. + +. test-init.sh + +cat >> configure.ac <<'EOF' +AC_OUTPUT +EOF + +cat > Makefile.am <<'EOF' +foodir = $(prefix)/foo + +bardir = $(prefix)/bar + +sub/nodist.dat: + $(MKDIR_P) sub + : > $@ + +nobase_foo_DATA = sub/nodist.dat +nobase_dist_foo_DATA = sub/dist.dat + +dist_bar_DATA = sub/base.dat +nobase_dist_bar_DATA = sub/nobase.dat + +CLEANFILES = sub/nodist.dat +EOF + +mkdir sub + +: > sub/dist.dat +: > sub/nobase.dat +: > sub/base.dat + +rm -f install-sh + +$ACLOCAL +$AUTOCONF +$AUTOMAKE -a +./configure --prefix "$(pwd)/inst" + +$MAKE +$MAKE install + +test -f inst/foo/sub/nodist.dat +test -f inst/foo/sub/dist.dat + +test -f inst/bar/sub/nobase.dat +test -f inst/bar/base.dat + +$MAKE distcheck + +: -- 2.33.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 27 05:03:45 2022 Received: (at control) by debbugs.gnu.org; 27 Jan 2022 10:03:46 +0000 Received: from localhost ([127.0.0.1]:54417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nD1d3-0001D9-Ov for submit@debbugs.gnu.org; Thu, 27 Jan 2022 05:03:45 -0500 Received: from woodpecker.gentoo.org ([140.211.166.183]:40634 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nD1d2-0001Cv-3T for control@debbugs.gnu.org; Thu, 27 Jan 2022 05:03:44 -0500 Received: by smtp.gentoo.org (Postfix, from userid 559) id 37D5A3431C6; Thu, 27 Jan 2022 10:03:37 +0000 (UTC) From: Mike Frysinger To: control@debbugs.gnu.org Subject: Control message Message-Id: <20220127100338.37D5A3431C6@smtp.gentoo.org> Date: Thu, 27 Jan 2022 10:03:37 +0000 (UTC) X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) close 14245 thankyou