GNU bug report logs - #14237
[PATCH] Fix syntax-propertize-multiline bug

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#14237: closed ([PATCH] Fix syntax-propertize-multiline bug)
Date: Mon, 22 Apr 2013 14:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 22 Apr 2013 10:11:50 -0400
with message-id <jwv8v4a8xkz.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#14237: [PATCH] Fix syntax-propertize-multiline bug
has caused the debbugs.gnu.org bug report #14237,
regarding [PATCH] Fix syntax-propertize-multiline bug
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
14237: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14237
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Erik Charlebois <erikcharlebois <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix syntax-propertize-multiline bug
Date: Sun, 21 Apr 2013 02:38:00 -0400

[Message part 3 (text/plain, inline)]

Description

At least, I think it's a bug. I ran into this while adding support for
C++11 raw strings to cc-mode.

syntax-propertize-multiline seeks backward for the first position without a
'syntax-multiline text property, but searches forward for
'font-lock-multiline. For a span of text marked 'syntax-multiline, the new
end returned from syntax-propertize-multiline will not be the end of the
multiline text.


Changelog

2013-04-21  Erik Charlebois  <erikcharlebois <at> gmail.com>

* emacs-lisp/syntax.el (syntax-propertize-multiline):
Use 'syntax-multiline text property instead of 'font-lock-multiline.

[Message part 4 (text/html, inline)]

[syntax-multiline.txt (text/plain, attachment)]

[Message part 6 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Erik Charlebois <erikcharlebois <at> gmail.com>
Cc: 14237-done <at> debbugs.gnu.org
Subject: Re: bug#14237: [PATCH] Fix syntax-propertize-multiline bug
Date: Mon, 22 Apr 2013 10:11:50 -0400

> -  (when (get-text-property end 'font-lock-multiline)
> +  (when (get-text-property end 'syntax-multiline)

Duh!  Yes, thank you very much for catching this.
Installed in the `emacs-24' branch.  And sorry for the copy&paste error.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.