GNU bug report logs - #14233
24.3; Don't constrain frame size to character multiples

Previous Next

Full log

Message #152 received at 14233 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: jan.h.d <at> swipnet.se, esabof <at> gmail.com, 14233 <at> debbugs.gnu.org
Subject: Re: bug#14233: 24.3; Don't constrain frame size to character multiples
Date: Mon, 22 Apr 2013 21:21:29 +0300

> Date: Mon, 22 Apr 2013 18:38:51 +0200
> From: martin rudalics <rudalics <at> gmx.at>
> CC: Eli Zaretskii <eliz <at> gnu.org>, "esabof <at> gmail.com" <esabof <at> gmail.com>, 
>  "14233 <at> debbugs.gnu.org" <14233 <at> debbugs.gnu.org>
> 
> change_frame_size has no idea whether it is called for a text or a
> graphical frame.

That is done very easily, given the frame pointer (which
change_frame_size accepts as its 1st argument).  E.g.:

  if (FRAME_WINDOW_P (f))
    /* do the GUI thing */

> Text frames might want to call it as before using character sizes.

On text-mode frames, each character is one pixel.  Emacs knows that
already.

> In any case, the callers have to strip space used for tool- or
> menubars because change_frame_size does not know whether these are
> part of the frame or not.

Why can't change_frame_size know that?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.