GNU bug report logs - #14233
24.3; Don't constrain frame size to character multiples

Previous Next

Full log

View this message in rfc822 format

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Eli Zaretskii <eliz <at> gnu.org>, "esabof <at> gmail.com" <esabof <at> gmail.com>, "14233 <at> debbugs.gnu.org" <14233 <at> debbugs.gnu.org>
Subject: bug#14233: 24.3; Don't constrain frame size to character multiples
Date: Mon, 22 Apr 2013 18:11:12 +0200

Hello. 


22 apr 2013 kl. 17:36 skrev martin rudalics <rudalics <at> gmx.at>:

> >> The interface to the window subsystem will be the function
> >>
> >> change_frame_size (struct frame *f, int new_width, int new_height,
> >>           bool pretend, bool delay, bool safe, bool pixelwise)
> >>
> >> which processes new_width and new_height in terms of pixels if pixelwise
> >> is non-nil.
> 
> I meant 1 here.
> 
> > This is insane. it means changing lots and lots of calls, and makes merging between branches harder.
> 
> Currently, change_frame_size doesn't know anything about the various
> platforms' requirements going beyond those of the frame's text area.

I don't understand what you are trying to say. 

> > Make a new function (change_frame_size_pixelwise for example), with the arguments above, and let change_frame_size call it with the last argument false.
> 
> And how would change_frame_size know what the new pixel dimensions of
> the frame's text area are?

As Emacs has always done, multiply by canonical character pixel size. 

The point is that for X and NS there are probably just a few places where pixel size is needed.  Better to have a new name anyway so that we see it is a different function. This helps in backports, for example. 

    Jan D. 

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.