GNU bug report logs - #14218
24.3; octave-insert-defun bad indentation since using smie

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#14218: closed (24.3; octave-insert-defun bad indentation
 since using smie)
Date: Thu, 25 Apr 2013 03:32:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 24 Apr 2013 23:26:05 -0400
with message-id <jwv4nevnvmh.fsf-monnier+emacs <at> gnu.org>
and subject line Re: bug#14218: 24.3; octave-insert-defun bad indentation since using smie
has caused the debbugs.gnu.org bug report #14218,
regarding 24.3; octave-insert-defun bad indentation since using smie
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
14218: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14218
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; octave-insert-defun bad indentation since using smie
Date: Wed, 17 Apr 2013 09:55:39 +0800

C-c C-f in octave-mode of emacs 22.1 normally inserts something like
this:

function B = hasWon (X, z, z0)

  ## usage:  B = hasWon (X, z, z0)                                              
  ##                                                                            
  ##                                                                            

endfunction


Now it inserts:

function B = hasWon (X, z, z0)
	 
	 ## usage: B = hasWon (X, z, z0)
	 ## 
	 ## 
	 
endfunction


i.e. it has wrong initial indentation. This might be a flaw of smie.

Leo

[Message part 3 (message/rfc822, inline)]

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Leo Liu <sdl.web <at> gmail.com>
Cc: 14218-done <at> debbugs.gnu.org
Subject: Re: bug#14218: 24.3;
	octave-insert-defun bad indentation since using smie
Date: Wed, 24 Apr 2013 23:26:05 -0400

> Now it inserts:

> function B = hasWon (X, z, z0)
	 
> 	 ## usage: B = hasWon (X, z, z0)
> 	 ## 
> 	 ## 
	 
> endfunction

> i.e. it has wrong initial indentation. This might be a flaw of smie.

Indeed.  There were several bugs triggered here.
I installed the patch below which fixes this problem.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.