Subject: bug#14218: closed (Re: bug#14218: 24.3; octave-insert-defun bad indentation since using smie)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 25 Apr 2013 03:32:04 +0000

Your bug report

#14218: 24.3; octave-insert-defun bad indentation since using smie

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
14218: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14218
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#14218: 24.3; octave-insert-defun bad indentation since using smie
From: Stefan Monnier <[email-masked]>
To: Leo Liu <[email-masked]>
Cc: [email-masked]
Date: Wed, 24 Apr 2013 23:26:05 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

> Now it inserts:

> function B = hasWon (X, z, z0)
	 
> 	 ## usage: B = hasWon (X, z, z0)
> 	 ## 
> 	 ## 
	 
> endfunction

> i.e. it has wrong initial indentation. This might be a flaw of smie.

Indeed.  There were several bugs triggered here.
I installed the patch below which fixes this problem.

        Stefan

Subject: 24.3; octave-insert-defun bad indentation since using smie
From: Leo Liu <[email-masked]>
To: [email-masked]
Date: Wed, 17 Apr 2013 09:55:39 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

C-c C-f in octave-mode of emacs 22.1 normally inserts something like
this:

function B = hasWon (X, z, z0)

  ## usage:  B = hasWon (X, z, z0)                                              
  ##                                                                            
  ##                                                                            

endfunction

Now it inserts:

function B = hasWon (X, z, z0)
	 
	 ## usage: B = hasWon (X, z, z0)
	 ## 
	 ## 
	 
endfunction

i.e. it has wrong initial indentation. This might be a flaw of smie.

Leo