Subject: bug#14209: closed (Re: bug#14209: 24.3.50; read-face-name: M-o o hi-yellow fails)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 20 Apr 2013 17:47:01 +0000

Your bug report

#14209: 24.3.50; read-face-name: M-o o hi-yellow fails

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
14209: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14209
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#14209: 24.3.50; read-face-name: M-o o hi-yellow fails
From: Roland Winkler <[email-masked]>
To: Jambunathan K <[email-masked]>
Cc: [email-masked]
Date: Sat, 20 Apr 2013 12:41:48 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

Version: 24.3.50

> ,----  Towards the end of `read-face-name' |  |     ;; Return 
> either a list of faces or just one face.  |     (if multiple | 
> (nreverse faces) |       (car (last faces)))   <===== FIXME: 
> `car' is necessary `---- 

Done.

Subject: 24.3.50; read-face-name: M-o o hi-yellow fails
From: Jambunathan K <[email-masked]>
To: [email-masked]
Date: Mon, 15 Apr 2013 22:44:11 +0530
List-Id: <debbugs-submit.debbugs.gnu.org>

M-o o hi-yellow fails with

,----
| Debugger entered--Lisp error: (wrong-type-argument stringp (hi-yellow))
|   intern((hi-yellow))
|   facemenu-add-new-face((hi-yellow))
|   facemenu-set-face((hi-yellow) nil nil)
|   call-interactively(facemenu-set-face nil nil)
|   command-execute(facemenu-set-face)
`----

The following fix works.

,----  Towards the end of `read-face-name'
| 
|     ;; Return either a list of faces or just one face.
|     (if multiple
|         (nreverse faces)
|       (car (last faces)))   <===== FIXME: `car' is necessary
`----

In GNU Emacs 24.3.50.2 (i686-pc-linux-gnu, GTK+ Version 2.20.1)
 of 2013-04-15 on debian-6.05
Bzr revision: 112293 [email-masked]
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
Important settings:
  value of $LANG: en_IN
  locale-coding-system: iso-latin-1-unix
  default enable-multibyte-characters: t