GNU bug report logs - #14182
24.2; [PATCH] gud: perldb works with eval-ed subs

Previous Next

Package: emacs;

Reported by: Dima Kogan <dima <at> secretsauce.net>

Date: Thu, 11 Apr 2013 10:55:01 UTC

Severity: normal

Tags: patch

Found in version 24.2

Done: Stefan Monnier <monnier <at> IRO.UMontreal.CA>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14182 in the body.
You can then email your comments to 14182 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#14182; Package emacs. (Thu, 11 Apr 2013 10:55:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Dima Kogan <dima <at> secretsauce.net>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 11 Apr 2013 10:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.2; [PATCH] gud: perldb works with eval-ed subs
Date: Thu, 11 Apr 2013 03:50:30 -0700
[Message part 1 (text/plain, inline)]
Hi.

This is a patch to fix a specific case that makes 'M-x perldb' unable to
step through some code.

When debugging through a subroutine defined in an eval, perldb uses a slightly
different string to communicate the debugger position. This patch updates the
regex in gud-perldb-marker-filter to be able to parse this string.

An example of a "normal" string:
 ^Z^Z/tmp/tst.pl:6:0

An example of a sub-in-eval string that can now be parsed:
 ^Z^Z(eval 5)[/tmp/tst.pl:6]:3:0

Sample perl source that couldn't be stepped through before, and now can be:

 eval 'sub f
 {
   print 34;
 }
 ';

 f();

[0001-gud-perldb-works-with-eval-ed-subs.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#14182; Package emacs. (Thu, 18 Apr 2013 07:53:01 GMT) Full text and rfc822 format available.

Message #8 received at 14182 <at> debbugs.gnu.org (full text, mbox):

From: Dima Kogan <dima <at> secretsauce.net>
To: 14182 <at> debbugs.gnu.org
Subject: updated patch
Date: Thu, 18 Apr 2013 00:48:03 -0700
[Message part 1 (text/plain, inline)]
I used the patch in the original report for a while, and stumbled on
another, related case that emacs doesn't handle. I'm attaching an
updated patch that handles both cases (described in the patch). I've
also broken up the regex for improved readability.

[0001-gud-perldb-works-with-eval-ed-subs.patch (text/x-diff, attachment)]

Reply sent to Stefan Monnier <monnier <at> IRO.UMontreal.CA>:
You have taken responsibility. (Fri, 19 Apr 2013 16:05:01 GMT) Full text and rfc822 format available.

Notification sent to Dima Kogan <dima <at> secretsauce.net>:
bug acknowledged by developer. (Fri, 19 Apr 2013 16:05:02 GMT) Full text and rfc822 format available.

Message #13 received at 14182-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Dima Kogan <dima <at> secretsauce.net>
Cc: 14182-done <at> debbugs.gnu.org
Subject: Re: bug#14182: updated patch
Date: Fri, 19 Apr 2013 11:59:20 -0400
> I used the patch in the original report for a while, and stumbled on
> another, related case that emacs doesn't handle. I'm attaching an
> updated patch that handles both cases (described in the patch). I've
> also broken up the regex for improved readability.

Thanks.  Installed with a minor change (I merged the two searches into
a single one, using the \(?N:...\) form).


        Stefan




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 18 May 2013 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 12 years and 37 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.