GNU bug report logs - #14179
[PATCH] hi-lock: more appropriate use of font-locking

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Juri Linkov <juri <at> jurta.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#14179: closed ([PATCH] hi-lock: more appropriate use of
 font-locking)
Date: Fri, 20 Dec 2013 19:48:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 20 Dec 2013 21:47:16 +0200
with message-id <87txe3wbi3.fsf <at> mail.jurta.org>
and subject line Re: bug#14179: [PATCH] hi-lock: more appropriate use of font-locking
has caused the debbugs.gnu.org bug report #14179,
regarding [PATCH] hi-lock: more appropriate use of font-locking
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
14179: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14179
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: E Sabof <esabof <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] hi-lock: more appropriate use of font-locking
Date: Thu, 11 Apr 2013 05:19:13 +0100

[Message part 3 (text/plain, inline)]

Most modes that use custom fontification (ex occur-mode), won't turn the
font-lock-mode off. So hi-lock would add a keyword, and remove all existing
fontification. The below patch fixes this behaviour.

Evgeni

Modified   lisp/hi-lock.el
diff --git a/lisp/hi-lock.el b/lisp/hi-lock.el
index e2dc4ea..e16ed76 100644
--- a/lisp/hi-lock.el
+++ b/lisp/hi-lock.el
@@ -689,7 +689,7 @@ Otherwise, read face name from minibuffer with
completion and history."
     ;; Refuse to highlight a text that is already highlighted.
     (unless (assoc regexp hi-lock-interactive-patterns)
       (push pattern hi-lock-interactive-patterns)
-      (if font-lock-mode
+      (if (and font-lock-mode (font-lock-specified-p major-mode))
   (progn
     (font-lock-add-keywords nil (list pattern) t)
     (font-lock-fontify-buffer))

[Message part 4 (text/html, inline)]

[Message part 5 (message/rfc822, inline)]

From: Juri Linkov <juri <at> jurta.org>
To: E Sabof <esabof <at> gmail.com>
Cc: 14179-done <at> debbugs.gnu.org
Subject: Re: bug#14179: [PATCH] hi-lock: more appropriate use of font-locking
Date: Fri, 20 Dec 2013 21:47:16 +0200

> Most modes that use custom fontification (ex occur-mode), won't turn the
> font-lock-mode off. So hi-lock would add a keyword, and remove all existing
> fontification. The below patch fixes this behaviour.

Thanks, fixed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.