GNU bug report logs - #14176
24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Wed, 10 Apr 2013 22:09:01 UTC

Severity: normal

Found in version 24.3.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 14176 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 14176 <at> debbugs.gnu.org
Subject: Re: bug#14176: 24.3.50;
	`bookmark-completing-read': prompt and return value for "" DEFAULT
Date: Thu, 11 Apr 2013 10:03:49 -0400

> Isn't there a bad usage of `completing-read' here, IMO the
> DEFAULT arg of `completing-read' should be used instead of:
> ,----
> | (if (string-equal "" str) default str)
> `----

Sounds like a left-over from previous code, indeed.

> Also why is 'default' let-bounded ?
> Here a patch:

Feel free to install it (assuming you've confirmed it works, that is ;-)


        Stefan
This bug report was last modified 12 years and 31 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.