From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 18:08:51 2013 Received: (at submit) by debbugs.gnu.org; 10 Apr 2013 22:08:51 +0000 Received: from localhost ([127.0.0.1]:44224 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQ3CE-0004sa-Af for submit@debbugs.gnu.org; Wed, 10 Apr 2013 18:08:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41077) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQ3CB-0004sF-UE for submit@debbugs.gnu.org; Wed, 10 Apr 2013 18:08:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQ38X-00037L-1t for submit@debbugs.gnu.org; Wed, 10 Apr 2013 18:05:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-106.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:48737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQ38W-00037H-V4 for submit@debbugs.gnu.org; Wed, 10 Apr 2013 18:05:00 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52433) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQ38U-0001am-Rz for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2013 18:05:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQ38U-00036l-24 for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2013 18:04:58 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:41593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQ38T-00036Z-Q6 for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2013 18:04:57 -0400 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r3AM4tDq001988 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 10 Apr 2013 22:04:56 GMT Received: from acsmt358.oracle.com (acsmt358.oracle.com [141.146.40.158]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3AM4tcK004012 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 10 Apr 2013 22:04:55 GMT Received: from abhmt111.oracle.com (abhmt111.oracle.com [141.146.116.63]) by acsmt358.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r3AM4tqb026851 for ; Wed, 10 Apr 2013 17:04:55 -0500 Received: from dradamslap1 (/130.35.178.8) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 10 Apr 2013 15:04:55 -0700 From: "Drew Adams" To: Subject: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Date: Wed, 10 Apr 2013 15:04:53 -0700 Message-ID: <7707C9A29C4748B093E2167A99592511@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac42N237xDspt3H7TUm8JD8CTEp+eg== X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) 1. Do not insert DEFAULT, in parens, into the PROMPT if DEFAULT is "". 2. Doc string should mention the return value ("") for empty input ("") when DEFAULT is nil. In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2013-04-02 on ODIEONE Bzr revision: 112212 cyd@gnu.org-20130402033331-sqegwhqh7u1o0ars Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib' From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 02:03:30 2013 Received: (at submit) by debbugs.gnu.org; 11 Apr 2013 06:03:31 +0000 Received: from localhost ([127.0.0.1]:44630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQAbX-00006p-Td for submit@debbugs.gnu.org; Thu, 11 Apr 2013 02:03:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44780) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQAbS-00005a-Bw for submit@debbugs.gnu.org; Thu, 11 Apr 2013 02:03:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQAXl-0005gZ-KE for submit@debbugs.gnu.org; Thu, 11 Apr 2013 01:59:34 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-104.3 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:53827) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQAXl-0005gV-Hz for submit@debbugs.gnu.org; Thu, 11 Apr 2013 01:59:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56136) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQAXk-0002y3-IF for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 01:59:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQAXj-0005fw-JZ for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 01:59:32 -0400 Received: from plane.gmane.org ([80.91.229.3]:52999) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQAXj-0005fb-D4 for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 01:59:31 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UQAXg-0004ri-7b for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 07:59:28 +0200 Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Apr 2013 07:59:28 +0200 Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Apr 2013 07:59:28 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Thierry Volpiatto Subject: Re: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Date: Thu, 11 Apr 2013 07:59:22 +0200 Organization: Emacs Helm Lines: 81 Message-ID: <87txnda9qd.fsf@gmail.com> References: <7707C9A29C4748B093E2167A99592511@us.oracle.com> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:pKRf+USLiihsG7i0mYWm2cL1kug= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Hi Drew, "Drew Adams" writes: > 1. Do not insert DEFAULT, in parens, into the PROMPT if DEFAULT is "". > > 2. Doc string should mention the return value ("") for empty input ("") > when DEFAULT is nil. Isn't there a bad usage of `completing-read' here, IMO the DEFAULT arg of `completing-read' should be used instead of: ,---- | (if (string-equal "" str) default str) `---- Also why is 'default' let-bounded ? Here a patch: diff --git a/lisp/bookmark.el b/lisp/bookmark.el index c1d8a4a..8698821 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -437,22 +437,21 @@ the empty string." 'string-lessp) (bookmark-all-names))) (let* ((completion-ignore-case bookmark-completion-ignore-case) - (default default) (prompt (concat prompt (if default (format " (%s): " default) - ": "))) - (str - (completing-read prompt - (lambda (string pred action) - (if (eq action 'metadata) - '(metadata (category . bookmark)) - (complete-with-action - action bookmark-alist string pred))) - nil - 0 - nil - 'bookmark-history))) - (if (string-equal "" str) default str)))) + ": ")))) + (completing-read prompt + (lambda (string pred action) + (if (eq action 'metadata) + '(metadata (category . bookmark)) + (complete-with-action + action bookmark-alist string pred))) + nil + 0 + nil + 'bookmark-history + default)))) + (defmacro bookmark-maybe-historicize-string (string) > In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) > of 2013-04-02 on ODIEONE > Bzr revision: 112212 cyd@gnu.org-20130402033331-sqegwhqh7u1o0ars > Windowing system distributor `Microsoft Corp.', version 5.1.2600 > Configured using: > `configure --with-gcc (4.7) --no-opt --enable-checking --cflags > -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib' > > > > > > -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 10:08:01 2013 Received: (at 14176) by debbugs.gnu.org; 11 Apr 2013 14:08:03 +0000 Received: from localhost ([127.0.0.1]:45712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQIAP-00008l-Mm for submit@debbugs.gnu.org; Thu, 11 Apr 2013 10:08:01 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:31543) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQIAG-00006j-D1 for 14176@debbugs.gnu.org; Thu, 11 Apr 2013 10:07:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxIEd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFFxIEd/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="7164011" Received: from 69-196-129-29.dsl.teksavvy.com (HELO pastel.home) ([69.196.129.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 11 Apr 2013 10:03:54 -0400 Received: by pastel.home (Postfix, from userid 20848) id 769D467984; Thu, 11 Apr 2013 10:03:49 -0400 (EDT) From: Stefan Monnier To: Thierry Volpiatto Subject: Re: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Message-ID: References: <7707C9A29C4748B093E2167A99592511@us.oracle.com> <87txnda9qd.fsf@gmail.com> Date: Thu, 11 Apr 2013 10:03:49 -0400 In-Reply-To: <87txnda9qd.fsf@gmail.com> (Thierry Volpiatto's message of "Thu, 11 Apr 2013 07:59:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 14176 Cc: 14176@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Isn't there a bad usage of `completing-read' here, IMO the > DEFAULT arg of `completing-read' should be used instead of: > ,---- > | (if (string-equal "" str) default str) > `---- Sounds like a left-over from previous code, indeed. > Also why is 'default' let-bounded ? > Here a patch: Feel free to install it (assuming you've confirmed it works, that is ;-) Stefan From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 11:14:44 2013 Received: (at submit) by debbugs.gnu.org; 11 Apr 2013 15:14:44 +0000 Received: from localhost ([127.0.0.1]:45807 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQJD2-0001Vz-8z for submit@debbugs.gnu.org; Thu, 11 Apr 2013 11:14:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37738) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQJCz-0001Vf-Ge for submit@debbugs.gnu.org; Thu, 11 Apr 2013 11:14:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQJ9G-0005Um-1C for submit@debbugs.gnu.org; Thu, 11 Apr 2013 11:10:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-104.3 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:47270) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJ9F-0005Ui-U4 for submit@debbugs.gnu.org; Thu, 11 Apr 2013 11:10:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49057) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJ9B-0001b7-1K for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 11:10:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UQJ99-0005S9-Md for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 11:10:44 -0400 Received: from plane.gmane.org ([80.91.229.3]:34794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UQJ99-0005Rx-FR for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 11:10:43 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1UQJ95-0005Di-5p for bug-gnu-emacs@gnu.org; Thu, 11 Apr 2013 17:10:39 +0200 Received: from lbe83-2-78-243-104-167.fbx.proxad.net ([78.243.104.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Apr 2013 17:10:39 +0200 Received: from thierry.volpiatto by lbe83-2-78-243-104-167.fbx.proxad.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 11 Apr 2013 17:10:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ To: bug-gnu-emacs@gnu.org From: Thierry Volpiatto Subject: Re: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Date: Thu, 11 Apr 2013 17:10:27 +0200 Organization: Emacs Helm Lines: 10 Message-ID: <87vc7tf6ho.fsf@gmail.com> References: <7707C9A29C4748B093E2167A99592511@us.oracle.com> <87txnda9qd.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: lbe83-2-78-243-104-167.fbx.proxad.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:7H0hfAIc//Pxt76pFjA1oovI+d4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.9 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Stefan Monnier writes: > Feel free to install it (assuming you've confirmed it works, that is ;-) Please apply, as you know I have no bzr installation here, thanks. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 11 17:36:38 2013 Received: (at 14176) by debbugs.gnu.org; 11 Apr 2013 21:36:38 +0000 Received: from localhost ([127.0.0.1]:46311 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQPAb-0005H2-Tp for submit@debbugs.gnu.org; Thu, 11 Apr 2013 17:36:38 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27300) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQPAZ-0005Gf-9G for 14176@debbugs.gnu.org; Thu, 11 Apr 2013 17:36:36 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r3BLWgMb000716 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 11 Apr 2013 21:32:43 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3BLWflb011823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Thu, 11 Apr 2013 21:32:42 GMT Received: from abhmt114.oracle.com (abhmt114.oracle.com [141.146.116.66]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3BLWfLf000653; Thu, 11 Apr 2013 21:32:41 GMT Received: from dradamslap1 (/10.159.70.141) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 11 Apr 2013 14:32:41 -0700 From: "Drew Adams" To: "'Thierry Volpiatto'" , <14176@debbugs.gnu.org> References: <7707C9A29C4748B093E2167A99592511@us.oracle.com> <87txnda9qd.fsf@gmail.com> Subject: RE: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Date: Thu, 11 Apr 2013 14:32:36 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87txnda9qd.fsf@gmail.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac42eeAoJ8SHGu5LSAetZ/BoQ3izSQAdVG+Q X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 14176 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > > 1. Do not insert DEFAULT, in parens, into the PROMPT if > > DEFAULT is "". > > > > 2. Doc string should mention the return value ("") for > > empty input ("") when DEFAULT is nil. > > Here a patch:... Wrt #1: No, that patch does not work: M-: (bookmark-completing-read "Bookmark" "") The prompt still shows empty parens: "Bookmark (): ". The prompt should be handled like this (or equivalent): (if (and default (not (equal "" default))) ; ^^^^^^^^^^^^^^^^^^^^^^^^ (concat prompt (format " (%s): " (if (consp default) (car default) default) default)) (concat prompt ": ")) (The handling of a cons DEFAULT is appropriate since Emacs 23. But that minor enhancement is really separate from this bug report. #1 is just about empty parens in the prompt.) Wrt #2: a. I misspoke a bit. The behavior was that nil (not "") was returned when DEFAULT is nil and the user enters empty input. IMO, the value returned should be "" (which Thierry's patch fixes, BTW). Given that correction, this (new) behavior should be pointed out in the doc string. That is #2 of the bug report. IOW, the function should always return a string, and that string should be empty ("") if DEFAULT is nil and the user input is empty. And we should point out this behavior explicitly in the doc string, for clarity. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 01:42:40 2013 Received: (at 14176) by debbugs.gnu.org; 12 Apr 2013 05:42:40 +0000 Received: from localhost ([127.0.0.1]:46783 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQWkx-0004Dv-Ix for submit@debbugs.gnu.org; Fri, 12 Apr 2013 01:42:40 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:55325) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQWku-0004DJ-NV for 14176@debbugs.gnu.org; Fri, 12 Apr 2013 01:42:38 -0400 Received: by mail-wi0-f173.google.com with SMTP id m6so213128wiv.12 for <14176@debbugs.gnu.org>; Thu, 11 Apr 2013 22:38:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=zNpopfU9efhkOdOlHmPk4sAIquNrHxm177jIz5dlbYc=; b=WnaEbzFU5HX7f6uphDB5rfYt6zAlCd1MxEIzi/S749Bk0nT3yON8HJkDT/TMhhVB3x fNbVvjf3XJjMrVGPYDjf5G+EG1wW2OPOYjgfLhYDLfDe3RYLa2jcfuazcpzJAXGEeJj9 jbQdmoj/Vrvr/afQJ2K0iK1TrE03csWvA06EerPyj3Aownmz4QIy6tcZinP7c7rqYE7J 351odQ7YZl9CzhunWkTAgZhS/lwk+6L6vtwHEl05psRULIALiSfi78Ba1GAKrN6rmcqb 8EaqGoHTd/fna98ZXEE/dopX+67E1A2jW4Ij0J9eEzud97NbmbmIJ5bSzCf9X6vp9YaG dhPg== X-Received: by 10.180.77.10 with SMTP id o10mr1607409wiw.10.1365745123080; Thu, 11 Apr 2013 22:38:43 -0700 (PDT) Received: from dell-14z (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id g9sm1363219wix.1.2013.04.11.22.38.40 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Thu, 11 Apr 2013 22:38:42 -0700 (PDT) From: Thierry Volpiatto To: "Drew Adams" Subject: Re: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Organization: Emacs Helm References: <7707C9A29C4748B093E2167A99592511@us.oracle.com> <87txnda9qd.fsf@gmail.com> Date: Fri, 12 Apr 2013 07:38:34 +0200 In-Reply-To: (Drew Adams's message of "Thu, 11 Apr 2013 14:32:36 -0700") Message-ID: <87ehegjokl.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14176 Cc: 14176@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) "Drew Adams" writes: > The prompt still shows empty parens: "Bookmark (): ". diff --git a/lisp/bookmark.el b/lisp/bookmark.el index c1d8a4a..ad1609b 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -437,22 +437,18 @@ the empty string." 'string-lessp) (bookmark-all-names))) (let* ((completion-ignore-case bookmark-completion-ignore-case) - (default default) + (default (unless (string= "" default) default)) (prompt (concat prompt (if default (format " (%s): " default) - ": "))) - (str - (completing-read prompt - (lambda (string pred action) - (if (eq action 'metadata) - '(metadata (category . bookmark)) - (complete-with-action - action bookmark-alist string pred))) - nil - 0 - nil - 'bookmark-history))) - (if (string-equal "" str) default str)))) + ": ")))) + (completing-read prompt + (lambda (string pred action) + (if (eq action 'metadata) + '(metadata (category . bookmark)) + (complete-with-action + action bookmark-alist string pred))) + nil 0 nil 'bookmark-history default)))) + (defmacro bookmark-maybe-historicize-string (string) > (The handling of a cons DEFAULT is appropriate since Emacs 23. But that minor > enhancement is really separate from this bug report. #1 is just about empty > parens in the prompt.) Don't see why DEFAULT would be a cons, a bookmark name is a string, so IMO DEFAULT should be a string or nil. > > Wrt #2: > > a. I misspoke a bit. The behavior was that nil (not "") was returned when > DEFAULT is nil and the user enters empty input. IMO, the value returned should > be "" (which Thierry's patch fixes, BTW). > > Given that correction, this (new) behavior should be pointed out in the doc > string. That is #2 of the bug report. > > IOW, the function should always return a string, and that string should be empty > ("") if DEFAULT is nil and the user input is empty. (bookmark-completing-read "test" "") => "" (bookmark-completing-read "test") => "" (bookmark-completing-read "test" "foo") => "foo" > And we should point out this behavior explicitly in the doc string, > for clarity. Maybe you can provide a patch ?... Thanks. -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 12 10:18:20 2013 Received: (at 14176) by debbugs.gnu.org; 12 Apr 2013 14:18:20 +0000 Received: from localhost ([127.0.0.1]:47439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQenz-0005JJ-FK for submit@debbugs.gnu.org; Fri, 12 Apr 2013 10:18:20 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:18891) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQenu-0005Ic-PC for 14176@debbugs.gnu.org; Fri, 12 Apr 2013 10:18:15 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r3CEEIp7001884 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 12 Apr 2013 14:14:18 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3CEEGN4016627 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Fri, 12 Apr 2013 14:14:17 GMT Received: from abhmt118.oracle.com (abhmt118.oracle.com [141.146.116.70]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3CEEG2l026538; Fri, 12 Apr 2013 14:14:16 GMT Received: from dradamslap1 (/10.159.167.111) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 12 Apr 2013 07:14:16 -0700 From: "Drew Adams" To: "'Thierry Volpiatto'" References: <7707C9A29C4748B093E2167A99592511@us.oracle.com><87txnda9qd.fsf@gmail.com> <87ehegjokl.fsf@gmail.com> Subject: RE: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Date: Fri, 12 Apr 2013 07:14:09 -0700 Message-ID: <0C53172999584A498FB4190ADC8990CB@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87ehegjokl.fsf@gmail.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Thread-Index: Ac43QAAiIOeFN+75Tg+ukSbg+tWvzgAQ0ZYw X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 14176 Cc: 14176@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > > (The handling of a cons DEFAULT is appropriate since Emacs > > 23. But that minor enhancement is really separate from > > this bug report. #1 is just about empty parens in the prompt.) > > Don't see why DEFAULT would be a cons, a bookmark name is a > string, so IMO DEFAULT should be a string or nil. As I said, it is not important for this bug report. But the DEF arg of `completing-read' can in general be a list of default values. No reason to lose that generality here. That's all. > > Wrt #2: > > > > a. I misspoke a bit. The behavior was that nil (not "") was > > returned when DEFAULT is nil and the user enters empty input. IMO, > > the value returned should be "" (which Thierry's patch fixes, BTW). > > > > Given that correction, this (new) behavior should be > > pointed out in the doc string. That is #2 of the bug report. > > > > IOW, the function should always return a string, and that > > string should be empty ("") if DEFAULT is nil and the user input > > is empty. > > (bookmark-completing-read "test") => "" That is the correct behavior, IMO. It was not the behavior before the patch. It returned nil before (i.e., it still returns nil in trunk and in 24.3). > > And we should point out this behavior explicitly in the doc string, > > for clarity. > > Maybe you can provide a patch ?... For the doc string: DEFAULT is a string to return if the user input is empty. If DEFAULT is nil (absent) then return "" for empty input. Or if a cons DEFAULT is accepted then this is all we need: DEFAULT is as for `completing-read'. Or if you don't want such indirection and a cons DEFAULT is accepted: DEFAULT is a string or a list of strings. If the user input is empty then return the string (or the first string in the list). If DEFAULT is nil (absent) then return "" for empty input. The last one is more explicit. This might be helpful, since returning "" instead of nil for empty input is an incompatible change. Prior to Emacs 22, `(nil)' was returned for empty input. Since Emacs 22, `nil' is returned. With this correction, `""' will be returned. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 04:20:14 2013 Received: (at 14176) by debbugs.gnu.org; 13 Apr 2013 08:20:14 +0000 Received: from localhost ([127.0.0.1]:48338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQvgz-0006oN-IG for submit@debbugs.gnu.org; Sat, 13 Apr 2013 04:20:13 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:41226) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UQvgx-0006o9-1Z for 14176@debbugs.gnu.org; Sat, 13 Apr 2013 04:20:12 -0400 Received: by mail-wg0-f44.google.com with SMTP id z11so3234813wgg.11 for <14176@debbugs.gnu.org>; Sat, 13 Apr 2013 01:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:organization:references:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=Af0LtQBum68dv6uKXTWa/BV+6n6eIFlRT5sC0+6LhMs=; b=HzQSFlnFyQsMYQ6IkpSv3O43z+eR9geGm4+VvjfhbuR0P9ZQw3B07ddiMNZooXu4fO jhuSci3AB8xVc8CJNUy4tuaDv2srfsdizHQ7PY+lATHLz4k8BK5at/maNEhT6FTNNeg/ J/XJ92pyIJ3o72bIH/TWQuyu6UGqthOqLotSLGHpLxksAubcm1jp0ApMtcEQvsBGu7gX uPlxs7R28wv8VPkm0/MnmV60kybph7UUw0w62Tk+30yac6fPrhT7ExvrZlb1ZIuQI5Z6 SSa/xTEmneqdgdCci2bkViyFmEPWR6oq/hlaTGitF+r2B95EPVHq+GW3Bsm6njhUAHgn 3ebw== X-Received: by 10.180.74.67 with SMTP id r3mr2160308wiv.14.1365840971159; Sat, 13 Apr 2013 01:16:11 -0700 (PDT) Received: from dell-14z (lbe83-2-78-243-104-167.fbx.proxad.net. [78.243.104.167]) by mx.google.com with ESMTPS id ek4sm1807958wib.11.2013.04.13.01.16.08 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 13 Apr 2013 01:16:09 -0700 (PDT) From: Thierry Volpiatto To: "Drew Adams" Subject: Re: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Organization: Emacs Helm References: <7707C9A29C4748B093E2167A99592511@us.oracle.com> <87txnda9qd.fsf@gmail.com> <87ehegjokl.fsf@gmail.com> <0C53172999584A498FB4190ADC8990CB@us.oracle.com> Date: Sat, 13 Apr 2013 10:16:01 +0200 In-Reply-To: <0C53172999584A498FB4190ADC8990CB@us.oracle.com> (Drew Adams's message of "Fri, 12 Apr 2013 07:14:09 -0700") Message-ID: <87zjx2n8vy.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14176 Cc: 14176@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) "Drew Adams" writes: > For the doc string: > > DEFAULT is a string to return if the user input is empty. > If DEFAULT is nil (absent) then return "" for empty input. Here with the docstring modified, if you want to modify the docstring (or something else), provide a patch to allow Stefan to apply the changes. Thanks. diff --git a/lisp/bookmark.el b/lisp/bookmark.el index c1d8a4a..c98ad0c 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -427,8 +427,8 @@ just return it." "Prompting with PROMPT, read a bookmark name in completion. PROMPT will get a \": \" stuck on the end no matter what, so you probably don't want to include one yourself. -Optional second arg DEFAULT is a string to return if the user enters -the empty string." +Optional arg DEFAULT is a string to return if the user input is empty. +If DEFAULT is nil then return empty string for empty input." (bookmark-maybe-load-default-file) ; paranoia (if (listp last-nonmenu-event) (bookmark-menu-popup-paned-menu t prompt @@ -437,22 +437,17 @@ the empty string." 'string-lessp) (bookmark-all-names))) (let* ((completion-ignore-case bookmark-completion-ignore-case) - (default default) + (default (unless (string= "" default) default)) (prompt (concat prompt (if default (format " (%s): " default) - ": "))) - (str - (completing-read prompt - (lambda (string pred action) - (if (eq action 'metadata) - '(metadata (category . bookmark)) - (complete-with-action - action bookmark-alist string pred))) - nil - 0 - nil - 'bookmark-history))) - (if (string-equal "" str) default str)))) + ": ")))) + (completing-read prompt + (lambda (string pred action) + (if (eq action 'metadata) + '(metadata (category . bookmark)) + (complete-with-action + action bookmark-alist string pred))) + nil 0 nil 'bookmark-history default)))) (defmacro bookmark-maybe-historicize-string (string) -- Thierry Get my Gnupg key: gpg --keyserver pgp.mit.edu --recv-keys 59F29997 From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 13 11:50:48 2013 Received: (at 14176) by debbugs.gnu.org; 13 Apr 2013 15:50:48 +0000 Received: from localhost ([127.0.0.1]:48860 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UR2j2-0000E2-23 for submit@debbugs.gnu.org; Sat, 13 Apr 2013 11:50:48 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:40975) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UR2j0-0000Dv-CZ for 14176@debbugs.gnu.org; Sat, 13 Apr 2013 11:50:47 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r3DFkhmB026119 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 13 Apr 2013 15:46:44 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3DFkhGf004884 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sat, 13 Apr 2013 15:46:43 GMT Received: from abhmt119.oracle.com (abhmt119.oracle.com [141.146.116.71]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3DFkhLM010278; Sat, 13 Apr 2013 15:46:43 GMT Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 13 Apr 2013 08:46:42 -0700 From: "Drew Adams" To: "'Thierry Volpiatto'" References: <7707C9A29C4748B093E2167A99592511@us.oracle.com><87txnda9qd.fsf@gmail.com><87ehegjokl.fsf@gmail.com><0C53172999584A498FB4190ADC8990CB@us.oracle.com> <87zjx2n8vy.fsf@gmail.com> Subject: RE: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Date: Sat, 13 Apr 2013 08:46:32 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: <87zjx2n8vy.fsf@gmail.com> Thread-Index: Ac44Hyn+8Y37y0hdQbSfCrGgxcZjUwAPPXSw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 14176 Cc: 14176@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > Here with the docstring modified, if you want to modify the docstring > (or something else), provide a patch to allow Stefan to apply the > changes. Looks good to me, thanks. I would still suggest that we use (if (consp default) (car default) default) instead of just `default', in the `format' sexp, to allow for a cons DEFAULT value. There is no reason not to, IMO. A caller might pass, for example, a list of (a) the current bookmark, (b) a bookmark mentioned in text at point, (c) the bookmark whose target location is closest to point... Or a caller might pass a list of bookmarks with targets in the current buffer/file. And so on. But that enhancement, though trivial, is outside this bug report. And if/when we do that, it would also be good to update the doc string to mention that DEFAULT can be a cons (as in `completing-read'). From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 19 01:16:46 2013 Received: (at 14176-done) by debbugs.gnu.org; 19 Apr 2013 05:16:46 +0000 Received: from localhost ([127.0.0.1]:59593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UT3gk-0004Jy-KP for submit@debbugs.gnu.org; Fri, 19 Apr 2013 01:16:46 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:59341) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UT3gj-0004Jp-3b for 14176-done@debbugs.gnu.org; Fri, 19 Apr 2013 01:16:45 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+LAd/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IPAS-Result: Av8EABK/CFHO+LAd/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="7771434" Received: from 206-248-176-29.dsl.teksavvy.com (HELO ceviche.home) ([206.248.176.29]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 19 Apr 2013 01:12:08 -0400 Received: by ceviche.home (Postfix, from userid 20848) id BCF86660E8; Fri, 19 Apr 2013 01:12:11 -0400 (EDT) From: Stefan Monnier To: Thierry Volpiatto Subject: Re: bug#14176: 24.3.50; `bookmark-completing-read': prompt and return value for "" DEFAULT Message-ID: References: <7707C9A29C4748B093E2167A99592511@us.oracle.com> <87txnda9qd.fsf@gmail.com> <87ehegjokl.fsf@gmail.com> <0C53172999584A498FB4190ADC8990CB@us.oracle.com> <87zjx2n8vy.fsf@gmail.com> Date: Fri, 19 Apr 2013 01:12:11 -0400 In-Reply-To: <87zjx2n8vy.fsf@gmail.com> (Thierry Volpiatto's message of "Sat, 13 Apr 2013 10:16:01 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14176-done Cc: 14176-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Thanks, installed, Stefan From unknown Sat Jun 14 19:06:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 17 May 2013 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator