From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 10 12:53:37 2013 Received: (at submit) by debbugs.gnu.org; 10 Apr 2013 16:53:37 +0000 Received: from localhost ([127.0.0.1]:43911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPyHA-0001R6-7Z for submit@debbugs.gnu.org; Wed, 10 Apr 2013 12:53:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37437) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UPqFN-0000IX-Up for submit@debbugs.gnu.org; Wed, 10 Apr 2013 04:19:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPqBk-00010v-L4 for submit@debbugs.gnu.org; Wed, 10 Apr 2013 04:15:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:44895) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPqBk-00010r-IL for submit@debbugs.gnu.org; Wed, 10 Apr 2013 04:15:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48787) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPqBh-0006ZM-Ec for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2013 04:15:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UPqBe-0000zy-C5 for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2013 04:15:25 -0400 Received: from nowhen.com ([70.36.235.49]:43951 helo=lies.damnlies.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UPqBd-0000xF-8R for bug-gnu-emacs@gnu.org; Wed, 10 Apr 2013 04:15:22 -0400 Received: from lies.damnlies.com (localhost [127.0.0.1]) by lies.damnlies.com (8.14.4/8.14.4/Debian-2ubuntu2) with ESMTP id r3A8F5pX007809 for ; Wed, 10 Apr 2013 01:15:06 -0700 Received: from lies.damnlies.com (jacob@localhost) by lies.damnlies.com (8.14.4/8.14.4/Submit) with ESMTP id r3A8F3vI007806 for ; Wed, 10 Apr 2013 01:15:04 -0700 Message-Id: <201304100815.r3A8F3vI007806@lies.damnlies.com> X-Authentication-Warning: lies.damnlies.com: jacob owned process doing -bs From: Jacob Butcher To: bug-gnu-emacs@gnu.org Subject: comint file completion bug Dept: Temporally Closed Artifacts Date: Wed, 10 Apr 2013 01:15:03 -0700 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 10 Apr 2013 12:53:35 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: bug-gnu-emacs@nowhen.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) Function comint-quote-filename does not correctly quote "]" characters when they appear in variable comint-file-name-quote-list. The function naively formats each character in the list into a string representation of a character set by surrounded them with "[" and "]". When the list consists of characters like " " and "|", that works fine, and yields character sets like "[ |]". But if the list is: (91 93 124 38 60 62 40 41 59 32 36 42 33 34 39 96 35 92) the resulting character set "[[]|&<>(); $*!\"'`#\\]" is wrong, as it does not place "]" first, the only location where it is permitted. (That restriction is not actually specified in, http://emacswiki.org/emacs/RegularExpression, which defines character sets rather poorly, but perhaps that wiki is not your responsibility.) I suspect adding "-" to comint-file-name-quote-list except as the first or last character would yield a similar problem. I fixed the problem for myself by putting 93 as the first list element. A more general solution would involve massaging the list in function comint-file-name-quote-list to put "]" first and "-" last, when present. I could write that code if you wish. Sincerely, Jacob Butcher From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 25 01:23:01 2017 Received: (at 14173) by debbugs.gnu.org; 25 Mar 2017 05:23:02 +0000 Received: from localhost ([127.0.0.1]:43106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1creAH-0005nG-FY for submit@debbugs.gnu.org; Sat, 25 Mar 2017 01:23:01 -0400 Received: from mail-it0-f41.google.com ([209.85.214.41]:34892) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1creAE-0005mv-Ud; Sat, 25 Mar 2017 01:22:59 -0400 Received: by mail-it0-f41.google.com with SMTP id y18so28500528itc.0; Fri, 24 Mar 2017 22:22:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dMhoV/l34E2Mfdthjfc5SUZnurpkMzMWM7s/KNMzwS0=; b=NGvjF7RzDZjfRlt43x/ip78rlQljgpTNiKvJGuKisVFiRSg7jGtwZf3d1vDAfZ7zjd 0uAYSS0wWtIPKe+AfGVu2cB8izjvTsFL/wr++oeHT6Vebfc37VnIt3X7rp3noGUXoLXL loWH4cMx2KzUJ1c6akYjnAjEFTgo4U3VpHcfRT3TlTtRNuLvk0J/BmMJmqDhE6McpMf+ pGUHh9zHEmQ9NRvg2ZmZV96L6HUYRrqhCG7b2W5mURsTgv+guLd5mcrviILKn+A3xMsQ Koq3eu/wvteFzaNFMmb4R1RGydnxKQADBKKMjyMTpgTFYEBd8ByjP0/5YZIUenh8T9EM j6ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=dMhoV/l34E2Mfdthjfc5SUZnurpkMzMWM7s/KNMzwS0=; b=DF2wjvSJPujq2UJ5Vj/+GKtjo4hc45TJw8mDEiAlEZWTU3eQYkAHpiE8r1g+QSIHXJ URvfNoJr6uJQ6HsyyZa8FaGkSlX1fk0dGQabjZ48cxDQV64yGo52nEx+n388Ui+S1avm g7y+m9uxbm7z6tUo3X93sy7/BurqrnqsJyC422Hcsq/iyr7rCeHsoZY1fTOsK7obGIOd ZvkSl1pZ873Qfw2ckQuZsDj+vxb2e8WCeZSyjW5/uCRltIgfMlf5RMsKqZaXLtzwZEgS 7ZufuY3aqKd2wISvy+Kkv2vi5CNkdKmOLk6V1XuzSaLQjKOXrr+TeKLCj4grtQAbyPIX EKXg== X-Gm-Message-State: AFeK/H1f7BwTVdf4yuA++DXJEPYCWlbsfJD3hVpH02jOy/B/d7fGnVW/y8jtOouD8E0dqA== X-Received: by 10.36.81.142 with SMTP id s136mr574581ita.119.1490419373265; Fri, 24 Mar 2017 22:22:53 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id f196sm370582itc.2.2017.03.24.22.22.52 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Mar 2017 22:22:52 -0700 (PDT) From: npostavs@users.sourceforge.net To: Jacob Butcher Subject: Re: bug#14173: comint file completion bug References: <201304100815.r3A8F3vI007806@lies.damnlies.com> Date: Sat, 25 Mar 2017 01:24:16 -0400 In-Reply-To: <201304100815.r3A8F3vI007806@lies.damnlies.com> (Jacob Butcher's message of "Wed, 10 Apr 2013 01:15:03 -0700") Message-ID: <87fui20vzz.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 14173 Cc: 14173@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 14173 fixed close 14173 24.3 quit Jacob Butcher writes: > Function comint-quote-filename does not correctly quote "]" characters when > they appear in variable comint-file-name-quote-list. The function naively > formats each character in the list into a string representation of a character > set by surrounded them with "[" and "]". > When the list consists of characters like " " and "|", that works fine, and > yields character sets like "[ |]". But if the list is: > > (91 93 124 38 60 62 40 41 59 32 36 42 33 34 39 96 35 92) > > the resulting character set "[[]|&<>(); $*!\"'`#\\]" is wrong, as it does > not place "]" first, the only location where it is permitted. This was fixed by [1: b4ff4f1fcb]. 1: 2012-04-25 14:53:57 -0400 b4ff4f1fcb552dab77d4312f9adb9f290782fa98 Use completion-table-with-quoting for comint and pcomplete. * lisp/comint.el [...] (comint-quote-filename): Use regexp-opt-charset. From unknown Fri Aug 15 04:06:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 22 Apr 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator