GNU bug report logs - #14153
24.3.50; regression: `crm--choose-completion-string' expects wrong args

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Sat, 6 Apr 2013 21:30:02 UTC

Severity: minor

Found in version 24.3.50

Fixed in version 24.4

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 14153 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 14153 <at> debbugs.gnu.org
Subject: Re: bug#14153: 24.3.50;
	regression: `crm--choose-completion-string' expects wrong args
Date: Sat, 06 Apr 2013 20:46:10 -0400

> Each such function should accept 4 args, as follows:
 
>  CHOICE - the string to insert in the buffer,
>  BUFFER - the buffer in which the choice should be inserted,
>  MINI-P - non-nil if BUFFER is a minibuffer, and
>  BASE-SIZE - the number of characters in BUFFER before
>           the string being completed.

Duh, sorry indeed, could you please update this docstring to match the code?

> But `crm--choose-completion-string' expects these args:
>  (CHOICE  BUFFER  BASE-POSITION  &rest IGNORED)

Which is indeed the correct calling convention nowadays.


        Stefan
This bug report was last modified 11 years and 110 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.