GNU bug report logs - #14153
24.3.50; regression: `crm--choose-completion-string' expects wrong args

Previous Next

Full log

Message #17 received at 14153 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Drew Adams <drew.adams <at> oracle.com>, 14153 <at> debbugs.gnu.org
Subject: Re: bug#14153: 24.3.50;
 regression: `crm--choose-completion-string' expects wrong args
Date: Sat, 08 Feb 2014 04:46:28 -0800

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> Each such function should accept 4 args, as follows:
>
>>  CHOICE - the string to insert in the buffer,
>>  BUFFER - the buffer in which the choice should be inserted,
>>  MINI-P - non-nil if BUFFER is a minibuffer, and
>>  BASE-SIZE - the number of characters in BUFFER before
>>           the string being completed.
>
> Duh, sorry indeed, could you please update this docstring to match the code?
>
>> But `crm--choose-completion-string' expects these args:
>>  (CHOICE  BUFFER  BASE-POSITION  &rest IGNORED)
>
> Which is indeed the correct calling convention nowadays.

Fixed on trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.