From unknown Tue Jun 24 10:30:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14153 <14153@debbugs.gnu.org> To: bug#14153 <14153@debbugs.gnu.org> Subject: Status: 24.3.50; regression: `crm--choose-completion-string' expects wrong args Reply-To: bug#14153 <14153@debbugs.gnu.org> Date: Tue, 24 Jun 2025 17:30:29 +0000 retitle 14153 24.3.50; regression: `crm--choose-completion-string' expects = wrong args reassign 14153 emacs submitter 14153 "Drew Adams" severity 14153 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 17:29:23 2013 Received: (at submit) by debbugs.gnu.org; 6 Apr 2013 21:29:23 +0000 Received: from localhost ([127.0.0.1]:37348 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOafr-0004tc-0Q for submit@debbugs.gnu.org; Sat, 06 Apr 2013 17:29:23 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36002) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOafl-0004tP-6D for submit@debbugs.gnu.org; Sat, 06 Apr 2013 17:29:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOacQ-0002g7-KY for submit@debbugs.gnu.org; Sat, 06 Apr 2013 17:25:53 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-106.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60864) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOacQ-0002g1-Hm for submit@debbugs.gnu.org; Sat, 06 Apr 2013 17:25:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOacO-0000Xx-2c for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2013 17:25:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UOacM-0002fZ-Ui for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2013 17:25:48 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:46025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UOacM-0002fT-GT for bug-gnu-emacs@gnu.org; Sat, 06 Apr 2013 17:25:46 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r36LPiJ2007460 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sat, 6 Apr 2013 21:25:45 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r36LPh2P021856 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL) for ; Sat, 6 Apr 2013 21:25:44 GMT Received: from abhmt112.oracle.com (abhmt112.oracle.com [141.146.116.64]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r36LPhjd024310 for ; Sat, 6 Apr 2013 21:25:43 GMT Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 06 Apr 2013 14:25:43 -0700 From: "Drew Adams" To: Subject: 24.3.50; regression: `crm--choose-completion-string' expects wrong args Date: Sat, 6 Apr 2013 14:25:34 -0700 Message-ID: <9A0D74D4FB64407CB482839873E8B61D@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac4zDUZRvSIjQX0kQfWzxVksBExGjA== X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.2 (------) A regression introduced in Emacs 23. There is no problem before 23. `completing-read-multiple' adds `crm--choose-completion-string' to `choose-completion-string-functions'. But `crm--choose-completion-string' has the wrong signature for a function on `choose-completion-string-functions'. Each such function should accept 4 args, as follows: CHOICE - the string to insert in the buffer, BUFFER - the buffer in which the choice should be inserted, MINI-P - non-nil if BUFFER is a minibuffer, and BASE-SIZE - the number of characters in BUFFER before the string being completed. But `crm--choose-completion-string' expects these args: (CHOICE BUFFER BASE-POSITION &rest IGNORED) In particular, it expects the third arg to be a position, not a Boolean indicator of whether BUFFER is a minibuffer. If the BUFFER is a minibuffer, so that MINI-P is non-nil (e.g. `t'), then `crm--choose-completion-string' mistakenly interprets that value as the BASE-POSITION. In code that I have this leads to this kind of error: Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p t) choose-completion-string("mode-line" # t) crm--choose-completion-string("mode-line" # t nil) run-hook-with-args-until-success(crm--choose-completion-string "mode-line" # t nil) Presumably no one has run into this because their code hasn't passed t as the value of MINI-P (?). In GNU Emacs 24.3.50.1 (i386-mingw-nt5.1.2600) of 2013-04-02 on ODIEONE Bzr revision: 112212 cyd@gnu.org-20130402033331-sqegwhqh7u1o0ars Windowing system distributor `Microsoft Corp.', version 5.1.2600 Configured using: `configure --with-gcc (4.7) --no-opt --enable-checking --cflags -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib' From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 20:49:38 2013 Received: (at 14153) by debbugs.gnu.org; 7 Apr 2013 00:49:38 +0000 Received: from localhost ([127.0.0.1]:37496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOdnd-0001H7-QP for submit@debbugs.gnu.org; Sat, 06 Apr 2013 20:49:38 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:55476) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOdnb-0001Gz-Gf for 14153@debbugs.gnu.org; Sat, 06 Apr 2013 20:49:35 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFxLSu/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IPAS-Result: Av8EABK/CFFFxLSu/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="6703105" Received: from 69-196-180-174.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.174]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Apr 2013 20:46:07 -0400 Received: by pastel.home (Postfix, from userid 20848) id 90C0B62EFF; Sat, 6 Apr 2013 20:46:10 -0400 (EDT) From: Stefan Monnier To: "Drew Adams" Subject: Re: bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args Message-ID: References: <9A0D74D4FB64407CB482839873E8B61D@us.oracle.com> Date: Sat, 06 Apr 2013 20:46:10 -0400 In-Reply-To: <9A0D74D4FB64407CB482839873E8B61D@us.oracle.com> (Drew Adams's message of "Sat, 6 Apr 2013 14:25:34 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14153 Cc: 14153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > Each such function should accept 4 args, as follows: > CHOICE - the string to insert in the buffer, > BUFFER - the buffer in which the choice should be inserted, > MINI-P - non-nil if BUFFER is a minibuffer, and > BASE-SIZE - the number of characters in BUFFER before > the string being completed. Duh, sorry indeed, could you please update this docstring to match the code? > But `crm--choose-completion-string' expects these args: > (CHOICE BUFFER BASE-POSITION &rest IGNORED) Which is indeed the correct calling convention nowadays. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 22:04:38 2013 Received: (at 14153) by debbugs.gnu.org; 7 Apr 2013 02:04:38 +0000 Received: from localhost ([127.0.0.1]:37569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOeyC-00033g-PD for submit@debbugs.gnu.org; Sat, 06 Apr 2013 22:04:38 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:22274) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOeyA-00033V-8T for 14153@debbugs.gnu.org; Sat, 06 Apr 2013 22:04:35 -0400 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r37217LA001822 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 7 Apr 2013 02:01:08 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r37216xx022348 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Sun, 7 Apr 2013 02:01:07 GMT Received: from abhmt102.oracle.com (abhmt102.oracle.com [141.146.116.54]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r37216Tu017757; Sun, 7 Apr 2013 02:01:06 GMT Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 06 Apr 2013 19:01:06 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <9A0D74D4FB64407CB482839873E8B61D@us.oracle.com> Subject: RE: bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args Date: Sat, 6 Apr 2013 19:00:57 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac4zKU2qR5wxoWbkQ0WBOmwgSleQYgACXVPw X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 14153 Cc: 14153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > > Each such function should accept 4 args, as follows: > > > CHOICE - the string to insert in the buffer, > > BUFFER - the buffer in which the choice should be inserted, > > MINI-P - non-nil if BUFFER is a minibuffer, and > > BASE-SIZE - the number of characters in BUFFER before > > the string being completed. > > Duh, sorry indeed, could you please update this docstring to > match the code? Sorry, I don't know what the new code parameters mean. S?he who changes the signature is best placed to update the spec/doc of that signature. > > But `crm--choose-completion-string' expects these args: > > (CHOICE BUFFER BASE-POSITION &rest IGNORED) > > Which is indeed the correct calling convention nowadays. How do you deal with older code that calls with a MINI-P parameter? It's one thing to ignore old parameters that you don't need anymore. It's quite another thing to change the signature so much that old calls provoke errors. This is apparently not about some particular function such as `crm--choose-completion-string'. It is about `choose-completion-string-functions', which has been around a long time and is a general purpose hook. Anyway, since you've changed the code, please change the doc string accordingly, whatever that might mean/entail. Thx. If you really need help with the wording, then communicate the meaning (content), and I will be glad to suggest wording. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 06 22:13:00 2013 Received: (at 14153) by debbugs.gnu.org; 7 Apr 2013 02:13:00 +0000 Received: from localhost ([127.0.0.1]:37579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOf6K-0003Fc-N2 for submit@debbugs.gnu.org; Sat, 06 Apr 2013 22:13:00 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:23214) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UOf6J-0003FW-Hc for 14153@debbugs.gnu.org; Sat, 06 Apr 2013 22:12:59 -0400 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id r3729Xf3005899 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sun, 7 Apr 2013 02:09:34 GMT Received: from acsmt356.oracle.com (acsmt356.oracle.com [141.146.40.156]) by ucsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id r3729W0f018472 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 7 Apr 2013 02:09:33 GMT Received: from abhmt103.oracle.com (abhmt103.oracle.com [141.146.116.55]) by acsmt356.oracle.com (8.12.11.20060308/8.12.11) with ESMTP id r3729VLj014168; Sat, 6 Apr 2013 21:09:31 -0500 Received: from dradamslap1 (/71.202.147.44) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sat, 06 Apr 2013 19:09:31 -0700 From: "Drew Adams" To: "'Stefan Monnier'" References: <9A0D74D4FB64407CB482839873E8B61D@us.oracle.com> Subject: RE: bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args Date: Sat, 6 Apr 2013 19:09:21 -0700 Message-ID: <03C363A8110B4D25BFC17949EFCC39A4@us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 In-Reply-To: Thread-Index: Ac4zKU2qR5wxoWbkQ0WBOmwgSleQYgACXVPwAABRo7A= X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -3.9 (---) X-Debbugs-Envelope-To: 14153 Cc: 14153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.2 (-----) I now see an entry in the Emacs 23 NEWS about this (good), now that I know what the change is, so what to look for (`choose-completion-string-functions'). From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 07:47:58 2014 Received: (at 14153) by debbugs.gnu.org; 8 Feb 2014 12:47:58 +0000 Received: from localhost ([127.0.0.1]:56630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC7K9-0000hI-JV for submit@debbugs.gnu.org; Sat, 08 Feb 2014 07:47:57 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:35312) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC7K7-0000hA-IS for 14153@debbugs.gnu.org; Sat, 08 Feb 2014 07:47:56 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WC7Jq-0002de-Dn; Sat, 08 Feb 2014 13:47:38 +0100 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#14153: 24.3.50; regression: `crm--choose-completion-string' expects wrong args References: <9A0D74D4FB64407CB482839873E8B61D@us.oracle.com> Date: Sat, 08 Feb 2014 04:46:28 -0800 In-Reply-To: (Stefan Monnier's message of "Sat, 06 Apr 2013 20:46:10 -0400") Message-ID: <87wqh5rcuz.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WC7Jq-0002de-Dn X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392468461.44814@LWKfFeGnu9rX+jGtAIXEnQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14153 Cc: Drew Adams , 14153@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Monnier writes: >> Each such function should accept 4 args, as follows: > >> CHOICE - the string to insert in the buffer, >> BUFFER - the buffer in which the choice should be inserted, >> MINI-P - non-nil if BUFFER is a minibuffer, and >> BASE-SIZE - the number of characters in BUFFER before >> the string being completed. > > Duh, sorry indeed, could you please update this docstring to match the code? > >> But `crm--choose-completion-string' expects these args: >> (CHOICE BUFFER BASE-POSITION &rest IGNORED) > > Which is indeed the correct calling convention nowadays. Fixed on trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 07:48:04 2014 Received: (at control) by debbugs.gnu.org; 8 Feb 2014 12:48:04 +0000 Received: from localhost ([127.0.0.1]:56634 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC7KF-0000hy-EN for submit@debbugs.gnu.org; Sat, 08 Feb 2014 07:48:03 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:35319) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC7KC-0000hR-Nh for control@debbugs.gnu.org; Sat, 08 Feb 2014 07:48:01 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WC7Jv-0002di-Qq for control@debbugs.gnu.org; Sat, 08 Feb 2014 13:47:44 +0100 Date: Sat, 08 Feb 2014 04:46:34 -0800 Message-Id: <87vbwprcut.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #14153 X-MailScanner-ID: 1WC7Jv-0002di-Qq X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392468467.5166@M0SeC2hRxyOLyFHmxdqJSA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 14153 24.4 From unknown Tue Jun 24 10:30:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 09 Mar 2014 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator