GNU bug report logs - #14152
[PATCH] build: use 'chmod a-w' instead of 'chmod -w'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Enrico Scholz <enrico.scholz <at> informatik.tu-chemnitz.de>
Subject: bug#14152: closed (Re: bug#14152: [PATCH] build: use 'chmod a-w'
 instead of 'chmod -w')
Date: Sun, 07 Apr 2013 01:23:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#14152: [PATCH] build: use 'chmod a-w' instead of 'chmod -w'

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 14152 <at> debbugs.gnu.org.

-- 
14152: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14152
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Bob Proulx <bob <at> proulx.com>
Cc: Enrico Scholz <enrico.scholz <at> informatik.tu-chemnitz.de>,
	14152-done <at> debbugs.gnu.org
Subject: Re: bug#14152: [PATCH] build: use 'chmod a-w' instead of 'chmod -w'
Date: Sun, 07 Apr 2013 02:19:25 +0100

On 04/06/2013 11:27 PM, Bob Proulx wrote:
> Pádraig Brady wrote:
>>> -	  && chmod -w $@-t						\
>>> +	  && chmod a-w $@-t						\
>>
>> I'll apply that fix.
> 
> I think it is always a good idea to use 'a' when there isn't any other
> specific reason to do anything different.  Or put the reverse way,
> whenever I see a naken "-[rwx]" then I am suspicious of the action.
> Because it masks with umask and is almost never what is desired.
> 
>> What system does the build fail on as a matter of interest.
> 
> This will occur on any system that has umask set to 022.  Here is an example:
> 
>   $ umask 022
>   $ touch foo
>   $ chmod ug+w foo
>   $ chmod -w foo
>   chmod: foo: new permissions are r--rw-r--, not r--r--r--
>   $ echo $?
>   1

But if the umask is 022, then those write bits shouldn't be set anyway?
You're forcing g+w above.

thanks,
Pádraig.

[Message part 3 (message/rfc822, inline)]

From: Enrico Scholz <enrico.scholz <at> informatik.tu-chemnitz.de>
To: bug-coreutils <at> gnu.org
Cc: Enrico Scholz <enrico.scholz <at> informatik.tu-chemnitz.de>
Subject: [PATCH] build: use 'chmod a-w' instead of 'chmod -w'
Date: Sat,  6 Apr 2013 14:23:59 +0200

'chmod -w' is not portable and breaks the build:

| WARNING: Cannot create proper 'hostid.1' man page, since perl is missing or
| WARNING: inadequate on this system.  Creating a stub man page instead.
| chmod: man/hostid.1-t: new permissions are r--rw-r--, not r--r--r--
| make[2]: *** [man/hostid.1] Error 1

Signed-off-by: Enrico Scholz <enrico.scholz <at> informatik.tu-chemnitz.de>
---
 man/local.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/man/local.mk b/man/local.mk
index b5e6e21..53debad 100644
--- a/man/local.mk
+++ b/man/local.mk
@@ -192,5 +192,5 @@ man/yes.1:       src/yes
 		     --output=$$t/$$name.1 $$t/$$name			\
 	  && sed 's|$*\.td/||g' $$t/$$name.1 > $@-t			\
 	  && rm -rf $$t							\
-	  && chmod -w $@-t						\
+	  && chmod a-w $@-t						\
 	  && mv $@-t $@
-- 
1.8.1.4

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.