From unknown Sat Aug 16 22:46:40 2025 X-Loop: don@donarmstrong.com Subject: bug#1414: 23.0.60; Middle mouse button does not work in Cocoa port Reply-To: Wolfgang Lux , 1414@debbugs.gnu.org Resent-From: Wolfgang Lux Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Mon, 24 Nov 2008 04:15:03 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1414 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12274996316725 (code B ref -1); Mon, 24 Nov 2008 04:15:03 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.8 required=4.0 tests=BAYES_00,MURPHY_DRUGS_REL8, RCVD_IN_DNSWL_MED,SUBJECT_FUZZY_TION autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 24 Nov 2008 04:07:11 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAO4776r006715 for ; Sun, 23 Nov 2008 20:07:09 -0800 Received: from mail.gnu.org ([199.232.76.166]:43292 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1L4Siq-0006mv-KA for emacs-pretest-bug@gnu.org; Sun, 23 Nov 2008 23:06:52 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1L4RNs-0004b8-PZ for emacs-pretest-bug@gnu.org; Sun, 23 Nov 2008 21:41:17 -0500 Received: from fg-out-1718.google.com ([72.14.220.156]:3513) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1L4DZX-0004xG-6H for emacs-pretest-bug@gnu.org; Sun, 23 Nov 2008 06:56:15 -0500 Received: by fg-out-1718.google.com with SMTP id l26so1576968fgb.30 for ; Sun, 23 Nov 2008 03:56:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:mime-version:to:message-id :content-type:from:subject:date:x-mailer; bh=cdDLJX8o71HZq+4ZADCXh2ceNKaygIwT0oBh4cw/zj4=; b=KFFOpC/QY7rn7c6VLAAX3CLg3if8SQgLhlA5MDTmNAJ/lSEUvzow8a61l4tWPYUA4w 5ZprSP88NvwFwiOzOhblyGpZFRouUT8AMC70HM61VWGbgTYkN/3lCRrkmjwFbkQtjDUW WGZtzhztlogrDJVTo6nJbAUPGdCshiUd1lIyk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:to:message-id:content-type:from:subject:date:x-mailer; b=jyTBtlLNL/g6o1QdYzSEW8OHCFhRIPn6cfXWzmGG8vVv6yt624U8qHfpdZChnQmXZp AitV8fdXTVYcyExRWOseDO9k5TGyTznvzSqbAjV7hRAeC15Zd8/XvLKX0/kI8sGB9Nrb d7Xm8oF/7RWOk+EHlLQagIloSipCFhx0Qdv7s= Received: by 10.103.171.20 with SMTP id y20mr720189muo.122.1227441373227; Sun, 23 Nov 2008 03:56:13 -0800 (PST) Received: from ?212.144.125.215? (dialin-212-144-125-215.pools.arcor-ip.net [212.144.125.215]) by mx.google.com with ESMTPS id j10sm547049muh.57.2008.11.23.03.56.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sun, 23 Nov 2008 03:56:12 -0800 (PST) Mime-Version: 1.0 (Apple Message framework v753.1) To: emacs-pretest-bug@gnu.org Message-Id: Content-Type: multipart/mixed; boundary=Apple-Mail-1-26061598 From: Wolfgang Lux Date: Sun, 23 Nov 2008 12:56:04 +0100 X-Mailer: Apple Mail (2.753.1) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) --Apple-Mail-1-26061598 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Please write in English if possible, because the Emacs maintainers usually do not have translators to read other languages for them. Your bug report will be posted to the emacs-pretest-bug@gnu.org mailing list. Please describe exactly what actions triggered the bug and the precise symptoms of the bug: Clicking the middle mouse button does not have an effect. The attached patch fixes this issue. In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, NS apple- appkit-824.48) of 2008-11-21 on Onyx.local Windowing system distributor `Apple', version 97.112.112.108.101.45.97.112.112.107.105.116.45.56.50.52.46.52.56 configured using `configure '--with-ns'' --Apple-Mail-1-26061598 Content-Transfer-Encoding: 7bit Content-Type: application/octet-stream; x-unix-mode=0644; name=nsterm.patch Content-Disposition: attachment; filename=nsterm.patch Index: src/nsterm.m =================================================================== RCS file: /sources/emacs/emacs/src/nsterm.m,v retrieving revision 1.35 diff -u -r1.35 nsterm.m --- src/nsterm.m 15 Nov 2008 05:20:49 -0000 1.35 +++ src/nsterm.m 23 Nov 2008 11:54:29 -0000 @@ -260,9 +260,12 @@ #define EV_UDMODIFIERS(e) \ ((([e type] == NSLeftMouseDown) ? down_modifier : 0) \ | (([e type] == NSRightMouseDown) ? down_modifier : 0) \ + | (([e type] == NSOtherMouseDown) ? down_modifier : 0) \ | (([e type] == NSLeftMouseDragged) ? down_modifier : 0) \ | (([e type] == NSRightMouseDragged) ? down_modifier : 0) \ + | (([e type] == NSOtherMouseDragged) ? down_modifier : 0) \ | (([e type] == NSLeftMouseUp) ? up_modifier : 0) \ + | (([e type] == NSOtherMouseUp) ? up_modifier : 0) \ | (([e type] == NSRightMouseUp) ? up_modifier : 0)) #define EV_BUTTON(e) \ @@ -4725,6 +4728,13 @@ } +- (void)otherMouseDown: (NSEvent *)theEvent +{ + NSTRACE (otherMouseDown); + [self mouseDown: theEvent]; +} + + - (void)rightMouseUp: (NSEvent *)theEvent { NSTRACE (rightMouseUp); @@ -4732,6 +4742,13 @@ } +- (void)otherMouseUp: (NSEvent *)theEvent +{ + NSTRACE (otherMouseUp); + [self mouseDown: theEvent]; +} + + - (void) scrollWheel: (NSEvent *)theEvent { NSTRACE (scrollWheel); @@ -4800,6 +4817,13 @@ } +- (void)otherMouseDragged: (NSEvent *)e +{ + NSTRACE (otherMouseDragged); + [self mouseMoved: e]; +} + + - (BOOL)windowShouldClose: (id)sender { NSEvent *e =[[self window] currentEvent]; --Apple-Mail-1-26061598-- From unknown Sat Aug 16 22:46:40 2025 X-Loop: don@donarmstrong.com Subject: bug#1414: #1414 - 23.0.60; Middle mouse button does not work in Cocoa port - Emacs bug report logs Reply-To: Adrian Robert , 1414@debbugs.gnu.org Resent-From: Adrian Robert Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs , don@donarmstrong.com Resent-Date: Tue, 25 Nov 2008 04:25:05 +0000 Resent-Message-ID: Resent-Sender: don@donarmstrong.com X-Emacs-PR-Message: report 1414 X-Emacs-PR-Package: emacs,ns X-Emacs-PR-Keywords: Received: via spool by 1414-submit@emacsbugs.donarmstrong.com id=B1414.122758669132117 (code B ref 1414); Tue, 25 Nov 2008 04:25:05 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-4.1 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8,SUBJECT_FUZZY_TION autolearn=no version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 1414) by emacsbugs.donarmstrong.com; 25 Nov 2008 04:18:11 +0000 Received: from smtprelay.b.hostedemail.com (smtprelay0020.b.hostedemail.com [64.98.42.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mAP4I89o032111 for <1414@emacsbugs.donarmstrong.com>; Mon, 24 Nov 2008 20:18:09 -0800 Received: from filter.hostedemail.com (b-bigip1 [10.5.19.254]) by smtprelay04.b.hostedemail.com (Postfix) with SMTP id AE36F19C7D99; Tue, 25 Nov 2008 04:18:07 +0000 (UTC) X-SpamScore: 1 Received: from [10.0.1.198] (unknown [72.169.150.82]) (Authenticated sender: arobert@hughes.net) by omf13.b.hostedemail.com (Postfix) with ESMTP; Tue, 25 Nov 2008 04:17:59 +0000 (UTC) Message-Id: <9919D535-CB98-4C8F-9EA4-1144068C467C@gmail.com> From: Adrian Robert To: 1414@debbugs.gnu.org Content-Type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v929.2) Date: Mon, 24 Nov 2008 23:12:42 -0500 Cc: Wolfgang Lux X-Mailer: Apple Mail (2.929.2) X-session-marker: 61726F62657274406875676865732E6E6574 Thank you for the patch, I've applied it, with a small modification to also change the EV_BUTTON to use [e buttonNumber] in the otherMouse case.