From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 03 17:57:17 2013 Received: (at submit) by debbugs.gnu.org; 3 Apr 2013 21:57:17 +0000 Received: from localhost ([127.0.0.1]:60647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UNVgD-0007af-6S for submit@debbugs.gnu.org; Wed, 03 Apr 2013 17:57:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48394) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UNVgA-0007aV-Ly for submit@debbugs.gnu.org; Wed, 03 Apr 2013 17:57:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNVd8-0007pg-Ql for submit@debbugs.gnu.org; Wed, 03 Apr 2013 17:54:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:37886) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNVd8-0007pb-N0 for submit@debbugs.gnu.org; Wed, 03 Apr 2013 17:54:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59739) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNVd7-0006fe-CV for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2013 17:54:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UNVd5-0007ok-SC for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2013 17:54:05 -0400 Received: from mail-ee0-f51.google.com ([74.125.83.51]:44549) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UNVd5-0007oJ-LM for bug-gnu-emacs@gnu.org; Wed, 03 Apr 2013 17:54:03 -0400 Received: by mail-ee0-f51.google.com with SMTP id c4so817534eek.24 for ; Wed, 03 Apr 2013 14:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:from:date:message-id:subject:to :content-type; bh=qQZ3s0zlbCpVTHWtXYlMQugcU9ejibAB6P+wbKo+/aU=; b=nFr5fp/HOF5oMiiIpAtzPw34QFthuqK3DSrIpebe5vXSc8F5Pt+zT++ghsGUy8EtBo UzIjtAQ+DHXncMP6K6ceSkT58HoDED5I28fog6wy95VPNY+WidjNPHo5xVGxEY1/SSF8 wfsDUiJoPaPqp23mKCKVYgu1gP5LDPRmdLIGvMQDYo+VDV3QAqyUdnyECPj2i+M4usqu Xa+7P1H+GTbfHLP3FYjpsTXJGo6H/Lzxv3pJ/cc0Xf6Mh2LBQ+1sKNoOHlm1XigJp08Z jXfYaiumvnN4dR6zzengo7Zl4PBX/6MPBW+nNcnXtI/ZEcdLJHCII4yGcQMe7evjNQ34 gD7A== X-Received: by 10.14.219.129 with SMTP id m1mr6297594eep.16.1365026042169; Wed, 03 Apr 2013 14:54:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.15.82.1 with HTTP; Wed, 3 Apr 2013 14:53:22 -0700 (PDT) From: Juanma Barranquero Date: Wed, 3 Apr 2013 23:53:22 +0200 Message-ID: Subject: not recording macro To: Bug-Gnu-Emacs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Package: emacs Version: 24.3.50 emacs -Q ;; Defining kbd macro... a ;; Keyboard macro defined ;; No kbd macro has been defined From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 03:31:43 2013 Received: (at 14135) by debbugs.gnu.org; 5 Apr 2013 07:31:43 +0000 Received: from localhost ([127.0.0.1]:34631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UO17f-0002KZ-1H for submit@debbugs.gnu.org; Fri, 05 Apr 2013 03:31:43 -0400 Received: from mail-pb0-f54.google.com ([209.85.160.54]:42954) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UO17c-0002KR-4c for 14135@debbugs.gnu.org; Fri, 05 Apr 2013 03:31:41 -0400 Received: by mail-pb0-f54.google.com with SMTP id xa7so1879323pbc.13 for <14135@debbugs.gnu.org>; Fri, 05 Apr 2013 00:28:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=pRxwKBkaRKuuGpBItsrH2fTBzugWG4eLjAQoZNJ5SWA=; b=LMH2YBVhJZ8OySarMkV/pS6a+FFHopqmCFEgD66F6x7TJ30Rhz/erZXQLnYbvSH/Fr VzYbZ9iynJ6DhSeNe25DalyYBttd1F9fxYqDybLKkJrgC/SM6j6XxjQAK0g5QU1dlnid /1ngNwzjhc1h2OPbncFD5lgH0YWqWQQRobZ3b1/skbNaB+/L1nF+PcA1p0wbIuUxpEtQ ToqlwtKuByLbx477pdldUFQ/3yfivFaWqwW5HSsWTT0j7Mz+DdA2eGopWJ/9D+cBpCBO kU/GU5xyI+nju/n8sLRXBo1qOFIFOGAnm0pYtfaBvQuGrpezD0ZYOV8wiKQnTPJNSops eTew== X-Received: by 10.66.221.226 with SMTP id qh2mr13794597pac.62.1365146905418; Fri, 05 Apr 2013 00:28:25 -0700 (PDT) Received: from localhost ([61.148.244.73]) by mx.google.com with ESMTPS id z1sm13383823pbw.19.2013.04.05.00.28.21 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 05 Apr 2013 00:28:24 -0700 (PDT) From: Leo Liu To: Juanma Barranquero Subject: Re: bug#14135: not recording macro References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Fri, 05 Apr 2013 15:28:21 +0800 In-Reply-To: (Juanma Barranquero's message of "Wed, 3 Apr 2013 23:53:22 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14135 Cc: 14135@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) On 2013-04-04 05:53 +0800, Juanma Barranquero wrote: > Package: emacs > Version: 24.3.50 > > emacs -Q > ;; Defining kbd macro... > a > ;; Keyboard macro defined > ;; No kbd macro has been defined Thanks for the bug report. Sorry this is broken by my commit. Could you give the following patch a good test? Thanks a lot. -- Leo diff --git a/lisp/kmacro.el b/lisp/kmacro.el index c08f49df..d6de2feb 100644 --- a/lisp/kmacro.el +++ b/lisp/kmacro.el @@ -631,11 +631,11 @@ (defun kmacro-call-macro (arg &optional no-repeat end-macro macro) (> (length (this-single-command-keys)) 1)) ;; Used when we're in the process of repeating. (eq no-repeat 'repeating)) - last-input-event)) - (last-kbd-macro (or macro last-kbd-macro))) + last-input-event))) (if end-macro - (kmacro-end-macro arg) - (call-last-kbd-macro arg #'kmacro-loop-setup-function)) + (kmacro-end-macro arg) ; modifies last-kbd-macro + (let ((last-kbd-macro (or macro last-kbd-macro))) + (call-last-kbd-macro arg #'kmacro-loop-setup-function))) (when (consp arg) (setq arg (car arg))) (when (and (or (null arg) (> arg 0)) @@ -658,7 +658,9 @@ (defun kmacro-call-macro (arg &optional no-repeat end-macro macro) (define-key map (vector repeat-key) `(lambda () (interactive) (kmacro-call-macro ,(and kmacro-call-repeat-with-arg arg) - 'repeating nil ,last-kbd-macro))) + 'repeating nil ,(if end-macro + last-kbd-macro + (or macro last-kbd-macro))))) map))))) From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 04:32:12 2013 Received: (at 14135) by debbugs.gnu.org; 5 Apr 2013 08:32:12 +0000 Received: from localhost ([127.0.0.1]:34811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UO24C-0003pf-HA for submit@debbugs.gnu.org; Fri, 05 Apr 2013 04:32:12 -0400 Received: from mail-ea0-f169.google.com ([209.85.215.169]:57579) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UO24B-0003pX-4x for 14135@debbugs.gnu.org; Fri, 05 Apr 2013 04:32:11 -0400 Received: by mail-ea0-f169.google.com with SMTP id n15so1242379ead.14 for <14135@debbugs.gnu.org>; Fri, 05 Apr 2013 01:28:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:mime-version:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=OqL+oyxlxbgPA+SozGGTUPrRK/f0zL1f5EtoyM88Cd8=; b=l+dlM8GL6ATPzHu6WufPS54QrZGDgeCntkGV+PlmO4CpqdDKz7TglrKD5esj4fvB45 bvpGSSRUfUtleAxjF+fmcllc83P449uPxM1Tg1gsyuTuqDuMPe2jRRHkpS0SwIcWZ43k 2KCG7J4v7nGa+5jhsFR6KILYO3PJl6p+f8cc3ty5bY3GTNWwwMmMaU7vXPnNIrRNvE7q Zy4ZuRxwsuwvLuTh3ro2fI4ujsexJVTo0wl9xM6Z5OnT/OYAbFiEM16959W6qj2uPgry mD41kDB0Fird5hHUbl6EL/cJSa9Q27qy2NEe77aDeIa2U69ZoWyXIgOl21Itp6DczDYT I9TQ== X-Received: by 10.14.173.196 with SMTP id v44mr17493787eel.29.1365150536231; Fri, 05 Apr 2013 01:28:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.15.82.1 with HTTP; Fri, 5 Apr 2013 01:28:16 -0700 (PDT) In-Reply-To: References: From: Juanma Barranquero Date: Fri, 5 Apr 2013 10:28:16 +0200 Message-ID: Subject: Re: bug#14135: not recording macro To: Leo Liu Content-Type: text/plain; charset=UTF-8 X-Spam-Score: 0.1 (/) X-Debbugs-Envelope-To: 14135 Cc: 14135@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -0.7 (/) On Fri, Apr 5, 2013 at 9:28 AM, Leo Liu wrote: > Could you give the following patch a good test? I'm not so heavy a user of macros to give it a "good test", but the broken functionality is restored. Thanks, J From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 05 04:43:46 2013 Received: (at 14135-done) by debbugs.gnu.org; 5 Apr 2013 08:43:46 +0000 Received: from localhost ([127.0.0.1]:34834 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UO2FM-00048E-Ac for submit@debbugs.gnu.org; Fri, 05 Apr 2013 04:43:46 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:58063) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UO2FH-000481-MU for 14135-done@debbugs.gnu.org; Fri, 05 Apr 2013 04:43:41 -0400 Received: by mail-pd0-f176.google.com with SMTP id r11so1886481pdi.7 for <14135-done@debbugs.gnu.org>; Fri, 05 Apr 2013 01:40:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=rlGTQ0Q4dtC/sTyNh8tsWNZsl4YDmlU8SyVL/PKBMtg=; b=Ng6n9utdRQ9CYlqD/IbdKaDzeoYOxTlkDJh1GFWlr5IXjiuge3yeRKPNtNMUqE5ZwJ NSrvMAbcYRnQHfJcsluEQ4sACp0IXrteYaxAsO0Yt3sE9p0ZKLw24xnEOw2KUvEn5/6d /8GqhNl5+0yXRgYuwK10W/1QO2QUsiNkryxeW5/LATV/boVyd76+GSLDO1cV7vkt0Ztr qjF1nKXNXp3oLltrfykm4fmXXQq1YhDUjDWyn/BxFaxKqlnth6BiFJIXRxcRjArjzzSa LDiwZKHO1FkHv6O7C0EAsQ66oC5GHR+XjXS5K5C+dB6DzWeGfVW+K3h/JuZc6sPSQpw3 6Jeg== X-Received: by 10.66.187.231 with SMTP id fv7mr13985008pac.46.1365151224578; Fri, 05 Apr 2013 01:40:24 -0700 (PDT) Received: from localhost ([61.148.244.73]) by mx.google.com with ESMTPS id ql7sm13641170pbb.2.2013.04.05.01.40.21 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 05 Apr 2013 01:40:24 -0700 (PDT) From: Leo Liu To: Juanma Barranquero Subject: Re: bug#14135: not recording macro References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= Date: Fri, 05 Apr 2013 16:40:20 +0800 In-Reply-To: (Juanma Barranquero's message of "Fri, 5 Apr 2013 10:28:16 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 14135-done Cc: 14135-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Fixed in trunk. On 2013-04-05 16:28 +0800, Juanma Barranquero wrote: > I'm not so heavy a user of macros to give it a "good test", but the > broken functionality is restored. Thanks. Leo From unknown Sat Jun 21 12:15:22 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 03 May 2013 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator