From unknown Fri Aug 15 02:02:26 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14122 <14122@debbugs.gnu.org> To: bug#14122 <14122@debbugs.gnu.org> Subject: Status: csv-mode: can't kill column from single-column file Reply-To: bug#14122 <14122@debbugs.gnu.org> Date: Fri, 15 Aug 2025 09:02:26 +0000 retitle 14122 csv-mode: can't kill column from single-column file reassign 14122 emacs submitter 14122 Dan severity 14122 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 02 12:05:22 2013 Received: (at submit) by debbugs.gnu.org; 2 Apr 2013 16:05:22 +0000 Received: from localhost ([127.0.0.1]:58367 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UN3i4-0004ZE-83 for submit@debbugs.gnu.org; Tue, 02 Apr 2013 12:05:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58828) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UMwCC-0000C0-J1 for submit@debbugs.gnu.org; Tue, 02 Apr 2013 04:03:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMw9K-0006vL-F4 for submit@debbugs.gnu.org; Tue, 02 Apr 2013 04:00:59 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID,USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:58363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMw9K-0006vF-Bc for submit@debbugs.gnu.org; Tue, 02 Apr 2013 04:00:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41921) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMw9F-0002b8-Jl for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2013 04:00:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMw9A-0006sb-Bz for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2013 04:00:53 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:48626) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMw9A-0006sI-2c for bug-gnu-emacs@gnu.org; Tue, 02 Apr 2013 04:00:48 -0400 Received: by mail-lb0-f169.google.com with SMTP id p11so198843lbi.28 for ; Tue, 02 Apr 2013 01:00:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:date:message-id:subject:from:to :content-type; bh=VLdHXiC4h8gS6U9AOFpLVqr0YPI7qNFFkMSWq86bQMw=; b=ed5B7SdofA7BvrxqyfmImJCoGmgwSlRcvHYC72vzQj7HFVUhvMy+d+M8F/cZkLWXr3 qewtH9WpaG6jzLGo8AnJFpyoKRFp+pUXCX+93p2iL1dYx7JmiM9Ttjj7Qe9Q5wCSbGpK ZJqjq3OmzfceZY83TFEXhtOr6jdMRtzZvtsaXXFfWW+XBioXyQHALkkJkJg6h5PaNpUN Akh6T+kJ+L9YzgcbUgi8ex2LzhlRT8gPCaitbDxsnBznZ3AxyhsNxsId+yaEOSjPGB5h mbQ5SBeC5lhqhZnl0xsbaMVdpVY3pr8ESNsNPu5SsRKtXY45aYqzu8/dJHVyLyvus+I6 PLLw== MIME-Version: 1.0 X-Received: by 10.112.101.230 with SMTP id fj6mr7092431lbb.115.1364889646103; Tue, 02 Apr 2013 01:00:46 -0700 (PDT) Received: by 10.114.184.5 with HTTP; Tue, 2 Apr 2013 01:00:45 -0700 (PDT) Date: Tue, 2 Apr 2013 11:00:45 +0300 Message-ID: Subject: csv-mode: can't kill column from single-column file From: Dan To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 02 Apr 2013 12:05:16 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) If I try to kill column 1 (the only column) from a single-column csv file, it correctly guesses the entire buffer as the desired region, the desired field as 1, then proceeds to only kill the header row (instead of the entire region). Subsequently yank-column doesn't work. This is emacs=24.1+1-2ubuntu3 with csv-mode=1.1 (latest from ELPA) From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 15:34:54 2013 Received: (at 14122) by debbugs.gnu.org; 24 Apr 2013 19:34:54 +0000 Received: from localhost ([127.0.0.1]:41484 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV5Sw-0006tz-8C for submit@debbugs.gnu.org; Wed, 24 Apr 2013 15:34:54 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:50809) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV5Su-0006tp-Ns for 14122@debbugs.gnu.org; Wed, 24 Apr 2013 15:34:53 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFFpYYW/2dsb2JhbAA7Cbs1g1kXc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2NFoN0A6R6gV6DEw X-IPAS-Result: Av8EABK/CFFFpYYW/2dsb2JhbAA7Cbs1g1kXc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2NFoN0A6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="8210703" Received: from 69-165-134-22.dsl.teksavvy.com (HELO pastel.home) ([69.165.134.22]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Apr 2013 15:29:44 -0400 Received: by pastel.home (Postfix, from userid 20848) id D4BB267A3A; Wed, 24 Apr 2013 15:29:47 -0400 (EDT) From: Stefan Monnier To: Dan Subject: Re: bug#14122: csv-mode: can't kill column from single-column file Message-ID: References: Date: Wed, 24 Apr 2013 15:29:47 -0400 In-Reply-To: (Dan's message of "Tue, 2 Apr 2013 11:00:45 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14122 Cc: 14122@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > If I try to kill column 1 (the only column) from a single-column csv > file, it correctly guesses the entire buffer as the desired region, > the desired field as 1, then proceeds to only kill the header row > (instead of the entire region). Indeed, thanks for the report. I installed the patch below for csv-mode-1.2, which should fix this problem. Stefan === modified file 'packages/csv-mode/csv-mode.el' --- packages/csv-mode/csv-mode.el 2012-10-22 21:58:24 +0000 +++ packages/csv-mode/csv-mode.el 2013-04-24 19:25:16 +0000 @@ -844,21 +844,18 @@ (csv-kill-one-column (car fields))))) (setq csv-killed-fields (nreverse csv-killed-fields))) -(defmacro csv-kill-one-field (field killed-fields) +(defun csv-kill-one-field (field) "Kill field with index FIELD in current line. -Save killed field by `push'ing onto KILLED-FIELDS. -Assumes point is at beginning of line. -Called by `csv-kill-one-column' and `csv-kill-many-columns'." - `(progn +Return killed text. Assumes point is at beginning of line." ;; Move to start of field to kill: - (csv-sort-skip-fields ,field) + (csv-sort-skip-fields field) ;; Kill to end of field (cf. `kill-region'): - (push (delete-and-extract-region + (prog1 (delete-and-extract-region (point) (progn (csv-end-of-field) (point))) - ,killed-fields) - (if (eolp) (delete-char -1) ; delete trailing separator at eol - (delete-char 1)))) ; or following separator otherwise + (if (eolp) + (unless (bolp) (delete-char -1)) ; Delete trailing separator at eol + (delete-char 1)))) ; or following separator otherwise. (defun csv-kill-one-column (field) "Kill field with index FIELD in all lines in (narrowed) buffer. @@ -867,7 +864,7 @@ Ignore blank and comment lines." (while (not (eobp)) (or (csv-not-looking-at-record) - (csv-kill-one-field field csv-killed-fields)) + (push (csv-kill-one-field field) csv-killed-fields)) (forward-line))) (defun csv-kill-many-columns (fields) @@ -912,7 +909,7 @@ (setq field (car fields) fields (cdr fields)) (beginning-of-line) - (csv-kill-one-field field killed-fields)) + (push (csv-kill-one-field field) killed-fields)) (push (mapconcat 'identity killed-fields (car csv-separators)) csv-killed-fields))) (forward-line))) From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 24 15:35:25 2013 Received: (at control) by debbugs.gnu.org; 24 Apr 2013 19:35:25 +0000 Received: from localhost ([127.0.0.1]:41488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV5TQ-0006vL-UN for submit@debbugs.gnu.org; Wed, 24 Apr 2013 15:35:25 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:55910) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UV5TP-0006v9-58 for control@debbugs.gnu.org; Wed, 24 Apr 2013 15:35:23 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EABK/CFFFpYYW/2dsb2JhbABEvw4Xc4IfAQVWMws0EhQYDYhIwS2NYYMpA6R6gV6DEw X-IPAS-Result: Av0EABK/CFFFpYYW/2dsb2JhbABEvw4Xc4IfAQVWMws0EhQYDYhIwS2NYYMpA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="8210762" Received: from 69-165-134-22.dsl.teksavvy.com (HELO pastel.home) ([69.165.134.22]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 24 Apr 2013 15:30:14 -0400 Received: by pastel.home (Postfix, from userid 20848) id 596BF67A3A; Wed, 24 Apr 2013 15:30:18 -0400 (EDT) From: Stefan Monnier To: control@debbugs.gnu.org Subject: Re: bug#14122: csv-mode: can't kill column from single-column file Message-ID: References: Date: Wed, 24 Apr 2013 15:30:18 -0400 In-Reply-To: (Dan's message of "Tue, 2 Apr 2013 11:00:45 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) close 14122 thanks From unknown Fri Aug 15 02:02:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 23 May 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator