Subject: [Nicolas Petton] bug#14114: tango-dark: background highlighting not working properly

From: Nicolas Petton <[email-masked]>
Date: Fri, 20 Apr 2018 22:54:07 +0200

tags 14114 notabug
close 14114
stop

Subject: bug#14114: tango-dark: background highlighting not working properly
From: Nicolas Petton <[email-masked]>
To: [email-masked]
Date: Fri, 20 Apr 2018 22:35:26 +0200
List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org>

tags 14114 notabug
close 14114
stop

James Jong <[email-masked]> writes:

> The following code does not work well on the builtin `tango-dark` theme:
>
>     (custom-set-faces
>      '(region ((t (:inherit nil :background "RoyalBlue4"))))
>      '(highlight ((t (:inherit region :background "dark olive green"))))
>      '(hl-line ((t (:inherit highlight)))))
>
> Region highlighting works well and respects foreground faces:

That's the region face, not the highlight face (for which tango-dark
sets a foreground color).

> Inline image 1
>
> but line highlighting doesn't:
>
> Inline image 2

I think that's to be expected, since the tango-dark theme sets a
foreground color for the highlight face:

   `(highlight ((,class (:foreground ,alum-6 :background ,butter-2))))

So I'm closing this ticket.

Cheers,
Nico

<#secure method=pgpmime mode=sign>