From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 28 16:07:16 2013 Received: (at submit) by debbugs.gnu.org; 28 Mar 2013 20:07:16 +0000 Received: from localhost ([127.0.0.1]:49956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ULJ6R-00080f-Td for submit@debbugs.gnu.org; Thu, 28 Mar 2013 16:07:16 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50637) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1ULJ6P-00080W-Oq for submit@debbugs.gnu.org; Thu, 28 Mar 2013 16:07:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULJ3u-0001ei-7b for submit@debbugs.gnu.org; Thu, 28 Mar 2013 16:04:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:50794) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULJ3u-0001ee-4T for submit@debbugs.gnu.org; Thu, 28 Mar 2013 16:04:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULJ3q-0003mI-HE for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2013 16:04:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ULJ3k-0001cD-Er for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2013 16:04:34 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:53970) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ULJ3k-0001by-8E for bug-gnu-emacs@gnu.org; Thu, 28 Mar 2013 16:04:28 -0400 Received: by mail-ee0-f46.google.com with SMTP id e49so4969681eek.19 for ; Thu, 28 Mar 2013 13:04:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=mL75IIkLW+YNOrO0//M3vqAfl1EAr+SmAOWQHxR5Yv0=; b=Q4Wo0L8/NFKwstLl57iFIYv//gypenMUVdhXKyWz4fhQhv2Ax5vUCJadnLM+CyfWmR XYmFxZoz++v/BaTY5lGy0PZdIm1j0h9B9s+HahEtNgP+AJ/mkcCoSGrVoKcbwiN/nDMC 9qshUKLcVXXCa2se8eDdo7tMIpJtBFoaG61Q3aIybPwGTjSiT3Ag7pClFlpFac+b1T0N cLGEma6bdYla6SuTKhJYB066GRJSA42y6zgKu6vWTaE+mZTqqyi5QA4RxfVD1q3ddor5 xj139aLqPjJCZ+XE3Nt4wvlhnDVnrtruSNcm8FujK5R2y45H1JhX4xZkV55SZbjJLG4D CndA== X-Received: by 10.15.36.67 with SMTP id h43mr69580991eev.5.1364501066853; Thu, 28 Mar 2013 13:04:26 -0700 (PDT) Received: from localhost.localdomain (93-77-145.netrun.cytanet.com.cy. [93.109.77.145]) by mx.google.com with ESMTPS id 44sm17023eek.5.2013.03.28.13.04.24 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 28 Mar 2013 13:04:25 -0700 (PDT) From: oblique To: bug-gnu-emacs@gnu.org Subject: [PATCH] Fix 256 color mapping in rxvt.el Date: Thu, 28 Mar 2013 22:02:43 +0200 Message-Id: <1364500963-3251-1-git-send-email-psyberbits@gmail.com> X-Mailer: git-send-email 1.8.1.5 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: submit Cc: oblique X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Color mapping was wrong, I use the same way xterm.el does it. --- lisp/term/rxvt.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/term/rxvt.el b/lisp/term/rxvt.el index 0e026a8..6a62cff 100644 --- a/lisp/term/rxvt.el +++ b/lisp/term/rxvt.el @@ -201,7 +201,7 @@ (defun rxvt-rgb-convert-to-16bit (prim) "Convert an 8-bit primary color value PRIM to a corresponding 16-bit value." - (min 65535 (round (* (/ prim 255.0) 65535.0)))) + (logior prim (lsh prim 8))) (defun rxvt-register-default-colors () "Register the default set of colors for rxvt or compatible emulator. @@ -233,9 +233,10 @@ for the currently selected frame." (tty-color-define (format "color-%d" (- 256 ncolors)) (- 256 ncolors) (mapcar 'rxvt-rgb-convert-to-16bit - (list (round (* r 42.5)) - (round (* g 42.5)) - (round (* b 42.5))))) + (list (if (zerop r) 0 (+ (* r 40) 55)) + (if (zerop g) 0 (+ (* g 40) 55)) + (if (zerop b) 0 (+ (* b 40) 55))))) + (setq b (1+ b)) (if (> b 5) (setq g (1+ g) -- 1.8.1.5 From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 17 11:04:22 2013 Received: (at 14078-done) by debbugs.gnu.org; 17 Dec 2013 16:04:22 +0000 Received: from localhost ([127.0.0.1]:55949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vsx89-0006BF-Lk for submit@debbugs.gnu.org; Tue, 17 Dec 2013 11:04:21 -0500 Received: from mail-pb0-f49.google.com ([209.85.160.49]:46738) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vsx87-0006B5-H8 for 14078-done@debbugs.gnu.org; Tue, 17 Dec 2013 11:04:20 -0500 Received: by mail-pb0-f49.google.com with SMTP id jt11so7152680pbb.36 for <14078-done@debbugs.gnu.org>; Tue, 17 Dec 2013 08:04:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=ZmSObXZzuUThCe+56tUyeqchn7n8SRWsH2J8JWpFX5Y=; b=O0sQZ3NnqJpRqXw1sALl4QgLwi1OmOH1e24csMMpRqLUchrPYoL2DWOxZYgoKdgKmD vz79+B5Qh2kA/STSnd4R9KlxJ1a+QE22hg52MEocMTY8kVPnFH94PKR4J3OuMPqFj1O0 1u2o1ucH79do9xgY/PQ2vykdlbZPR/v0UJLLwx0Zzul3HKNoJE14JkmnKpQAHF1zYcVE MvuaCTz/EzbRM2z2nOm47d7E1q99q+sq5x6QhoP7MSibjPbvv2Ey3Vu2DA1Iqx1GwSyM t6cngiVx9+QlaQtBKOplMkJljkaT8QIzrkdZJKvHjJJrC7mjG9koW3rvAebMTEjSog8k a++g== X-Received: by 10.66.243.4 with SMTP id wu4mr28240672pac.87.1387296258646; Tue, 17 Dec 2013 08:04:18 -0800 (PST) Received: from tsparkle ([155.69.2.31]) by mx.google.com with ESMTPSA id xv2sm34827633pbb.39.2013.12.17.08.04.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Dec 2013 08:04:17 -0800 (PST) From: Chong Yidong To: oblique Subject: Re: bug#14078: [PATCH] Fix 256 color mapping in rxvt.el References: <1364500963-3251-1-git-send-email-psyberbits@gmail.com> Date: Wed, 18 Dec 2013 00:04:16 +0800 In-Reply-To: <1364500963-3251-1-git-send-email-psyberbits@gmail.com> (oblique's message of "Thu, 28 Mar 2013 22:02:43 +0200") Message-ID: <871u1bv4zj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 14078-done Cc: 14078-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) oblique writes: > Color mapping was wrong, I use the same way xterm.el does it. Thanks, committed to trunk. From unknown Sun Jun 22 11:42:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 15 Jan 2014 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator