Subject: bug#14066: closed (Re: bug#14066: 24.3; vc-bzr-revert shouldn't create backup files)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 28 Mar 2013 03:32:01 +0000

Your bug report

#14066: 24.3; vc-bzr-revert shouldn't create backup files

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
14066: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14066
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#14066: 24.3; vc-bzr-revert shouldn't create backup files
From: Leo Liu <[email-masked]>
To: [email-masked]
Date: Thu, 28 Mar 2013 11:29:23 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Fixed in trunk

Subject: 24.3; vc-bzr-revert shouldn't create backup files
From: Leo Liu <[email-masked]>
To: [email-masked]
Date: Wed, 27 Mar 2013 23:36:53 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

According to vc-default-make-version-backups-p, no backup file is
created for the bzr backend. However 'bzr revert' itself creates backups
which is very confusing.

So I propose the following patch:

diff --git a/lisp/vc/vc-bzr.el b/lisp/vc/vc-bzr.el
index f436d300..c1195eee 100644
--- a/lisp/vc/vc-bzr.el
+++ b/lisp/vc/vc-bzr.el
@@ -644,7 +644,7 @@ (defun vc-bzr-checkout (_file &optional _editable rev)
 
 (defun vc-bzr-revert (file &optional contents-done)
   (unless contents-done
-    (with-temp-buffer (vc-bzr-command "revert" t 0 file))))
+    (with-temp-buffer (vc-bzr-command "revert" t 0 file "--no-backup"))))
 
 (defvar log-view-message-re)
 (defvar log-view-file-re)