From unknown Sun Aug 17 10:26:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#14066: 24.3; vc-bzr-revert shouldn't create backup files Resent-From: Leo Liu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Mar 2013 15:43:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 14066 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 14066@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13643989755173 (code B ref -1); Wed, 27 Mar 2013 15:43:03 +0000 Received: (at submit) by debbugs.gnu.org; 27 Mar 2013 15:42:55 +0000 Received: from localhost ([127.0.0.1]:47732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKsV0-0001LK-MA for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:42:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41354) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKsUu-0001Kx-Oo for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:42:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKsSU-00055W-3d for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:40:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:44877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsSU-000545-10 for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:40:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsPO-0001Dy-He for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:37:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKsPN-0003Vg-8P for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:37:02 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:42294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsPN-0003VZ-2B for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:37:01 -0400 Received: by mail-pd0-f171.google.com with SMTP id z10so1585083pdj.16 for ; Wed, 27 Mar 2013 08:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:mime-version :content-type; bh=pIKcrqgTei2IWet6dyn/WNfIHPDgTElRrFFUcVJplR4=; b=DBmkwHZx36YDTG/hyp1RQa5J+dvbGrIrpfWQSY2c1BC+xJ8yJsXnTkAqDLyZBiFPM9 +LqPxmKEatJAE/p46imT+Cxl6rEJMIUTcO3CPYxscyXQy1hWAIiUlbulc4EaB16gj2cE CygMF3ZLAgfJnaou8d+tLlrsl02S3Z4CnWqjPQBBwBugn17zd8Kx9TJttK32tjZ7GzFt Hg3D0V5B4r+h/kHg/BCdrxg35tDd3cv0es/WkxZTCZysvNTKGiyavXBBPrrt7wsCtsDp RIQei5WV6wR9BRPd3uD+pjE6j9+TP03gg5NUzr5k+YZeiHaasll6JGIh/Sxda/o3z9/E 9p6g== X-Received: by 10.68.180.193 with SMTP id dq1mr30292783pbc.67.1364398620199; Wed, 27 Mar 2013 08:37:00 -0700 (PDT) Received: from Zeuss-MacBook.local ([111.161.47.175]) by mx.google.com with ESMTPS id i10sm21902138pbd.1.2013.03.27.08.36.58 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 Mar 2013 08:36:59 -0700 (PDT) From: Leo Liu Date: Wed, 27 Mar 2013 23:36:53 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) According to vc-default-make-version-backups-p, no backup file is created for the bzr backend. However 'bzr revert' itself creates backups which is very confusing. So I propose the following patch: diff --git a/lisp/vc/vc-bzr.el b/lisp/vc/vc-bzr.el index f436d300..c1195eee 100644 --- a/lisp/vc/vc-bzr.el +++ b/lisp/vc/vc-bzr.el @@ -644,7 +644,7 @@ (defun vc-bzr-checkout (_file &optional _editable rev) (defun vc-bzr-revert (file &optional contents-done) (unless contents-done - (with-temp-buffer (vc-bzr-command "revert" t 0 file)))) + (with-temp-buffer (vc-bzr-command "revert" t 0 file "--no-backup")))) (defvar log-view-message-re) (defvar log-view-file-re) From unknown Sun Aug 17 10:26:01 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Liu Subject: bug#14066: closed (Re: bug#14066: 24.3; vc-bzr-revert shouldn't create backup files) Message-ID: References: X-Gnu-PR-Message: they-closed 14066 X-Gnu-PR-Package: emacs Reply-To: 14066@debbugs.gnu.org Date: Thu, 28 Mar 2013 03:32:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1364441521-25156-1" This is a multi-part message in MIME format... ------------=_1364441521-25156-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #14066: 24.3; vc-bzr-revert shouldn't create backup files which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 14066@debbugs.gnu.org. --=20 14066: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D14066 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1364441521-25156-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 14066-done) by debbugs.gnu.org; 28 Mar 2013 03:31:47 +0000 Received: from localhost ([127.0.0.1]:48645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UL3Z4-0006XI-UT for submit@debbugs.gnu.org; Wed, 27 Mar 2013 23:31:47 -0400 Received: from mail-pd0-f176.google.com ([209.85.192.176]:47054) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UL3Z2-0006X9-BS for 14066-done@debbugs.gnu.org; Wed, 27 Mar 2013 23:31:45 -0400 Received: by mail-pd0-f176.google.com with SMTP id r11so1311827pdi.21 for <14066-done@debbugs.gnu.org>; Wed, 27 Mar 2013 20:29:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=u2sA59cUaGeFOOKo40Z0kQjtJAmt1sWRi8g9u8fca3o=; b=M4o9Mo5l0pyWM0F6sWpKfuzgodZ+91lctFWtOFLyzJCan1qfRKlwb+3gSQMuUqeCRk 45FBl4qpjdjckHROrlHhWM/QjkzTFPCOV9kgzk9476gshzNdpPE1SdLtTC/AICMgylRx E0ImkTcx4C0iphI0yJmtkoivXQLpZcUO4X9Wn5oxwN+kcGehYbX7OKK7tUO5jGZ2PWDn q1dk6xjHMoAgXvUY5TnfJNkvxMvTPVC5YSX2wamJ5eZ9bUuIlWJxhccMfmGPce4vXXey R1WcEkYljOa1M4XSsixOCmTCB9Ek8Ya0lSDxTf4JVdwVH1yFC6/0hRd//geGyasx3DDZ Z3zQ== X-Received: by 10.68.91.66 with SMTP id cc2mr33424687pbb.51.1364441355329; Wed, 27 Mar 2013 20:29:15 -0700 (PDT) Received: from Zeuss-MacBook.local ([111.161.47.175]) by mx.google.com with ESMTPS id ql7sm23754603pbb.2.2013.03.27.20.29.13 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 Mar 2013 20:29:14 -0700 (PDT) From: Leo Liu To: 14066-done@debbugs.gnu.org Subject: Re: bug#14066: 24.3; vc-bzr-revert shouldn't create backup files References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoAgMAAADxkFD+AAAADFBMVEUvT09qWs3/pQD///+J kUVcAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMLOd3veKQA AACuSURBVBjTldE9CgIxEAXgB+lEyFUC2wo5ikdZ8DSypxhMY7H9VuIVwlqkGRgnm59VsHGafIQ3 CZlAtmKIRaHETgYa12lqvEsPYKf8wXHsPGfqPaUM0g9aJPKFXkmNQmSDqwzz4Fpgpz+6WAPY2z5o uPJJpu0uypcl4nyCibMLQ8lCiVjayLoQvw5LsVKQuHPRR958HZbOcVsKeepcLxpByjycGvnKmY+c MBvrtyjfe0vmuLvdq/kAAAAASUVORK5CYII= Date: Thu, 28 Mar 2013 11:29:23 +0800 In-Reply-To: (Leo Liu's message of "Wed, 27 Mar 2013 23:36:53 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 14066-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) Fixed in trunk ------------=_1364441521-25156-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Mar 2013 15:42:55 +0000 Received: from localhost ([127.0.0.1]:47732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKsV0-0001LK-MA for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:42:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41354) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKsUu-0001Kx-Oo for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:42:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKsSU-00055W-3d for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:40:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:44877) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsSU-000545-10 for submit@debbugs.gnu.org; Wed, 27 Mar 2013 11:40:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51577) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsPO-0001Dy-He for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:37:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKsPN-0003Vg-8P for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:37:02 -0400 Received: from mail-pd0-f171.google.com ([209.85.192.171]:42294) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKsPN-0003VZ-2B for bug-gnu-emacs@gnu.org; Wed, 27 Mar 2013 11:37:01 -0400 Received: by mail-pd0-f171.google.com with SMTP id z10so1585083pdj.16 for ; Wed, 27 Mar 2013 08:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:date:message-id:mime-version :content-type; bh=pIKcrqgTei2IWet6dyn/WNfIHPDgTElRrFFUcVJplR4=; b=DBmkwHZx36YDTG/hyp1RQa5J+dvbGrIrpfWQSY2c1BC+xJ8yJsXnTkAqDLyZBiFPM9 +LqPxmKEatJAE/p46imT+Cxl6rEJMIUTcO3CPYxscyXQy1hWAIiUlbulc4EaB16gj2cE CygMF3ZLAgfJnaou8d+tLlrsl02S3Z4CnWqjPQBBwBugn17zd8Kx9TJttK32tjZ7GzFt Hg3D0V5B4r+h/kHg/BCdrxg35tDd3cv0es/WkxZTCZysvNTKGiyavXBBPrrt7wsCtsDp RIQei5WV6wR9BRPd3uD+pjE6j9+TP03gg5NUzr5k+YZeiHaasll6JGIh/Sxda/o3z9/E 9p6g== X-Received: by 10.68.180.193 with SMTP id dq1mr30292783pbc.67.1364398620199; Wed, 27 Mar 2013 08:37:00 -0700 (PDT) Received: from Zeuss-MacBook.local ([111.161.47.175]) by mx.google.com with ESMTPS id i10sm21902138pbd.1.2013.03.27.08.36.58 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 27 Mar 2013 08:36:59 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.3; vc-bzr-revert shouldn't create backup files Date: Wed, 27 Mar 2013 23:36:53 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) According to vc-default-make-version-backups-p, no backup file is created for the bzr backend. However 'bzr revert' itself creates backups which is very confusing. So I propose the following patch: diff --git a/lisp/vc/vc-bzr.el b/lisp/vc/vc-bzr.el index f436d300..c1195eee 100644 --- a/lisp/vc/vc-bzr.el +++ b/lisp/vc/vc-bzr.el @@ -644,7 +644,7 @@ (defun vc-bzr-checkout (_file &optional _editable rev) (defun vc-bzr-revert (file &optional contents-done) (unless contents-done - (with-temp-buffer (vc-bzr-command "revert" t 0 file)))) + (with-temp-buffer (vc-bzr-command "revert" t 0 file "--no-backup")))) (defvar log-view-message-re) (defvar log-view-file-re) ------------=_1364441521-25156-1--