From unknown Tue Jun 17 20:28:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#14052 <14052@debbugs.gnu.org> To: bug#14052 <14052@debbugs.gnu.org> Subject: Status: 24.3; [PATCH] Cleanup for register.el Reply-To: bug#14052 <14052@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:28:49 +0000 retitle 14052 24.3; [PATCH] Cleanup for register.el reassign 14052 emacs submitter 14052 Leo Liu severity 14052 normal tag 14052 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 11:43:51 2013 Received: (at submit) by debbugs.gnu.org; 25 Mar 2013 15:43:51 +0000 Received: from localhost ([127.0.0.1]:44912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UK9Ys-0001Ci-By for submit@debbugs.gnu.org; Mon, 25 Mar 2013 11:43:50 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34907) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UK9Yp-0001Cb-GL for submit@debbugs.gnu.org; Mon, 25 Mar 2013 11:43:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UK9WZ-0007Ps-A8 for submit@debbugs.gnu.org; Mon, 25 Mar 2013 11:41:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-102.6 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, T_DKIM_INVALID, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:42965) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK9WZ-0007Po-7W for submit@debbugs.gnu.org; Mon, 25 Mar 2013 11:41:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46232) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK9WU-0007F3-7S for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2013 11:41:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UK9WS-0007OC-Mw for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2013 11:41:22 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:38938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK9WS-0007O1-Gd for bug-gnu-emacs@gnu.org; Mon, 25 Mar 2013 11:41:20 -0400 Received: by mail-pa0-f46.google.com with SMTP id wp1so1102191pac.19 for ; Mon, 25 Mar 2013 08:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=1hOzAyxy+cXGxy0GP5rfHhiHOFpcDSzm5HLFMBOv5T8=; b=vIfOvAZZfHICJXntys1sGiBU8H2Of7Oo6IZwwsoxqyEYFd5W0PT/D5zL6Wsbg6cFTU Axh5pcMgnqu4C5tYrHHxZRGt02g7QT0wzHQTgvOqLJtHlf0OI8edN8MWs8FJDHVWX12E sUGQ1rg/Xjr6SK6BmGxk1dScD3Ki4fS4behSn36gSpJMCTE+4JXP6Tszi0cQ3erZBJtb oHpXgyqnEuixRV1dA4kwSPRh9okUPne2Gpn1M5xsAkRTsl9TZaEBkJAlq9hxFYDz4fAN XwOJqJS/7LIBGLB9lSTLvCmH+8GPXes9dGSsWw3WcXydHJqftblIDTFwJKVM6nljCls1 GqTA== X-Received: by 10.68.189.42 with SMTP id gf10mr18118385pbc.149.1364226079238; Mon, 25 Mar 2013 08:41:19 -0700 (PDT) Received: from Zeuss-MacBook.local ([111.161.47.175]) by mx.google.com with ESMTPS id vd4sm13830793pbc.35.2013.03.25.08.41.15 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 25 Mar 2013 08:41:18 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.3; [PATCH] Cleanup for register.el X-Debbugs-CC: David Engster Date: Mon, 25 Mar 2013 23:41:09 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) I would like to install the following cleanup for register.el. David, could you help check the change to senator.el? Thanks. Leo diff --git a/lisp/cedet/semantic/senator.el b/lisp/cedet/semantic/senator.el index a79e70a7..157223ff 100644 --- a/lisp/cedet/semantic/senator.el +++ b/lisp/cedet/semantic/senator.el @@ -727,7 +727,13 @@ (defun senator-copy-tag-to-register (register &optional kill-flag) (semantic-fetch-tags) (let ((ft (semantic-obtain-foreign-tag))) (when ft - (set-register register ft) + (set-register + register (registerv-make + ft + :insert-func #'semantic-insert-foreign-tag + :jump-func (lambda (v) + (switch-to-buffer (semantic-tag-buffer v)) + (goto-char (semantic-tag-start v))))) (if kill-flag (kill-region (semantic-tag-start ft) (semantic-tag-end ft)))))) diff --git a/lisp/register.el b/lisp/register.el index ae2f7cf3..4876c614 100644 --- a/lisp/register.el +++ b/lisp/register.el @@ -31,10 +31,6 @@ (eval-when-compile (require 'cl-lib)) -(declare-function semantic-insert-foreign-tag "semantic/tag" (foreign-tag)) -(declare-function semantic-tag-buffer "semantic/tag" (tag)) -(declare-function semantic-tag-start "semantic/tag" (tag)) - ;;; Code: (cl-defstruct @@ -174,11 +170,6 @@ (defun jump-to-register (register &optional delete) (error "Register access aborted")) (find-file (nth 1 val)) (goto-char (nth 2 val))) - ((and (fboundp 'semantic-foreign-tag-p) - semantic-mode - (semantic-foreign-tag-p val)) - (switch-to-buffer (semantic-tag-buffer val)) - (goto-char (semantic-tag-start val))) (t (error "Register doesn't contain a buffer position or configuration"))))) @@ -349,10 +340,6 @@ (defun insert-register (register &optional arg) (princ val (current-buffer))) ((and (markerp val) (marker-position val)) (princ (marker-position val) (current-buffer))) - ((and (fboundp 'semantic-foreign-tag-p) - semantic-mode - (semantic-foreign-tag-p val)) - (semantic-insert-foreign-tag val)) (t (error "Register does not contain text")))) (if (not arg) (exchange-point-and-mark))) From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 15:06:49 2013 Received: (at 14052) by debbugs.gnu.org; 25 Mar 2013 19:06:49 +0000 Received: from localhost ([127.0.0.1]:45034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKCjJ-0007Vx-9g for submit@debbugs.gnu.org; Mon, 25 Mar 2013 15:06:49 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:14690) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKCjG-0007Vq-TW for 14052@debbugs.gnu.org; Mon, 25 Mar 2013 15:06:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: At0KABK/CFFFxLSu/2dsb2JhbABEvg0EAnsXc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IPAS-Result: At0KABK/CFFFxLSu/2dsb2JhbABEvg0EAnsXc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="5745621" Received: from 69-196-180-174.dsl.teksavvy.com (HELO pastel.home) ([69.196.180.174]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 25 Mar 2013 15:04:29 -0400 Received: by pastel.home (Postfix, from userid 20848) id 6FAB667AC0; Mon, 25 Mar 2013 15:04:31 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#14052: 24.3; [PATCH] Cleanup for register.el Message-ID: References: Date: Mon, 25 Mar 2013 15:04:31 -0400 In-Reply-To: (Leo Liu's message of "Mon, 25 Mar 2013 23:41:09 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 14052 Cc: 14052@debbugs.gnu.org, David Engster X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > I would like to install the following cleanup for register.el. Looks good to me, thank you (assuming the CEDET guys can deal with the compatibility issues). Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 17:18:15 2013 Received: (at 14052) by debbugs.gnu.org; 25 Mar 2013 21:18:15 +0000 Received: from localhost ([127.0.0.1]:45088 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKEmV-0002eX-31 for submit@debbugs.gnu.org; Mon, 25 Mar 2013 17:18:15 -0400 Received: from randomsample.de ([83.169.19.17]:39697) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKEmQ-0002eL-39 for 14052@debbugs.gnu.org; Mon, 25 Mar 2013 17:18:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=z11cL1Eww1HvI/0s53d4mbWG6F3q5R6s1hANjEtIN7g=; b=McVxa/jDL6ShOlLqrC5Ih5z2874c766vUfX5Hty4tiph/Izut3nWaBiRU8op1qEeVq09DfYdmalvEaMDseFI39htPWiYeJ8M9fPilJuj+/rZrudOA5D1kFPuyy44LF7M; Received: from dslc-082-082-166-130.pools.arcor-ip.net ([82.82.166.130] helo=spaten) by randomsample.de with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UKEkC-00038N-8f; Mon, 25 Mar 2013 22:15:52 +0100 From: David Engster To: Stefan Monnier Subject: Re: bug#14052: 24.3; [PATCH] Cleanup for register.el In-Reply-To: (Stefan Monnier's message of "Mon, 25 Mar 2013 15:04:31 -0400") References: User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (gnu/linux) Date: Mon, 25 Mar 2013 22:15:51 +0100 Message-ID: <87mwtr9o54.fsf@engster.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 14052 Cc: 14052@debbugs.gnu.org, Leo Liu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) Stefan Monnier writes: >> I would like to install the following cleanup for register.el. > > Looks good to me, thank you (assuming the CEDET guys can deal with the > compatibility issues). Since which version is registerv-make supported? I couldn't find anything in NEWS. Well, I guess we would have to advice jump-to-register and insert-register on older Emacsen... But I can understand why you want to get rid of those Semantic things in register.el, so go ahead and thanks for the heads up. -David From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 17:32:54 2013 Received: (at 14052) by debbugs.gnu.org; 25 Mar 2013 21:32:54 +0000 Received: from localhost ([127.0.0.1]:45126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKF0e-00032D-UQ for submit@debbugs.gnu.org; Mon, 25 Mar 2013 17:32:54 -0400 Received: from randomsample.de ([83.169.19.17]:49058) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKF0c-000325-Qo for 14052@debbugs.gnu.org; Mon, 25 Mar 2013 17:32:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=randomsample.de; s=a; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From; bh=fyQob+77GjaOfBkMoKndR3oWuBL8EJwZOIyfMo1UZ8c=; b=Bcd/tfm9ABDLBGaqus/goQABJRlXh7ilq2bbagkf1+3vAjYlI0PAr4e14n3UG1Iu4eYoIEbze66PEzYYmEZT9h7Ooesk26K1tBRXfEMQnbUqGnRmXQxJHVo7SKx+1Oo9; Received: from dslc-082-082-166-130.pools.arcor-ip.net ([82.82.166.130] helo=spaten) by randomsample.de with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1UKEyQ-0003X4-LC; Mon, 25 Mar 2013 22:30:34 +0100 From: David Engster To: Stefan Monnier Subject: Re: bug#14052: 24.3; [PATCH] Cleanup for register.el In-Reply-To: <87mwtr9o54.fsf@engster.org> (David Engster's message of "Mon, 25 Mar 2013 22:15:51 +0100") References: <87mwtr9o54.fsf@engster.org> User-Agent: Gnus/5.130006 (Ma Gnus v0.6) Emacs/24.3 (gnu/linux) Date: Mon, 25 Mar 2013 22:30:34 +0100 Message-ID: <87ip4f9ngl.fsf@engster.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 14052 Cc: 14052@debbugs.gnu.org, Leo Liu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) David Engster writes: > Well, I guess we would have to advice jump-to-register and > insert-register on older Emacsen... Sorry, I was confused. We won't have to advice anything, of course, so please go ahead and install it. -David From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 25 22:56:34 2013 Received: (at 14052-done) by debbugs.gnu.org; 26 Mar 2013 02:56:34 +0000 Received: from localhost ([127.0.0.1]:45362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKK3q-0002rv-8g for submit@debbugs.gnu.org; Mon, 25 Mar 2013 22:56:31 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:51767) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UKK3m-0002rm-IO for 14052-done@debbugs.gnu.org; Mon, 25 Mar 2013 22:56:28 -0400 Received: by mail-pa0-f50.google.com with SMTP id bg2so1361845pad.37 for <14052-done@debbugs.gnu.org>; Mon, 25 Mar 2013 19:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=zzyLBX6+mCuLjTg+VFFVlSpDFAuMnmTUvhPyAMrVpYU=; b=UKMY4Nulucxa9896Rrup0pNdKAGOg6d9Hb3jPIzyLxTSVl9K54ai2aPIlGl5FVkidn kZQa8jtsroSkWn16RrgzW7cW62oH078kNc7dxFl56brUSgwQtAtnSg4mk+U1woaqVct1 WDF1hW9hhjPD20wLySIwtDVrR2bfcLFm4dNmYWg904jLMB0pnfKSHDncHQoVZ0m0WNke r8pdH/A1uOXoyhLc1S+jFathNEY1+iH6q0wgRweYJGjtQ0SJa/DowIJ5Mm+YMXdEvr7Z rIjbQRow5za2/1p7WesaXtHSX7ykstUE2bDaf8zOrBRMsbnMYFxjx/cmIgFgl608dRto 80zA== X-Received: by 10.68.20.8 with SMTP id j8mr21065396pbe.15.1364266448983; Mon, 25 Mar 2013 19:54:08 -0700 (PDT) Received: from Zeuss-MacBook.local ([111.161.47.175]) by mx.google.com with ESMTPS id yp2sm4765018pab.10.2013.03.25.19.54.05 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 25 Mar 2013 19:54:08 -0700 (PDT) From: Leo Liu To: David Engster Subject: Re: bug#14052: 24.3; [PATCH] Cleanup for register.el References: <87mwtr9o54.fsf@engster.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= Date: Tue, 26 Mar 2013 10:54:01 +0800 In-Reply-To: <87mwtr9o54.fsf@engster.org> (David Engster's message of "Mon, 25 Mar 2013 22:15:51 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 14052-done Cc: Stefan Monnier , 14052-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Fixed in trunk. On 2013-03-26 05:15 +0800, David Engster wrote: > Since which version is registerv-make supported? I couldn't find > anything in NEWS. It was added on 26 Jun 2011. I am not sure if it is in 23.4 release but definitely in 24.x releases. Thanks. Leo From unknown Tue Jun 17 20:28:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 23 Apr 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator