GNU bug report logs -
#14041
XTring_bell() does not work in some Linux distributions
Previous Next
Reported by: PV <frerot13 <at> gmail.com>
Date: Sat, 23 Mar 2013 15:55:01 UTC
Severity: normal
Merged with 14048
Done: Jan Djärv <jan.h.d <at> swipnet.se>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
[Message part 1 (text/plain, inline)]
Your bug report
#14041: XTring_bell() does not work in some Linux distributions
which was filed against the emacs package, has been closed.
The explanation is attached below, along with your original report.
If you require more details, please reply to 14041 <at> debbugs.gnu.org.
--
14041: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14041
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
Hello.
This has been fixed in the trunk in another way.
Jan D.
23 mar 2013 kl. 11:38 skrev PV <frerot13 <at> gmail.com>:
> Hi,
>
> In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
> Windowing system distributor `The X.Org Foundation', version 11.0.10707000
>
> The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
> but the function gdk_beep() is not,
> thus I suggest to modify XTring_bell () in xterm.c in the following way:
>
>
> /* Make audible bell. */
>
> void
> XTring_bell ()
> {
> struct frame *f = SELECTED_FRAME ();
>
> if (FRAME_X_DISPLAY (f))
> {
> #if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
> if (visible_bell)
> XTflash (f);
> else
> #endif
> {
> BLOCK_INPUT;
> #ifdef USE_GTK // P.VINCENT
> gdk_beep (); // P.VINCENT
> #else // P.VINCENT
> XBell (FRAME_X_DISPLAY (f), 0);
> XFlush (FRAME_X_DISPLAY (f));
> #endif // P.VINCENT
> UNBLOCK_INPUT;
> }
> }
> }
>
> Best regards,
> Patrick VINCENT
>
>
[Message part 3 (message/rfc822, inline)]
Hi,
In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
Windowing system distributor `The X.Org Foundation', version 11.0.10707000
The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
but the function gdk_beep() is not,
thus I suggest to modify XTring_bell () in xterm.c in the following way:
/* Make audible bell. */
void
XTring_bell ()
{
struct frame *f = SELECTED_FRAME ();
if (FRAME_X_DISPLAY (f))
{
#if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
if (visible_bell)
XTflash (f);
else
#endif
{
BLOCK_INPUT;
#ifdef USE_GTK // P.VINCENT
gdk_beep (); // P.VINCENT
#else // P.VINCENT
XBell (FRAME_X_DISPLAY (f), 0);
XFlush (FRAME_X_DISPLAY (f));
#endif // P.VINCENT
UNBLOCK_INPUT;
}
}
}
Best regards,
Patrick VINCENT
This bug report was last modified 12 years and 58 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.