Subject: bug#14041: XTring_bell() does not work in some Linux distributions

From: Petr Hracek <[email-masked]>
Date: Tue, 26 Mar 2013 14:07:22 +0100

Hello Jan,

we have already emacs version 24.2 in which that patch included
especially function XTring_bell() (xterm.c) in another way.
What is a bug number for that case?

Where there any another files modified?

best regards
Petr

On 03/25/2013 07:01 PM, Jan Djärv wrote:
> Hello.
>
> This has been fixed in the trunk in another way.
>
> 	Jan D.
>
> 23 mar 2013 kl. 11:38 skrev PV <[email-masked]>:
>
>> Hi,
>>
>> In GNU Emacs 23.4.2 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1)
>> Windowing system distributor `The X.Org Foundation', version 11.0.10707000
>>
>> The X11 function XBell is affected by this bug (e.g. in the Debian 6 Squeeze)
>> but the function gdk_beep() is not,
>> thus I suggest to modify XTring_bell () in xterm.c in the following way:
>>
>>
>> /* Make audible bell.  */
>>
>> void
>> XTring_bell ()
>> {
>>   struct frame *f = SELECTED_FRAME ();
>>
>>   if (FRAME_X_DISPLAY (f))
>>     {
>> #if defined (HAVE_TIMEVAL) && defined (HAVE_SELECT)
>>       if (visible_bell)
>> 	XTflash (f);
>>       else
>> #endif
>> 	{
>> 	  BLOCK_INPUT;
>> #ifdef USE_GTK           	     // P.VINCENT
>> 	  gdk_beep ();   	     // P.VINCENT
>> #else			 	     // P.VINCENT
>> 	  XBell (FRAME_X_DISPLAY (f), 0);
>> 	  XFlush (FRAME_X_DISPLAY (f));
>> #endif                   	     // P.VINCENT
>> 	  UNBLOCK_INPUT;
>> 	}
>>     }
>> }
>>
>> Best regards,
>> Patrick VINCENT
>>
>>
>
>
>

-- 
S pozdravem / Best regards

Petr Hracek

Red Hat Czech s.r.o.
BaseOS Core Services Brno

Email: [email-masked]
Web: www.cz.redhat.com