GNU bug report logs - #14019
conditional tests and parallel test harness

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 14019 in the body.
You can then email your comments to 14019 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sven Verdoolaege <skimo <at> kotnet.org>
To: bug-automake <at> gnu.org
Subject: conditional tests and parallel test harness
Date: Wed, 20 Mar 2013 17:10:13 +0100

[Message part 1 (text/plain, inline)]

The parallel test harness doesn't seem to like conditional tests.

I get the following output using the attached configure.ac and Makefile.am:

    $ ./configure 
    checking for a BSD-compatible install... /usr/bin/install -c
    checking whether build environment is sane... yes
    checking for a thread-safe mkdir -p... /bin/mkdir -p
    checking for gawk... gawk
    checking whether make sets $(MAKE)... yes
    checking whether make supports nested variables... yes
    checking that generated files are newer than configure... done
    configure: creating ./config.status
    config.status: creating Makefile
    config.status: creating pet_test.sh
    $ make check
    make  check-TESTS
    make[1]: Entering directory `/tmp/pet-0.03'
    make[2]: Entering directory `/tmp/pet-0.03'
    make[3]: Entering directory `/tmp/pet-0.03'
    make[3]: Nothing to be done for `pet_test.sh.log'.
    make[3]: Leaving directory `/tmp/pet-0.03'
    fatal: making test-suite.log: failed to create pet_test.sh.trs
    fatal: making test-suite.log: failed to create pet_test.sh.log
    make[2]: *** [test-suite.log] Error 1
    make[2]: Leaving directory `/tmp/pet-0.03'
    make[1]: *** [check-TESTS] Error 2
    make[1]: Leaving directory `/tmp/pet-0.03'
    make: *** [check-am] Error 2

This is with automake 1.13.1 and autoconf 2.68.
The same input works fine with automake 1.11.3:

    $ ./configure 
    checking for a BSD-compatible install... /usr/bin/install -c
    checking whether build environment is sane... yes
    checking for a thread-safe mkdir -p... /bin/mkdir -p
    checking for gawk... gawk
    checking whether make sets $(MAKE)... yes
    configure: creating ./config.status
    config.status: creating Makefile
    config.status: creating pet_test.sh
    $ make check
    make  check-TESTS
    make[1]: Entering directory `/tmp/pet-0.03'
    PASS: pet_test.sh
    =============
    1 test passed
    =============
    make[1]: Leaving directory `/tmp/pet-0.03'

Is it no longer allowed to have conditional tests as in

    TESTS = @extra_tests@
    EXTRA_TESTS = pet_test.sh

or is anything missing from my input?

Thanks in advance,

skimo

[configure.ac (text/plain, attachment)]

[Makefile.am (text/plain, attachment)]

[pet_test.sh.in (text/plain, attachment)]

Message #8 received at 14019 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Sven Verdoolaege <skimo <at> kotnet.org>
Cc: 14019 <at> debbugs.gnu.org
Subject: Re: bug#14019: conditional tests and parallel test harness
Date: Sat, 20 Apr 2013 21:17:24 +0200

severity 14019 minor
thanks

Hi Sven, sorry for the shameful delay.

On 03/20/2013 05:10 PM, Sven Verdoolaege wrote:
> The parallel test harness doesn't seem to like conditional tests.
>
Not if they don't have extensions declared with TEST_EXTENSIONS.  This is
just a limitation you'll have to live with, sorry (it's not a burdensome
one IMHO).

OTOH, I don't see this limitation documented anywhere in the manual, which
is not very user-friendly, and certainly explains your confusion.  I'm thus
not closing this report, since I plan to address this shortcoming sooner or
later.  In the meantime, suggestions about where to place such advice and
how to formulate it would be very welcome.

>
> [SNIP]
> 
> Is it no longer allowed to have conditional tests as in
> 
>     TESTS = @extra_tests@
>     EXTRA_TESTS = pet_test.sh
> 
> or is anything missing from my input?
>
If you add "TEST_EXTENSIONS = .sh", everything should work again.
Can you confirm this is the case?

> Thanks in advance,
> 
> skimo

Best regards, and HTH (albeit belatedly),
  Stefano

Message #13 received at 14019 <at> debbugs.gnu.org (full text, mbox):

From: Sven Verdoolaege <skimo <at> kotnet.org>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Cc: 14019 <at> debbugs.gnu.org
Subject: Re: bug#14019: conditional tests and parallel test harness
Date: Sun, 21 Apr 2013 13:08:40 +0200

On Sat, Apr 20, 2013 at 09:17:24PM +0200, Stefano Lattarini wrote:
> On 03/20/2013 05:10 PM, Sven Verdoolaege wrote:
> > Is it no longer allowed to have conditional tests as in
> > 
> >     TESTS = @extra_tests@
> >     EXTRA_TESTS = pet_test.sh
> > 
> > or is anything missing from my input?
> >
> If you add "TEST_EXTENSIONS = .sh", everything should work again.
> Can you confirm this is the case?

Thanks.  That fixes the problem.

skimo

Message #16 received at 14019 <at> debbugs.gnu.org (full text, mbox):

From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
To: Sven Verdoolaege <skimo <at> kotnet.org>
Cc: 14019 <at> debbugs.gnu.org,
	"automake-patches <at> gnu.org" <automake-patches <at> gnu.org>
Subject: Re: bug#14019: conditional tests and parallel test harness
Date: Thu, 25 Apr 2013 21:09:27 +0200

tags 14019 + patch
close 14019
stop

On 04/21/2013 01:08 PM, Sven Verdoolaege wrote:
> On Sat, Apr 20, 2013 at 09:17:24PM +0200, Stefano Lattarini wrote:
>> On 03/20/2013 05:10 PM, Sven Verdoolaege wrote:
>>> Is it no longer allowed to have conditional tests as in
>>>
>>>     TESTS = @extra_tests@
>>>     EXTRA_TESTS = pet_test.sh
>>>
>>> or is anything missing from my input?
>>>
>> If you add "TEST_EXTENSIONS = .sh", everything should work again.
>> Can you confirm this is the case?
> 
> Thanks.  That fixes the problem.
> 
Thanks for confirming.  And the patch below fixes the documentation
issue.  I'm thus closing this report.

Regards,
  Stefano

---- 8< ---- 8<---- 8<---- 8<---- 8<---- 8<---- 8<---- 8<---- 8<---- 8< ----

From 915bf025b0fcc35e19648126da66f12d68cf2633 Mon Sep 17 00:00:00 2001
Message-Id: <915bf025b0fcc35e19648126da66f12d68cf2633.1366916929.git.stefano.lattarini <at> gmail.com>
From: Stefano Lattarini <stefano.lattarini <at> gmail.com>
Date: Thu, 25 Apr 2013 21:03:40 +0200
Subject: [PATCH] docs: issues with configure substitutions in TESTS

Motivated by automake bug#14019.

* doc/automake.texi: Currently, when the parallel test harness is in use,
configure substitutions in TESTS definitions can only work if they expand
to tests that ends with a suffix listed in TEST_EXTENSIONS.  Document this
limitation.

Signed-off-by: Stefano Lattarini <stefano.lattarini <at> gmail.com>
---
 doc/automake.texi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/doc/automake.texi b/doc/automake.texi
index d420d28..f7a0a28 100644
--- a/doc/automake.texi
+++ b/doc/automake.texi
@@ -9099,6 +9099,12 @@ followed by any number of alphabetic characters.
 For example, @samp{.sh}, @samp{.T} and @samp{.t1} are valid extensions,
 while @samp{.x-y}, @samp{.6c} and @samp{.t.1} are not.

+@cindex Configure substitutions in @code{TESTS}
+It is important to note that, due to current limitations (unlikely to be
+lifted), configure substitutions in the definition of @code{TESTS} can
+only work if they will expand to a list of tests that have a suffix listed
+in @code{TEST_EXTENSIONS}.
+
 @vindex _LOG_COMPILE
 @vindex _LOG_COMPILER
 @vindex _LOG_FLAGS
-- 
1.8.2.1.610.g562af5b

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.