GNU bug report logs - #14013
24.3.50; dired-isearch-filenames-regexp is matching text outside filenames

Previous Next

Full log

Message #222 received at 14013 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: Michael Heerdegen <michael_heerdegen <at> web.de>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 14013 <at> debbugs.gnu.org
Subject: Re: bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching
 text outside filenames
Date: Fri, 02 Jun 2023 09:28:39 +0300

>> -  (remove-function (local 'isearch-filter-predicate)
>> -                   #'wdired-isearch-filter-read-only)
>> +  (when wdired-search-replace-filenames
>> +    (remove-function (local 'isearch-search-fun-function)
>> +                     #'dired-isearch-search-filenames)
>> +    (kill-local-variable 'replace-search-function)
>> +    (kill-local-variable 'replace-re-search-function))
>
> Juri, when a user disables `wdired-search-replace-filenames' while still
> in wdired-mode, won't we fail to undo these settings when the user
> then returns to normal dired? - should we not better undo these things
> unconditionally?

If these calls are idempotent, we could remove the condition.
Could you please confirm there is no adverse effect after removing this.

Also there is another call at the end that can't be removed:

  (add-hook 'isearch-mode-hook #'dired-isearch-filenames-setup nil t)

> Second question: could we advice (local 'replace-search-function) and
> (local 'replace-re-search-function) instead of replacing the value (it
> might be nicer to users of other packages)?

This looks nicer in theory.  But in practice I expect to see a lot of
conflicts.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.