GNU bug report logs - #14013
24.3.50; dired-isearch-filenames-regexp is matching text outside filenames

Previous Next

Full log

Message #219 received at 14013 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Juri Linkov <juri <at> jurta.org>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 14013 <at> debbugs.gnu.org
Subject: Re: bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching
 text outside filenames
Date: Fri, 02 Jun 2023 03:34:37 +0200

Juri Linkov <juri <at> jurta.org> writes:

> -  (remove-function (local 'isearch-filter-predicate)
> -                   #'wdired-isearch-filter-read-only)
> +  (when wdired-search-replace-filenames
> +    (remove-function (local 'isearch-search-fun-function)
> +                     #'dired-isearch-search-filenames)
> +    (kill-local-variable 'replace-search-function)
> +    (kill-local-variable 'replace-re-search-function))

Juri, when a user disables `wdired-search-replace-filenames' while still
in wdired-mode, won't we fail to undo these settings when the user
then returns to normal dired? - should we not better undo these things
unconditionally?

Second question: could we advice (local 'replace-search-function) and
(local 'replace-re-search-function) instead of replacing the value (it
might be nicer to users of other packages)?

TIA,

Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.