From unknown Tue Jun 24 20:54:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13992: 24.3; New command compilation-display-error Resent-From: Leo Liu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Mar 2013 13:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 13992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 13992@debbugs.gnu.org Cc: Stefan Monnier X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Stefan Monnier Received: via spool by submit@debbugs.gnu.org id=B.136361175115866 (code B ref -1); Mon, 18 Mar 2013 13:03:02 +0000 Received: (at submit) by debbugs.gnu.org; 18 Mar 2013 13:02:31 +0000 Received: from localhost ([127.0.0.1]:32864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHZht-00047o-Bu for submit@debbugs.gnu.org; Mon, 18 Mar 2013 09:02:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46884) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHZhn-00047X-B4 for submit@debbugs.gnu.org; Mon, 18 Mar 2013 09:02:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHZg6-0005ix-C4 for submit@debbugs.gnu.org; Mon, 18 Mar 2013 09:00:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHZg6-0005it-86 for submit@debbugs.gnu.org; Mon, 18 Mar 2013 09:00:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHZg0-00071r-2l for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2013 09:00:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHZfp-0005ab-EX for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2013 09:00:32 -0400 Received: from mail-da0-x230.google.com ([2607:f8b0:400e:c00::230]:63700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHZfp-0005ZB-98 for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2013 09:00:21 -0400 Received: by mail-da0-f48.google.com with SMTP id p8so491417dan.35 for ; Mon, 18 Mar 2013 06:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=kQ7VLCcXX7bMNVGdN94ihbcnlKC4S9Q3+P8dOW6fAMU=; b=GmTJwFwPoL+Ff6omCXnE0Y94bZa5blXGmIFOvTpEGDN2Q4MAetzjIIL+2fy7dhJ3s8 /CDdAIEodIgipXohDi+96bgbkcnIBsqWPQVn8voBBIG9dD3FK4QYayBU2T+D/uhJsLq/ 3qkcIeWWz3G5/yYIjqyyN7ARa8cJv+tYDxXYFppctoEGjQ0XQdkoHXFvM+RC+FO9NZCb wZ4Jey7brNMoFHtkI5nr8FCAAzEOwPBpUHzFcl9uaiiGUfiOxVMlBphgaRDSWVjTXEhc iZRQGN1bicsI3Y7Wya98M/eOg4Tu2bedry6qD3ZURWRGvvcdGGj/viRs5X+b/kbu8owP d2CQ== X-Received: by 10.68.212.170 with SMTP id nl10mr33327904pbc.39.1363611620282; Mon, 18 Mar 2013 06:00:20 -0700 (PDT) Received: from localhost ([182.48.109.29]) by mx.google.com with ESMTPS id xs10sm8167919pac.8.2013.03.18.06.00.14 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 18 Mar 2013 06:00:19 -0700 (PDT) From: Leo Liu Date: Mon, 18 Mar 2013 21:00:08 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hello Stefan, The attached patch looks like a good addition to compile.el. Bind it to C-o as in occur-mode. -- Leo diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 68a83b47..b82afc67 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1810,6 +1810,7 @@ (defvar compilation-minor-mode-map (define-key map [follow-link] 'mouse-face) (define-key map "\C-c\C-c" 'compile-goto-error) (define-key map "\C-m" 'compile-goto-error) + (define-key map "\C-o" 'compilation-display-error) (define-key map "\C-c\C-k" 'kill-compilation) (define-key map "\M-n" 'compilation-next-error) (define-key map "\M-p" 'compilation-previous-error) @@ -1854,6 +1855,7 @@ (defvar compilation-mode-map (define-key map [follow-link] 'mouse-face) (define-key map "\C-c\C-c" 'compile-goto-error) (define-key map "\C-m" 'compile-goto-error) + (define-key map "\C-o" 'compilation-display-error) (define-key map "\C-c\C-k" 'kill-compilation) (define-key map "\M-n" 'compilation-next-error) (define-key map "\M-p" 'compilation-previous-error) @@ -2295,6 +2297,12 @@ (defun compilation-previous-file (n) (interactive "p") (compilation-next-file (- n))) +(defun compilation-display-error () + "Display the source for current error in another window." + (interactive) + (setq compilation-current-error (point)) + (next-error-no-select 0)) + (defun kill-compilation () "Kill the process made by the \\[compile] or \\[grep] commands." (interactive) From unknown Tue Jun 24 20:54:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13992: 24.3; New command compilation-display-error Resent-From: Eli Zaretskii Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Mar 2013 17:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Liu Cc: 13992@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 13992-submit@debbugs.gnu.org id=B13992.13636279819327 (code B ref 13992); Mon, 18 Mar 2013 17:34:02 +0000 Received: (at 13992) by debbugs.gnu.org; 18 Mar 2013 17:33:01 +0000 Received: from localhost ([127.0.0.1]:33880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHdvh-0002QN-Aj for submit@debbugs.gnu.org; Mon, 18 Mar 2013 13:33:01 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:38739) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHdvg-0002Q2-0T for 13992@debbugs.gnu.org; Mon, 18 Mar 2013 13:33:00 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MJV00F009YST600@a-mtaout22.012.net.il> for 13992@debbugs.gnu.org; Mon, 18 Mar 2013 19:30:46 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MJV00FZN9ZADF90@a-mtaout22.012.net.il>; Mon, 18 Mar 2013 19:30:46 +0200 (IST) Date: Mon, 18 Mar 2013 19:30:54 +0200 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83txo81upd.fsf@gnu.org> References: X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > From: Leo Liu > Date: Mon, 18 Mar 2013 21:00:08 +0800 > > The attached patch looks like a good addition to compile.el. Bind it to > C-o as in occur-mode. -- Leo Thanks. The name of the command could have more mnemonic payload, though. How about compilation-msg-locus-other-window? [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/, no trust [80.179.55.172 listed in list.dnswl.org] 0.7 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% [score: 0.4799] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: 0.7 (/) > From: Leo Liu > Date: Mon, 18 Mar 2013 21:00:08 +0800 > > The attached patch looks like a good addition to compile.el. Bind it to > C-o as in occur-mode. -- Leo Thanks. The name of the command could have more mnemonic payload, though. How about compilation-msg-locus-other-window? From unknown Tue Jun 24 20:54:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13992: 24.3; New command compilation-display-error Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 18 Mar 2013 18:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Leo Liu Cc: 13992@debbugs.gnu.org Received: via spool by 13992-submit@debbugs.gnu.org id=B13992.136363048313159 (code B ref 13992); Mon, 18 Mar 2013 18:15:01 +0000 Received: (at 13992) by debbugs.gnu.org; 18 Mar 2013 18:14:43 +0000 Received: from localhost ([127.0.0.1]:33935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHea3-0003QC-Kj for submit@debbugs.gnu.org; Mon, 18 Mar 2013 14:14:43 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:45342) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHea1-0003Pz-MY for 13992@debbugs.gnu.org; Mon, 18 Mar 2013 14:14:42 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: At0KABK/CFFFpYZL/2dsb2JhbABEvg0EAnsXc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IPAS-Result: At0KABK/CFFFpYZL/2dsb2JhbABEvg0EAnsXc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDpHqBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="5174889" Received: from 69-165-134-75.dsl.teksavvy.com (HELO pastel.home) ([69.165.134.75]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 18 Mar 2013 14:12:58 -0400 Received: by pastel.home (Postfix, from userid 20848) id 978B3678E8; Mon, 18 Mar 2013 14:13:00 -0400 (EDT) From: Stefan Monnier Message-ID: References: Date: Mon, 18 Mar 2013 14:13:00 -0400 In-Reply-To: (Leo Liu's message of "Mon, 18 Mar 2013 21:00:08 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > The attached patch looks like a good addition to compile.el. Bind it to > C-o as in occur-mode. -- Leo Fine by me, Stefan From unknown Tue Jun 24 20:54:15 2025 X-Loop: help-debbugs@gnu.org Subject: bug#13992: 24.3; New command compilation-display-error Resent-From: Leo Liu Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Mar 2013 00:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13992 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 13992@debbugs.gnu.org Received: via spool by 13992-submit@debbugs.gnu.org id=B13992.136365147714400 (code B ref 13992); Tue, 19 Mar 2013 00:05:02 +0000 Received: (at 13992) by debbugs.gnu.org; 19 Mar 2013 00:04:37 +0000 Received: from localhost ([127.0.0.1]:34318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHk2e-0003kC-Ay for submit@debbugs.gnu.org; Mon, 18 Mar 2013 20:04:37 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:40131) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHk2c-0003k5-H9 for 13992@debbugs.gnu.org; Mon, 18 Mar 2013 20:04:35 -0400 Received: by mail-pd0-f174.google.com with SMTP id 10so981707pdi.33 for <13992@debbugs.gnu.org>; Mon, 18 Mar 2013 17:02:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:date:in-reply-to :message-id:user-agent:mime-version:content-type; bh=yXJJ8nF/aK+mBDjv3YYwBOnx3XdvNOcGhhRRsdyih3I=; b=LI4Z2TgkPNEhmg8s7e2IT4Qsj4HrkWmD2pP+GuQjevZAZBhV3RHaO9NCPbMiIb6cJr THz7KsgkK/hRD1gHPfMqT0IH52MFUNKoXhV7VwAfDgIPuQ+mtVC2IElxWbOgjdJWsdoh py1YS4lrNLVl02K1etEPAFL10uLcXq9PhAZjtdiaMt5pZAKpnRduMTB0TjGbXPZ2Q4Pf LYSnMakrbKuTONdA7mCINP46NvAkIpxLKkoVNO1tRX8FZh39qVGVP4pMcKxEuhhnTYOe LA8FSn0vQb6FJnrjdO7ldUVGF9J4l0PfRS3Yny1nHc1web3JI70gC+8vTnrMpp++kOVz Uxsw== X-Received: by 10.68.224.65 with SMTP id ra1mr44652pbc.55.1363651376939; Mon, 18 Mar 2013 17:02:56 -0700 (PDT) Received: from localhost ([182.48.109.29]) by mx.google.com with ESMTPS id fc8sm10014673pad.21.2013.03.18.17.02.52 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 18 Mar 2013 17:02:56 -0700 (PDT) From: Leo Liu References: <83txo81upd.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= Date: Tue, 19 Mar 2013 08:02:47 +0800 In-Reply-To: <83txo81upd.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 18 Mar 2013 19:30:54 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) On 2013-03-19 01:30 +0800, Eli Zaretskii wrote: > The name of the command could have more mnemonic payload, though. How > about compilation-msg-locus-other-window? The name 'compilation-display-error' is more consistent with how things are named in compile.el, for example, compile-goto-error. And commands end with -other-window usually switch you to that window. Leo From unknown Tue Jun 24 20:54:15 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.428 (Entity 5.428) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Liu Subject: bug#13992: closed (Re: bug#13992: 24.3; New command compilation-display-error) Message-ID: References: X-Gnu-PR-Message: they-closed 13992 X-Gnu-PR-Package: emacs Reply-To: 13992@debbugs.gnu.org Date: Tue, 19 Mar 2013 00:23:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1363652582-16094-1" This is a multi-part message in MIME format... ------------=_1363652582-16094-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #13992: 24.3; New command compilation-display-error which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 13992@debbugs.gnu.org. --=20 13992: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D13992 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1363652582-16094-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 13992-done) by debbugs.gnu.org; 19 Mar 2013 00:22:16 +0000 Received: from localhost ([127.0.0.1]:34328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHkJk-0004AS-Cq for submit@debbugs.gnu.org; Mon, 18 Mar 2013 20:22:16 -0400 Received: from mail-pb0-f52.google.com ([209.85.160.52]:41731) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHkJi-0004AK-Dd for 13992-done@debbugs.gnu.org; Mon, 18 Mar 2013 20:22:15 -0400 Received: by mail-pb0-f52.google.com with SMTP id ma3so6870360pbc.39 for <13992-done@debbugs.gnu.org>; Mon, 18 Mar 2013 17:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:references:face:reply-to:date :in-reply-to:message-id:user-agent:mime-version:content-type; bh=V3UZHkg7hTVosJiFh7QcdYxdgoMTECY/HlwfHVIO/Gs=; b=zYt0AyesGvAdLkcjcCXnslOTejFcLZJ5c7jhrMc3TP7zhqryJ5IDrE59HvfQfFbR3Z DXxC+VzEAYGNtr20rnlyzj4VNHrTmEaKRTDHO4I2ERvrO0o+lBlPDuX3jYKQf/zQAWP2 r7O0OYd9fDsx1kNnDy3S2MQDdc5jsp6mRHh4bu5YZ1Phl92eVWSr1k+gGMH7WQ8FnipI Z2yjTOjCbc1DvfqHoN5OgMXWj4YMsXII6sRNUmP0H2N3TPne5/9+pLr7k+JMsXZhuQTw LMd8jWZqmolI2Gn4wbbLU/wPKWS7PVK9GIoaXq96IyUJSBjR2dWBeb/m9LupFiOdiIVZ E6lg== X-Received: by 10.66.175.142 with SMTP id ca14mr334652pac.52.1363652437229; Mon, 18 Mar 2013 17:20:37 -0700 (PDT) Received: from localhost ([182.48.109.29]) by mx.google.com with ESMTPS id wl14sm10065412pac.18.2013.03.18.17.20.34 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 18 Mar 2013 17:20:36 -0700 (PDT) From: Leo Liu To: Eli Zaretskii Subject: Re: bug#13992: 24.3; New command compilation-display-error References: <83txo81upd.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAGFBMVEUKDAg1NjRWV1V9fnyg op/DxcLk5uP8/voi63ReAAAACXBIWXMAAAWJAAAFiQFtaJ36AAAAB3RJTUUH1goZAgAz00bgXgAA AeVJREFUKM9lk0Fz2jAQhQXJD3CCO70CmcC1YMtcWyTZ14Bl69xats4N9r6/3zWQBlodNKNPu/s0 b1cCQFuZGpfVVh3vAvBJolIXRkapSuoRUtIdFyo1Y5xSdlAj7OtvD1XnXxmWRi+eWgcxyCed1lVV B1CrKyujMoi+eLA5kU1SsjoHlW+nQjTtFxk4MXgrOxvIqzoTZR8XgPaLl419zgsMaSGFPiUOZCIh thsx5Xy9NsK8Kwf/JoQgMxcVJ301HKkcSWaT0O7FY056J4U9xcYfnmVXG4801lW6lqwu2nKFZoHC HuzvaTVndZ+LaRQgZdthXw1cpynEkLEwyFHXk/aIxNQ6QeooJuzPMB+wn+D7JJNsiCcVA13/A3h/ xE9J+WidpAwoYNmRFwyvSRhNVtsdaAewzZZP5uw82QL9+tyNfocyP0McAzICUr5Mk9RdIjWasUNx aIIt6NK4ZtXIMdfMQt3nuMAyWbLI4DqZ4xPq/ag8jPond4XU/cLuOgw6XCFX/YCUfcDAMMH58fD4 G9kDchwfqVefkBwup2uZM+Q4WhJt5jN3AxXCsaS2yXEDuWgS8VOzW0gFjhEPmLyFMKBFaLb1HRwc DiaKwx0EeTMRYnYPQRW3PP4HApvlMv0PttX5v/D6Aws3IOSEwzmLAAAAAElFTkSuQmCC Date: Tue, 19 Mar 2013 08:20:29 +0800 In-Reply-To: (Leo Liu's message of "Tue, 19 Mar 2013 08:02:47 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.8.3) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 13992-done Cc: 13992-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: 13992@debbugs.gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Hi Eli, I have put the code in trunk. If you have a better name than compilation-display-error feel free to tweak it ;) Leo ------------=_1363652582-16094-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 18 Mar 2013 13:02:31 +0000 Received: from localhost ([127.0.0.1]:32864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHZht-00047o-Bu for submit@debbugs.gnu.org; Mon, 18 Mar 2013 09:02:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:46884) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UHZhn-00047X-B4 for submit@debbugs.gnu.org; Mon, 18 Mar 2013 09:02:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHZg6-0005ix-C4 for submit@debbugs.gnu.org; Mon, 18 Mar 2013 09:00:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-101.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID,USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:52986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHZg6-0005it-86 for submit@debbugs.gnu.org; Mon, 18 Mar 2013 09:00:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58225) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHZg0-00071r-2l for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2013 09:00:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UHZfp-0005ab-EX for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2013 09:00:32 -0400 Received: from mail-da0-x230.google.com ([2607:f8b0:400e:c00::230]:63700) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UHZfp-0005ZB-98 for bug-gnu-emacs@gnu.org; Mon, 18 Mar 2013 09:00:21 -0400 Received: by mail-da0-f48.google.com with SMTP id p8so491417dan.35 for ; Mon, 18 Mar 2013 06:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:subject:x-debbugs-cc:date:message-id :mime-version:content-type; bh=kQ7VLCcXX7bMNVGdN94ihbcnlKC4S9Q3+P8dOW6fAMU=; b=GmTJwFwPoL+Ff6omCXnE0Y94bZa5blXGmIFOvTpEGDN2Q4MAetzjIIL+2fy7dhJ3s8 /CDdAIEodIgipXohDi+96bgbkcnIBsqWPQVn8voBBIG9dD3FK4QYayBU2T+D/uhJsLq/ 3qkcIeWWz3G5/yYIjqyyN7ARa8cJv+tYDxXYFppctoEGjQ0XQdkoHXFvM+RC+FO9NZCb wZ4Jey7brNMoFHtkI5nr8FCAAzEOwPBpUHzFcl9uaiiGUfiOxVMlBphgaRDSWVjTXEhc iZRQGN1bicsI3Y7Wya98M/eOg4Tu2bedry6qD3ZURWRGvvcdGGj/viRs5X+b/kbu8owP d2CQ== X-Received: by 10.68.212.170 with SMTP id nl10mr33327904pbc.39.1363611620282; Mon, 18 Mar 2013 06:00:20 -0700 (PDT) Received: from localhost ([182.48.109.29]) by mx.google.com with ESMTPS id xs10sm8167919pac.8.2013.03.18.06.00.14 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 18 Mar 2013 06:00:19 -0700 (PDT) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.3; New command compilation-display-error X-Debbugs-CC: Stefan Monnier Date: Mon, 18 Mar 2013 21:00:08 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Hello Stefan, The attached patch looks like a good addition to compile.el. Bind it to C-o as in occur-mode. -- Leo diff --git a/lisp/progmodes/compile.el b/lisp/progmodes/compile.el index 68a83b47..b82afc67 100644 --- a/lisp/progmodes/compile.el +++ b/lisp/progmodes/compile.el @@ -1810,6 +1810,7 @@ (defvar compilation-minor-mode-map (define-key map [follow-link] 'mouse-face) (define-key map "\C-c\C-c" 'compile-goto-error) (define-key map "\C-m" 'compile-goto-error) + (define-key map "\C-o" 'compilation-display-error) (define-key map "\C-c\C-k" 'kill-compilation) (define-key map "\M-n" 'compilation-next-error) (define-key map "\M-p" 'compilation-previous-error) @@ -1854,6 +1855,7 @@ (defvar compilation-mode-map (define-key map [follow-link] 'mouse-face) (define-key map "\C-c\C-c" 'compile-goto-error) (define-key map "\C-m" 'compile-goto-error) + (define-key map "\C-o" 'compilation-display-error) (define-key map "\C-c\C-k" 'kill-compilation) (define-key map "\M-n" 'compilation-next-error) (define-key map "\M-p" 'compilation-previous-error) @@ -2295,6 +2297,12 @@ (defun compilation-previous-file (n) (interactive "p") (compilation-next-file (- n))) +(defun compilation-display-error () + "Display the source for current error in another window." + (interactive) + (setq compilation-current-error (point)) + (next-error-no-select 0)) + (defun kill-compilation () "Kill the process made by the \\[compile] or \\[grep] commands." (interactive) ------------=_1363652582-16094-1--