GNU bug report logs - #13962
24.3: build fails when make run as a sub-make process

Previous Next

Package: emacs;

Reported by: balducci <at> units.it

Date: Thu, 14 Mar 2013 18:26:01 UTC

Severity: important

Found in version 24.3

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#13962: closed (24.3: build fails when make run as a sub-make
 process)
Date: Mon, 18 Mar 2013 21:07:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Mon, 18 Mar 2013 14:04:31 -0700
with message-id <5147815F.9010906 <at> cs.ucla.edu>
and subject line Re: 24.3: build fails when make run as a sub-make process
has caused the debbugs.gnu.org bug report #13962,
regarding 24.3: build fails when make run as a sub-make process
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
13962: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13962
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: balducci <at> units.it
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3: build fails when make run as a sub-make process
Date: Thu, 14 Mar 2013 19:07:33 +0100
hello,

while building 24.3 I stumbled on the following problem.

The main Makefile contains the following two lines:


   info_misc=`cd $${thisdir}/doc/misc; ${MAKE} -s echo-info`; \

   (info_misc=`cd doc/misc; ${MAKE} -s echo-info`; \

Everything works nicely if I run make from the shell prompt.

However, I usually build emacs with a script which in turn is run from
a Makefile of mine. If I attempt to build this way, I find
that the definitions of info_misc above contain also the make messages
"Entering directory..." "Leaving directory...", which, of course,
break the build.

The problem is that -s suppresses recipe lines echoing, but NOT
directory change messages from make, which make emits when run in a
sub-make process (which is why I do not get errors when runnig from the
shell prompt, while I get errors when running from my script, run by 
make)

The above lines assume that the main Makefile will never be run by a
sub-make, which of course is true most of the time, but is false in my
case.

Everything is fixed joining --no-print-directory with the -s option, but,
as I was told by paul smith on the help-make mail list, that won't work
for non-GNU make. Following paul's suggestion, I propose:

=> use of MAKELEVEL=0, so that GNU make thinks to be a top-most level:
      info_misc=`cd doc/misc && MAKELEVEL=0 ${MAKE} -s echo-info`
   while other make's won't be disturbed
=> sed-ing the ${MAKE} -s echo-info command to strip off any spurios
   directory change message

Apologies if I have overlooked something

and thank you really very much for maintaining and developing emacs


ciao
gabriele


[Message part 3 (message/rfc822, inline)]
From: Paul Eggert <eggert <at> cs.ucla.edu>
To: 13962-done <at> debbugs.gnu.org
Subject: Re: 24.3: build fails when make run as a sub-make process
Date: Mon, 18 Mar 2013 14:04:31 -0700
Thanks for the report and idea for a fix.
I installed a MAKELEVEL=0 fix into trunk bzr 112086
and am marking this as done.


This bug report was last modified 12 years and 67 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.