GNU bug report logs - #13948
no key-binding-locus

Previous Next

Full log

Message #20 received at 13948 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Nicolas Richard <theonewiththeevillook <at> yahoo.fr>
Cc: 13948 <at> debbugs.gnu.org, Brian Malehorn <bmalehorn <at> gmail.com>
Subject: Re: bug#13948: no key-binding-locus
Date: Wed, 04 Jun 2014 09:50:17 -0400

> I also provide a rough patch for help-fns--key-bindings to show the
> keymap in C-h k.

Thanks.  But I think this is too wordy.  We only want to show the locus
for C-h k and not for C-h f (and only show it for the particular key
sequence used).

>   (let ((map (yf/key-binding-keymap key t)))
>     (if (eq map (current-global-map))
>         t
>       (yf/find-object-in-variables map))))

Why do we need to treat the global map specially?

> +                            "Describe key and its originating keymap"

Please punctuate your docstrings.

Could you turn it into a self-contained patch (e.g. move the yf/*
functions to help*.el and rename it accordingly)?


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.