Subject: bug#13946: closed (Re: bug#13946: 24.3; [PATCH] fix of apropos with words)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 18 Dec 2013 04:48:02 +0000

Your bug report

#13946: 24.3; [PATCH] fix of apropos with words

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
13946: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13946
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#13946: 24.3; [PATCH] fix of apropos with words
From: Chong Yidong <[email-masked]>
To: Shigeru Fukaya <[email-masked]>
Cc: [email-masked]
Date: Wed, 18 Dec 2013 12:47:11 +0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Shigeru Fukaya <[email-masked]> writes:

> `apropos' family with plural words returns unexpected symbols and are
> annoying.  It is because `apropos-words-to-regexp' doesn't work as
> documented/expected.
>
> The following is revised `apropos-words-to-regexp'.

Thanks, committed to trunk.

Subject: 24.3; [PATCH] fix of apropos with words
From: Shigeru Fukaya <[email-masked]>
To: [email-masked]
Date: Thu, 14 Mar 2013 00:21:29 +0900
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

`apropos' family with plural words returns unexpected symbols and are
annoying.  It is because `apropos-words-to-regexp' doesn't work as
documented/expected.

The following is revised `apropos-words-to-regexp'.

(defun apropos-words-to-regexp (words wild)
  "Make regexp matching any two of the words in WORDS."
  (if (null (cdr words))
      (car words)
    ;; assure all words are independent objects for delq
    (setq words (mapcar 'copy-sequence words))
    (mapconcat
     (lambda (w)
       (concat "\\(?:" w "\\)" ;; parens for synonyms
               wild
               "\\(?:"
               (mapconcat
                'identity
                (delete-dups (delq w (copy-sequence words)))
                "\\|")
               "\\)"))
     (delete-dups (copy-sequence words))
     "\\|")))

results:

(apropos-words-to-regexp '("A" "B") ".*?")
"\\(?:A\\).*?\\(?:B\\)\\|\\(?:B\\).*?\\(?:A\\)"

(apropos-words-to-regexp '("A" "B" "C") ".*?")
"\\(?:A\\).*?\\(?:B\\|C\\)\\|\\(?:B\\).*?\\(?:A\\|C\\)\\|\\(?:C\\).*?\\(?:A\\|B\\)"

(apropos-words-to-regexp '("A" "B" "B") ".*?")
"\\(?:A\\).*?\\(?:B\\)\\|\\(?:B\\).*?\\(?:A\\|B\\)"

(apropos-words-to-regexp '("A" "A" "B" "C" "C") ".*?")
"\\(?:A\\).*?\\(?:A\\|B\\|C\\)\\|\\(?:B\\).*?\\(?:A\\|C\\)\\|\\(?:C\\).*?\\(?:A\\|B\\|C\\)"

Additionally, in `apropos-parse-pattern', ".+" passed to
`apropos-words-to-regexp' wolud be better if ".+?".

Regards,
Shigeru.