GNU bug report logs - #13928
foo_SOURCES containing unexpanded $(var) breaks with 'subdir-object' option active

Previous Next

Full log

Message #69 received at 13928 <at> debbugs.gnu.org (full text, mbox):

From: Eric Blake <eblake <at> redhat.com>
To: Stefano Lattarini <stefano.lattarini <at> gmail.com>, automake-patches <at> gnu.org
Cc: Oleg Latin <jujulicca <at> gmail.com>, Diab Jerius <djerius <at> cfa.harvard.edu>,
 13928 <at> debbugs.gnu.org, Bert Wesarg <bert.wesarg <at> googlemail.com>
Subject: Re: [PATCH] compile: don't place built object files in $(srcdir),
 ever ...
Date: Fri, 02 Jan 2015 16:14:44 -0700

[Message part 1 (text/plain, inline)]

On 01/02/2015 11:49 AM, Stefano Lattarini wrote:
> ... even when a source file is specified as '$(srdir)/foo.c' or
> '$(top_srcdir)/bar.c'. And ditto for dependency-tracking makefile
> fragments (those under '.deps' directories).

> +++ b/NEWS

> @@ -88,6 +88,21 @@ New in 1.16:
>      using a private target that is only meant to bootstrap the required
>      makefile fragments.
>  
> +  - The 'subdir-object' option no longer causes object files corresponding
> +    to source files specified with an explicit '$(srcdir)' component to be
> +    placed in the source tree rather than in the build tree.
> +
> +    For example, if Makefile.am contains:
> +
> +        AUTOMAKE_OPTIONS = subdir-objects
> +        foo_SOURCES = $(srcdir)/foo.c $(srcdir)/s/bar.c $(top_srcdir)/baz.c
> +
> +    then "make all" will create 'foo.o' and 's/bar.o' $(builddir) rather

s|'s/bar.o'|'s/bar.o' in|

> +    than in $(srcdir), and 'baz.o' in $(top_builddir) rather than in
> +    $(top_srcdir).
> +
> +    This was the second part of automake bug#13928.
> +
>  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

And thanks for tackling this!

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.