From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 11 12:10:42 2013 Received: (at submit) by debbugs.gnu.org; 11 Mar 2013 16:10:42 +0000 Received: from localhost ([127.0.0.1]:46522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UF5JB-0001ku-5z for submit@debbugs.gnu.org; Mon, 11 Mar 2013 12:10:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34127) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UF0SB-0001Xr-Ce for submit@debbugs.gnu.org; Mon, 11 Mar 2013 06:59:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UF0RD-0000sA-AY for submit@debbugs.gnu.org; Mon, 11 Mar 2013 06:58:40 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-104.3 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, RP_MATCHES_RCVD, USER_IN_WHITELIST autolearn=unavailable version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60964) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF0RD-0000s5-7a for submit@debbugs.gnu.org; Mon, 11 Mar 2013 06:58:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF0RB-0001He-It for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2013 06:58:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UF0R9-0000rT-Kr for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2013 06:58:37 -0400 Received: from mout.gmx.net ([212.227.17.21]:50023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UF0R9-0000r5-BT for bug-gnu-emacs@gnu.org; Mon, 11 Mar 2013 06:58:35 -0400 Received: from mailout-de.gmx.net ([10.1.76.1]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0M8npK-1U2rtU41ka-00C91e for ; Mon, 11 Mar 2013 11:58:33 +0100 Received: (qmail invoked by alias); 11 Mar 2013 10:58:32 -0000 Received: from 178-27-35-194-dynip.superkabel.de (EHLO [192.168.71.20]) [178.27.35.194] by mail.gmx.net (mp001) with SMTP; 11 Mar 2013 11:58:32 +0100 X-Authenticated: #858129 X-Provags-ID: V01U2FsdGVkX1/eOJBKl3jerHuyUJlCjc9JQx+Ck/ebGMW6PPxFHs 29Scp/BBNToudR Message-ID: <513DB8CC.2060900@gmx.net> Date: Mon, 11 Mar 2013 11:58:20 +0100 From: Martin von Gagern User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130310 Thunderbird/17.0.4 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: ERRMAX in lib-src/pop.c X-Enigmail-Version: 1.5 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2JPUQTEQKEROEEUSSCTHV" X-Y-GMX-Trusted: 0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.2 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 11 Mar 2013 12:10:40 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.9 (------) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2JPUQTEQKEROEEUSSCTHV Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi! The file "lib-src/pop.c" refers to a macro "ERRMAX" which isn't declared on my system. Judging from the commit which introduced it [1], I'd say this should be ERROR_MAX instead. [1] http://bzr.savannah.gnu.org/lh/emacs/emacs-24/revision/109003/lib-src/pop= =2Ec#lib-src/pop.c Greetings, Martin von Gagern ------enig2JPUQTEQKEROEEUSSCTHV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iEYEARECAAYFAlE9uNYACgkQRhp6o4m9dFvqugCeKussgE3srrjdQ5Ik/gc3ARRt u04AoIqlk4tjfPH5/QR0B42/znChn1xF =ojwp -----END PGP SIGNATURE----- ------enig2JPUQTEQKEROEEUSSCTHV-- From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 11 13:24:58 2013 Received: (at 13925) by debbugs.gnu.org; 11 Mar 2013 17:24:58 +0000 Received: from localhost ([127.0.0.1]:46639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UF6T2-0003W6-6d for submit@debbugs.gnu.org; Mon, 11 Mar 2013 13:24:58 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:40545 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UF6T0-0003Vz-0M for 13925@debbugs.gnu.org; Mon, 11 Mar 2013 13:24:54 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UF6S6-0004e8-5E; Mon, 11 Mar 2013 13:23:58 -0400 From: Glenn Morris To: Martin von Gagern Subject: Re: bug#13925: ERRMAX in lib-src/pop.c References: <513DB8CC.2060900@gmx.net> X-Spook: Mole FIPS140 Qaddafi tempest Indigo mindwar Bletchley X-Ran: en@N(5V>.F$~o=Jr=h_Cf%M?< (Martin von Gagern's message of "Mon, 11 Mar 2013 11:58:20 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 13925 Cc: 13925@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -9.3 (---------) Martin von Gagern wrote: > The file "lib-src/pop.c" refers to a macro "ERRMAX" which isn't declared > on my system. Judging from the commit which introduced it [1], I'd say > this should be ERROR_MAX instead. Congratulations, you found the deliberate mistake. :) Please try at least a test build of a pretest next time. This issue would have been obvious and easy to fix at any time during the past several months of pretesting. Emacs can be built on so many systems and in so many configurations that we rely on the help of pretesters to test them. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 12 16:02:02 2013 Received: (at 13925) by debbugs.gnu.org; 12 Mar 2013 20:02:02 +0000 Received: from localhost ([127.0.0.1]:49365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UFVOZ-0004Fz-7J for submit@debbugs.gnu.org; Tue, 12 Mar 2013 16:02:01 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:40151) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UFVOW-0004Fl-03 for 13925@debbugs.gnu.org; Tue, 12 Mar 2013 16:01:57 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id B23D2A6000C; Tue, 12 Mar 2013 13:00:48 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u0C05I+UpW5M; Tue, 12 Mar 2013 13:00:48 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 05317A60007; Tue, 12 Mar 2013 13:00:48 -0700 (PDT) Message-ID: <513F896F.4030804@cs.ucla.edu> Date: Tue, 12 Mar 2013 13:00:47 -0700 From: Paul Eggert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: 13925@debbugs.gnu.org Subject: Re: ERRMAX in lib-src/pop.c Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: 13925 Cc: Glenn Morris X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.8 (------) Sorry about the typo; it didn't trigger on my compilation platforms. Here's the obvious patch. Glenn, should I install this into the emacs-24 branch or into the trunk? I'm a bit fuzzy on the branch status now that 24.3 has been released. === modified file 'lib-src/ChangeLog' --- lib-src/ChangeLog 2013-03-11 02:35:23 +0000 +++ lib-src/ChangeLog 2013-03-12 19:57:55 +0000 @@ -1,3 +1,9 @@ +2013-03-12 Paul Eggert + + * pop.c: Fix ERRMAX typo (Bug#13925). + (socket_connection) [!HAVE_KRB5_ERROR_TEXT && HAVE_KRB5_ERROR_E_TEXT]: + Use ERROR_MAX, not ERRMAX. + 2013-03-11 Glenn Morris * Version 24.3 released. === modified file 'lib-src/pop.c' --- lib-src/pop.c 2013-01-01 09:11:05 +0000 +++ lib-src/pop.c 2013-03-12 19:56:43 +0000 @@ -1198,7 +1198,7 @@ } #elif defined HAVE_KRB5_ERROR_E_TEXT if (err_ret && err_ret->e_text && **err_ret->e_text) - snprintf (pop_error + pop_error_len, ERRMAX - pop_error_len, + snprintf (pop_error + pop_error_len, ERROR_MAX - pop_error_len, " [server says '%s']", *err_ret->e_text); #endif if (err_ret) From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 12 17:58:10 2013 Received: (at 13925) by debbugs.gnu.org; 12 Mar 2013 21:58:10 +0000 Received: from localhost ([127.0.0.1]:49545 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UFXCz-0007yS-N4 for submit@debbugs.gnu.org; Tue, 12 Mar 2013 17:58:09 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:56258 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UFXCx-0007yL-LN for 13925@debbugs.gnu.org; Tue, 12 Mar 2013 17:58:08 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1UFXBw-0002It-Cm; Tue, 12 Mar 2013 17:57:04 -0400 From: Glenn Morris To: Paul Eggert Subject: Re: ERRMAX in lib-src/pop.c References: <513F896F.4030804@cs.ucla.edu> X-Spook: 9/11 CDC Peking Sundevil ANDVT digicash SAFE Pine Gap X-Ran: 81]w*8j}l>v.ci[3T]~c[yPB4+FIa("1^gDfIGZ7IxYxUX;-XW@|!b.J;Ff1@qSTr*J|M' X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 12 Mar 2013 17:57:04 -0400 In-Reply-To: <513F896F.4030804@cs.ucla.edu> (Paul Eggert's message of "Tue, 12 Mar 2013 13:00:47 -0700") Message-ID: <8zfw00i8nj.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -6.8 (------) X-Debbugs-Envelope-To: 13925 Cc: 13925@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -9.5 (---------) Paul Eggert wrote: > Here's the obvious patch. Glenn, should I install this into > the emacs-24 branch or into the trunk? I'm a bit fuzzy on > the branch status now that 24.3 has been released. It is a totally safe fix, so emacs-24. http://lists.gnu.org/archive/html/emacs-devel/2013-03/msg00058.html My rule of thumb: if we had to release from emacs-24 tomorrow due to some gaping security problem, am I happy to put this patch there today? From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 12 18:02:05 2013 Received: (at 13925-done) by debbugs.gnu.org; 12 Mar 2013 22:02:05 +0000 Received: from localhost ([127.0.0.1]:49558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UFXGn-00085P-4i for submit@debbugs.gnu.org; Tue, 12 Mar 2013 18:02:05 -0400 Received: from smtp.cs.ucla.edu ([131.179.128.62]:46563) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UFXGk-00084q-6p for 13925-done@debbugs.gnu.org; Tue, 12 Mar 2013 18:02:03 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 56630A60011; Tue, 12 Mar 2013 15:00:54 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LaZEEDIk+rDe; Tue, 12 Mar 2013 15:00:53 -0700 (PDT) Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E702BA6000C; Tue, 12 Mar 2013 15:00:53 -0700 (PDT) Message-ID: <513FA595.5030301@cs.ucla.edu> Date: Tue, 12 Mar 2013 15:00:53 -0700 From: Paul Eggert User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130219 Thunderbird/17.0.3 MIME-Version: 1.0 To: Glenn Morris Subject: Re: ERRMAX in lib-src/pop.c References: <513F896F.4030804@cs.ucla.edu> <8zfw00i8nj.fsf@fencepost.gnu.org> In-Reply-To: <8zfw00i8nj.fsf@fencepost.gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: 13925-done Cc: 13925-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.4 (-----) On 03/12/13 14:57, Glenn Morris wrote: > It is a totally safe fix, so emacs-24. Thanks, installed as emacs-24 bzr 111329 and marking this as done. From unknown Fri Jun 20 19:46:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 10 Apr 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator