GNU bug report logs - #13886
24.3; vc-annotate won't show the log entry with git backend and hidden annotatation

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: E Sabof <esabof <at> gmail.com>
Subject: bug#13886: closed (Re: bug#13886: 24.3; vc-annotate won't show
 the log entry with git backend and hidden annotatation)
Date: Mon, 25 Nov 2013 02:31:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 13886 <at> debbugs.gnu.org.

-- 
13886: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13886
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: E Sabof <esabof <at> gmail.com>
Cc: 13886-done <at> debbugs.gnu.org
Subject: Re: bug#13886: 24.3;
 vc-annotate won't show the log entry with git backend and hidden
 annotatation
Date: Mon, 25 Nov 2013 04:30:25 +0200

Version: 24.4

Thanks for the report, fixed in 115219.

Though I've changed it to use `beginning-of-line' for better
consistency, because implementations of this command in other backends
do that.

[Message part 3 (message/rfc822, inline)]

From: E Sabof <esabof <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; vc-annotate won't show the log entry with git backend and
	hidden annotatation
Date: Wed, 6 Mar 2013 02:37:51 +0000

[Message part 4 (text/plain, inline)]

While in vc-annotate mode, with a git backend, if one hides the
annotations with vc-annotate-toggle-annotation-visiblity, and
tries to run vc-annotate-show-log-revision-at-line, it will display the
message "Cannot extract revision number from the current line".
Fixable by changing (move-beginning-of-line 1) to (forward-line 0) here:

(defun vc-git-annotate-extract-revision-at-line ()
  (save-excursion
    (forward-line 0)
    (when (looking-at "\\([0-9a-f^][0-9a-f]+\\) \\(\\([^(]+\\) \\)?")
      (let ((revision (match-string-no-properties 1)))
(if (match-beginning 2)
    (let ((fname (match-string-no-properties 3)))
      ;; Remove trailing whitespace from the file name.
      (when (string-match " +\\'" fname)
(setq fname (substring fname 0 (match-beginning 0))))
      (cons revision
    (expand-file-name fname (vc-git-root default-directory))))
  revision)))))

Evgeni

[Message part 5 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.