GNU bug report logs - #13886
24.3; vc-annotate won't show the log entry with git backend and hidden annotatation

Previous Next

Package: emacs;

Reported by: E Sabof <esabof <at> gmail.com>

Date: Wed, 6 Mar 2013 02:39:01 UTC

Severity: normal

Tags: patch

Found in version 24.3

Fixed in version 24.4

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: E Sabof <esabof <at> gmail.com>
To: 13886 <at> debbugs.gnu.org
Subject: bug#13886: 24.3; vc-annotate won't show the log entry with git backend and hidden annotatation
Date: Wed, 6 Mar 2013 02:37:51 +0000
[Message part 1 (text/plain, inline)]
While in vc-annotate mode, with a git backend, if one hides the
annotations with vc-annotate-toggle-annotation-visiblity, and
tries to run vc-annotate-show-log-revision-at-line, it will display the
message "Cannot extract revision number from the current line".
Fixable by changing (move-beginning-of-line 1) to (forward-line 0) here:

(defun vc-git-annotate-extract-revision-at-line ()
  (save-excursion
    (forward-line 0)
    (when (looking-at "\\([0-9a-f^][0-9a-f]+\\) \\(\\([^(]+\\) \\)?")
      (let ((revision (match-string-no-properties 1)))
(if (match-beginning 2)
    (let ((fname (match-string-no-properties 3)))
      ;; Remove trailing whitespace from the file name.
      (when (string-match " +\\'" fname)
(setq fname (substring fname 0 (match-beginning 0))))
      (cons revision
    (expand-file-name fname (vc-git-root default-directory))))
  revision)))))

Evgeni
[Message part 2 (text/html, inline)]

This bug report was last modified 11 years and 236 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.